zogi - isPrivate of Contact

[bdogodev]

Through the webUI as the owner of a contact I changed the contact to be
'private', and sure enough when I log in through the webUI as the
non-owning user, the contact marked 'private' cannot be edited by this
non-owning user.  However, retrieving this contact via zOGI results in the
attribute always being returned as 0.   Looking at the FLAGS returned as
the non-owning user, I see that this contact is READONLY,  I'm surprised
that the isPrivate is still 0.

Is this a bug?   Or am I misunderstanding something.

Bernard

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams-2]

>Through the webUI as the owner of a contact I changed the contact to be
>'private', and sure enough when I log in through the webUI as the
>non-owning user, the contact marked 'private' cannot be edited by this
>non-owning user.  However, retrieving this contact via zOGI results in the
>attribute always being returned as 0.   Looking at the FLAGS returned as
>the non-owning user, I see that this contact is READONLY,

The flags are generated by the OGoAccessManager.

>  I'm surprised that the isPrivate is still 0.
>Is this a bug?   Or am I misunderstanding something.

Sounds like a bug to me.
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

> >  I'm surprised that the isPrivate is still 0.
> >Is this a bug?   Or am I misunderstanding something.
> Sounds like a bug to me.

This is checked in the runContact test script
<http://code.google.com/p/zogi/source/browse/trunk/TestScripts/runContact.py>

I've just verified that it works (at least on my test box).

The code is so straight forward -

[result addObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:
 ...
  [self ZERO:[eoContact valueForKey:@"isPrivate"]], @"isPrivate",
 ...
 nil]];

 - it is hard to see room for a bug.

What version of zOGI or ZideStore do you have?

As of r554 (2007-07-27) a check was added that encoded isAccount and
isPrivate as empty strings if the value was null.  That was wrong.
According to the commit log isAccount was changed to report zero when
null in r982 (2008-06-08).  I'd assume isPerson changed from '' to 0
about the same time.

Do you get a PRIVATE flag in FLAGS?  I suppose in hindsight that the
isPrivate attribute and PRIVATE flag is redundant. :)

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

> > >  I'm surprised that the isPrivate is still 0.
> > >Is this a bug?   Or am I misunderstanding something.
> > Sounds like a bug to me.
> This is checked in the runContact test script
> <http://code.google.com/p/zogi/source/browse/trunk/TestScripts/runContact.py>
> I've just verified that it works (at least on my test box).
> The code is so straight forward -
> [result addObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:
>  ...
>   [self ZERO:[eoContact valueForKey:@"isPrivate"]], @"isPrivate",
>  ...
>  nil]];
>  - it is hard to see room for a bug.

I just toogled a contact via the WebUI and zOGI reports isPrivate
correctly in both states.

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[bdogodev]

> > I've just verified that it works (at least on my test box).
> > The code is so straight forward -
> > [result addObject:[NSMutableDictionary dictionaryWithObjectsAndKeys:
> >  ...
> >   [self ZERO:[eoContact valueForKey:@"isPrivate"]], @"isPrivate",
> >  ...
> >  nil]];
> >  - it is hard to see room for a bug.
>
> I just toogled a contact via the WebUI and zOGI reports isPrivate
> correctly in both states.

I am embarrassed to say that it is working for me now too.  I don't know
what I was doing yesterday, but I am sure I was repeatedly getting a '0'
returned for a contact marked isPrivate.  I had even re-started zidestore
at one point in case the values were being cached but it made no
difference.  I was doing a search that returned multiple results, some of
which should have been '1' not '0', but they were all zeros.

I think I've worked out what was happening.  As root, I had checked the
'private/readonly' box on an isSystem user.  I think that explains why I
was seeing READONLY in the Flags, but isPrivate was 0.  My tests today on
non-system users who are marked private works as expected.  Because the
webUI says 'private/readonly' I took that to mean that the isPrivate flag
would be set.  However, thinking about it now, that doesn't really make
any sense - why would one want private system users?

My apologies for wasting your time.


Bernard


--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc