wxAuiToolBarItem public members

[Vadim Zeitlin-4]

 Hello,

 It would be great if we could make the members of this class private to
avoid the problems we had so many times with public members in the past
(impossibility to change anything about them without breaking backwards
compatibility). It looks like only wxAuiToolBar should have write access to
them and the rest of the world could use getters to just inspect them.

 And it would be even greater if this could be done before 2.8.9 so that we
don't need to agonize about backwards compatibility later.

 TIA,
VZ


_______________________________________________
wx-dev mailing list
wx-dev@...
http://lists.wxwidgets.org/mailman/listinfo/wx-dev

[Vadim Zeitlin-4]

On Tue, 2 Sep 2008 18:52:35 +0200 I wrote:

VZ>  It would be great if we could make the members of this class private

 Reading the header further I see a couple of other things which I'd like
to change:

- wxAuiToolBarEvent shouldn't have public members neither
- wxAuiToolBarItem::user_data should be wxUIntPtr and not long if it makes
  sense at all
- wxAuiToolBarItem::long_help is also currently unused so maybe it should
  be removed?
 
Could we review this before 2.8.9 if possible?

 Thanks,
VZ


_______________________________________________
wx-dev mailing list
wx-dev@...
http://lists.wxwidgets.org/mailman/listinfo/wx-dev

[Benjamin Williams]

Hi Vadim

On Tue, Sep 2, 2008 at 6:59 PM, Vadim Zeitlin <vadim@...> wrote:

> - wxAuiToolBarEvent shouldn't have public members neither
> - wxAuiToolBarItem::user_data should be wxUIntPtr and not long if it makes
>  sense at all
> - wxAuiToolBarItem::long_help is also currently unused so maybe it should
>  be removed?
>
> Could we review this before 2.8.9 if possible?

Yes.  I'll do this tomorrow.

All the best,
Ben
_______________________________________________
wx-dev mailing list
wx-dev@...
http://lists.wxwidgets.org/mailman/listinfo/wx-dev

[Tobias Hammer]

Hi,

these changes broke the aui-sample because it relies on access to the
now private members of wxAuiToolBarItem. The problem is, that
wxAuiToolbar::SetCustomOverflowItems expects an array of these items but
there is (IMO) no possibility to create such an item without adding it
to a toolbar. Am i missing something or is there a logical error in the
current implementation?

Best Regards,
Tobias Hammer


Benjamin Williams wrote:

> Hi Vadim
>
> On Tue, Sep 2, 2008 at 6:59 PM, Vadim Zeitlin <vadim@...> wrote:
>
>> - wxAuiToolBarEvent shouldn't have public members neither
>> - wxAuiToolBarItem::user_data should be wxUIntPtr and not long if it makes
>>  sense at all
>> - wxAuiToolBarItem::long_help is also currently unused so maybe it should
>>  be removed?
>>
>> Could we review this before 2.8.9 if possible?
>
> Yes.  I'll do this tomorrow.
>
> All the best,
> Ben
> _______________________________________________
> wx-dev mailing list
> wx-dev@...
> http://lists.wxwidgets.org/mailman/listinfo/wx-dev
>

_______________________________________________
wx-dev mailing list
wx-dev@...
http://lists.wxwidgets.org/mailman/listinfo/wx-dev