wrong JAVA_VENDOR

[Rick C. Petty-5]

If you install java/diablo-jdk16 instead of java/jdk16, the JAVA_VENDOR is
"freebsd".  The java/eclipse Makefile sets JAVA_VENDOR to "bsdjava".  Why
is this?  This makes it so that you cannot run eclipse with only
diablo-jdk16 installed.  Why is it even being set?  Isn't it enough that we
use JAVA_OS=native ???  I suggest the following patch:

--- ports/java/eclipse/Makefile.orig    2008-08-14 19:17:21.000000000 -0500
+++ ports/java/eclipse/Makefile 2008-08-26 19:13:03.000000000 -0500
@@ -60,10 +60,6 @@
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} >= 700000
-JAVA_VENDOR=   bsdjava
-.endif
-
 .if !defined(WITHOUT_MOZILLA)
 MAKE_MOZILLA=  make_mozilla
 BROWSER=       ${GECKO}


-- Rick C. Petty
_______________________________________________
freebsd-eclipse@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse
To unsubscribe, send any mail to "freebsd-eclipse-unsubscribe@..."

[Greg Lewis-2]

On Tue, Aug 26, 2008 at 02:13:41PM -0500, Rick C. Petty wrote:
> If you install java/diablo-jdk16 instead of java/jdk16, the JAVA_VENDOR is
> "freebsd".  The java/eclipse Makefile sets JAVA_VENDOR to "bsdjava".  Why
> is this?  This makes it so that you cannot run eclipse with only
> diablo-jdk16 installed.  Why is it even being set?  Isn't it enough that we
> use JAVA_OS=native ???  I suggest the following patch:

This is because people would install diablo-jdk15 on FreeBSD 7.x.  This
will run Java programmes if you have compat6x installed and some libmap
entries set up, but it won't run Eclipse.  Now that we have diablo-jdk16
which has a native 7.x version we could change 700000 to 800000, but the
risk is that people on 7.x with diablo-jdk15 already installed will then
be able to install with it guaranteed to break.

I'll try an alternative change.

> --- ports/java/eclipse/Makefile.orig    2008-08-14 19:17:21.000000000 -0500
> +++ ports/java/eclipse/Makefile 2008-08-26 19:13:03.000000000 -0500
> @@ -60,10 +60,6 @@
>  
>  .include <bsd.port.pre.mk>
>  
> -.if ${OSVERSION} >= 700000
> -JAVA_VENDOR=   bsdjava
> -.endif
> -
>  .if !defined(WITHOUT_MOZILLA)
>  MAKE_MOZILLA=  make_mozilla
>  BROWSER=       ${GECKO}
>
>
> -- Rick C. Petty
> _______________________________________________
> freebsd-eclipse@... mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse
> To unsubscribe, send any mail to "freebsd-eclipse-unsubscribe@..."

--
Greg Lewis                          Email   : glewis@...
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis@...
_______________________________________________
freebsd-eclipse@... mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-eclipse
To unsubscribe, send any mail to "freebsd-eclipse-unsubscribe@..."