testcases for io_channel()

[Masatake YAMATO-2]

I've ported a testcase for io_channel() from crackerjack to ltp.
I've added a directory ltp/testcases/kernel/syscalls/io_channel.

Signed-off-by: Masatake YAMATO <yamato@...>

Index: syscalls
===================================================================
RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
retrieving revision 1.198
diff -c -r1.198 syscalls
*** syscalls 6 Jun 2008 08:44:40 -0000 1.198
--- syscalls 18 Jun 2008 08:22:49 -0000
***************
*** 329,334 ****
--- 331,338 ----
  inotify01 inotify01
  inotify02 inotify02
 
+ io_cancel01 io_cancel01
+
  ioperm01 ioperm01
  ioperm02 ioperm02
 



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Wed, 2008-06-18 at 17:23 +0900, Masatake YAMATO wrote:
> I've ported a testcase for io_channel() from crackerjack to ltp.
> I've added a directory ltp/testcases/kernel/syscalls/io_channel.
>
> Signed-off-by: Masatake YAMATO <yamato@...>

Thanks Yamato for this porting as well. I will do the testing and
comment/merge soon. Meanwhile the merging may get delayed a bit, as i
might get held up in some other things.

But, please do not stop the porting effort for that reason. I will try
all my best to get these into LTP CVS for that particular month´s
release. Thank you very much for initiating and driving this porting
effort. We hope that these massive porting will definitely go a long way
in improving LTP´s kernel code coverage this year.

Regards--
Subrata

>
> Index: syscalls
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
> retrieving revision 1.198
> diff -c -r1.198 syscalls
> *** syscalls 6 Jun 2008 08:44:40 -0000 1.198
> --- syscalls 18 Jun 2008 08:22:49 -0000
> ***************
> *** 329,334 ****
> --- 331,338 ----
>   inotify01 inotify01
>   inotify02 inotify02
>  
> + io_cancel01 io_cancel01
> +
>   ioperm01 ioperm01
>   ioperm02 ioperm02
>  
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Wed, 2008-06-18 at 14:12 +0530, Subrata Modak wrote:
> On Wed, 2008-06-18 at 17:23 +0900, Masatake YAMATO wrote:
> > I've ported a testcase for io_channel() from crackerjack to ltp.
> > I've added a directory ltp/testcases/kernel/syscalls/io_channel.
> >
> > Signed-off-by: Masatake YAMATO <yamato@...>

Yamato,

I have tested this on various architectures and kernel versions. The
tests doesn´t seem to build well on some, where it builds and runs
properly on others. The problem seems to be because of absence of
libaio, which is not present on all machines.

We need to handle this at the Makefile level, by aborting building and
subsequently running it, if the library is not present on the system.
Please see the output it generated on the various architectures i
tested. I hope you will resend me a new patch which solves this issue.

1) 2.6.20-CBE, ppc64
BUILD=Failed
Error Message:
make[4]: Entering directory
`/root/subrata/ltp/ltp-full-20080531/testcases/kernel/syscalls/io_cancel'
cc -Wall  -I../../include -g -Wall -I../../../../include -Wall
io_cancel01.c  -laio -L../../../../lib -lltp -o io_cancel01
io_cancel01.c:23:20: error: libaio.h: No such file or directory
io_cancel01.c: In function ‘main’:
io_cancel01.c:73: error: ‘io_context_t’ undeclared (first use in this
function)
io_cancel01.c:73: error: (Each undeclared identifier is reported only
once
io_cancel01.c:73: error: for each function it appears in.)
io_cancel01.c:73: error: expected ‘;’ before ‘ctx’
io_cancel01.c:107: warning: implicit declaration of function ‘io_cancel’
io_cancel01.c:107: error: ‘ctx’ undeclared (first use in this function)

2) 2.6.16.60-0.6, ppc64
BUILD=Pass
RUN=Pass

3) 2.6.9-42.EL, ppc64
BUILD=Failed
Error Message:
cc -Wall  -I../../include -g -Wall -I../../../../include -Wall
io_cancel01.c  -laio -L../../../../lib -lltp -o io_cancel01
io_cancel01.c:23:20: libaio.h: No such file or directory
io_cancel01.c: In function `main':
io_cancel01.c:73: error: `io_context_t' undeclared (first use in this
function)
io_cancel01.c:73: error: (Each undeclared identifier is reported only
once
io_cancel01.c:73: error: for each function it appears in.)
io_cancel01.c:73: error: syntax error before "ctx"
io_cancel01.c:107: warning: implicit declaration of function `io_cancel'
io_cancel01.c:107: error: `ctx' undeclared (first use in this function)


4) 2.6.23.13, ia64
BUILD=Failed
Error Message:
make[4]: Entering directory
`/root/subrata/ltp/ltp-full-20080531/testcases/kernel/syscalls/io_cancel'
cc -Wall  -I../../include -g -Wall -I../../../../include -Wall
io_cancel01.c  -laio -L../../../../lib -lltp -o io_cancel01
io_cancel01.c:23:20: error: libaio.h: No such file or directory
io_cancel01.c: In function 'main':
io_cancel01.c:73: error: 'io_context_t' undeclared (first use in this
function)
io_cancel01.c:73: error: (Each undeclared identifier is reported only
once
io_cancel01.c:73: error: for each function it appears in.)
io_cancel01.c:73: error: expected ';' before 'ctx'
io_cancel01.c:107: warning: implicit declaration of function 'io_cancel'
io_cancel01.c:107: error: 'ctx' undeclared (first use in this function)

5) 2.6.16.21-0.8-default, ia64
BUILD=Pass
RUN=Pass

6) 2.6.9-70.EL, x86_64
BUILD=Pass
RUN=Pass

7) 2.6.18-92.el5, x86_64
make[4]: Entering directory
`/root/subrata/ltp/ltp-full-20080531/testcases/kernel/syscalls/io_cancel'
cc -Wall  -I../../include -g -Wall -I../../../../include -Wall
io_cancel01.c  -laio -L../../../../lib -lltp -o io_cancel01
io_cancel01.c:23:20: error: libaio.h: No such file or directory
io_cancel01.c: In function ‘main’:
io_cancel01.c:73: error: ‘io_context_t’ undeclared (first use in this
function)
io_cancel01.c:73: error: (Each undeclared identifier is reported only
once
io_cancel01.c:73: error: for each function it appears in.)
io_cancel01.c:73: error: expected ‘;’ before ‘ctx’
io_cancel01.c:107: warning: implicit declaration of function ‘io_cancel’
io_cancel01.c:107: error: ‘ctx’ undeclared (first use in this function)

8) 2.6.18-53.1.13.el5, i386
BUILD=Pass
RUN=Pass

9) 2.6.25-gcov-nomodconfig-smp, i386
BUILD=Pass
RUN=Pass

> Thanks Yamato for this porting as well. I will do the testing and
> comment/merge soon. Meanwhile the merging may get delayed a bit, as i
> might get held up in some other things.
>
> But, please do not stop the porting effort for that reason. I will try
> all my best to get these into LTP CVS for that particular month´s
> release. Thank you very much for initiating and driving this porting
> effort. We hope that these massive porting will definitely go a long way
> in improving LTP´s kernel code coverage this year.
>
> Regards--
> Subrata
>
> >
> > Index: syscalls
> > ===================================================================
> > RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v

Also, when you resend your patch send across:

RCS file: ltp/runtest/syscalls,v


Regards--
Subrata

> > retrieving revision 1.198
> > diff -c -r1.198 syscalls
> > *** syscalls 6 Jun 2008 08:44:40 -0000 1.198
> > --- syscalls 18 Jun 2008 08:22:49 -0000
> > ***************
> > *** 329,334 ****
> > --- 331,338 ----
> >   inotify01 inotify01
> >   inotify02 inotify02
> >  
> > + io_cancel01 io_cancel01
> > +
> >   ioperm01 ioperm01
> >   ioperm02 ioperm02
> >  
> >
> > -------------------------------------------------------------------------
> > Check out the new SourceForge.net Marketplace.
> > It's the best place to buy or sell services for
> > just about anything Open Source.
> > http://sourceforge.net/services/buy/index.php
> > _______________________________________________ Ltp-list mailing list Ltp-list@... https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Hi,

> Yamato,
>
> I have tested this on various architectures and kernel versions. The
> tests doesn´t seem to build well on some, where it builds and runs
> properly on others. The problem seems to be because of absence of
> libaio, which is not present on all machines.
>
> We need to handle this at the Makefile level, by aborting building and
> subsequently running it, if the library is not present on the system.
> Please see the output it generated on the various architectures i
> tested. I hope you will resend me a new patch which solves this issue.

Thank you for testing.
By refering modify_ldt/Makefile I've changed the Makefile.

Could you try again?

BTW, folowing code snippet in modify_ldt/Makefile is quite
useful for Makefiles for io_* test cases:

check_header = $(shell \
        if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
        then echo yes ; \
        else echo no ; fi)


How do you think putting this macro to
ltp/testcases/kernel/syscalls/check_header.mk?

So modify_ldt/Makefile and io_*/Makefile can reuse it with following line:


   include ../check_header.mk


> > > Index: syscalls
> > > ===================================================================
> > > RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
>
> Also, when you resend your patch send across:
>
> RCS file: ltp/runtest/syscalls,v

Likethis?

retrieving revision 1.198
diff -c -r1.198 syscalls
*** syscalls 6 Jun 2008 08:44:40 -0000 1.198
--- syscalls 18 Jun 2008 08:22:49 -0000
***************
*** 329,334 ****
--- 331,338 ----
  inotify01 inotify01
  inotify02 inotify02
 
+ io_cancel01 io_cancel01
+
  ioperm01 ioperm01
  ioperm02 ioperm02



Signed-off-by: Masatake YAMATO <yamato@...>


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Thu, 2008-06-19 at 14:35 +0900, Masatake YAMATO wrote:

> Hi,
>
> > Yamato,
> >
> > I have tested this on various architectures and kernel versions. The
> > tests doesn´t seem to build well on some, where it builds and runs
> > properly on others. The problem seems to be because of absence of
> > libaio, which is not present on all machines.
> >
> > We need to handle this at the Makefile level, by aborting building and
> > subsequently running it, if the library is not present on the system.
> > Please see the output it generated on the various architectures i
> > tested. I hope you will resend me a new patch which solves this issue.
>
> Thank you for testing.
> By refering modify_ldt/Makefile I've changed the Makefile.
>
> Could you try again?

I will test it again. Give me some time.

>
> BTW, folowing code snippet in modify_ldt/Makefile is quite
> useful for Makefiles for io_* test cases:
>
> check_header = $(shell \
> if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
> then echo yes ; \
> else echo no ; fi)
>
>
> How do you think putting this macro to
> ltp/testcases/kernel/syscalls/check_header.mk?
>
> So modify_ldt/Makefile and io_*/Makefile can reuse it with following line:
>    include ../check_header.mk

I think you can put that simple shell script inside the io_* Makefiles
alone. If check_header.mk is useful to all the
testcases/syscalls/*/Makefile, then it is worth creating one
syscalls/check_header.mk. If it is being used only by the
io_*/makefiles, then it will probably not serve any purpose.

>
>
> > > > Index: syscalls
> > > > ===================================================================
> > > > RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
> >
> > Also, when you resend your patch send across:
> >
> > RCS file: ltp/runtest/syscalls,v
>
> Likethis?
>
> retrieving revision 1.198
> diff -c -r1.198 syscalls
> *** syscalls 6 Jun 2008 08:44:40 -0000 1.198
> --- syscalls 18 Jun 2008 08:22:49 -0000
> ***************

I wanted like:

+++ ltp/runtest/syscalls.orig    6 Jun 2008 08:44:40 -0000       1.198
--- ltp/runtest/syscalls    18 Jun 2008 08:22:49 -0000

or much better like this:

+++ a/ltp/runtest/syscalls    6 Jun 2008 08:44:40 -0000       1.198
--- b/ltp/runtest/syscalls    18 Jun 2008 08:22:49 -0000


Regards--
Subrata

>

> *** 329,334 ****
> --- 331,338 ----
>   inotify01 inotify01
>   inotify02 inotify02
>  
> + io_cancel01 io_cancel01
> +
>   ioperm01 ioperm01
>   ioperm02 ioperm02
>
>
>
> Signed-off-by: Masatake YAMATO <yamato@...>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Thu, 2008-06-19 at 14:35 +0900, Masatake YAMATO wrote:

> Hi,
>
> > Yamato,
> >
> > I have tested this on various architectures and kernel versions. The
> > tests doesn´t seem to build well on some, where it builds and runs
> > properly on others. The problem seems to be because of absence of
> > libaio, which is not present on all machines.
> >
> > We need to handle this at the Makefile level, by aborting building and
> > subsequently running it, if the library is not present on the system.
> > Please see the output it generated on the various architectures i
> > tested. I hope you will resend me a new patch which solves this issue.
>
> Thank you for testing.
> By refering modify_ldt/Makefile I've changed the Makefile.
>
> Could you try again?

Thank you for resending the patch. I have again tested across various
architectures and kernels and had the following observation:

1) It encountered a build failure on a 2.6.7 kernel instead of presence
of header checking. Please see whether you need to check for other
parameters as well before building,
2) When it installed successfully, it also ran successfully on those
machines,
3) When it did not install as it did not build, the run will give errors
due to absence of io_cancel* binary(s) in testcases/bin. User will see
error message like:

initiation_status="pan(): execvp of 'io_cancel01' (tag io_cancel01)
failed.  errno:2  No such file or directory"

Instead of that we should have some meaningful error message (the same i
proposed to Li Zefan and Vijay Kumar) like:

io_cancel01 0 CONF : System doesn't support execution of the test

For this to happen, the runtest/syscalls should have the following code
instead:

io_cancel01 if [ -f io_cancel01 ]; then io_cancel; else echo
"io_cancel01 0 CONF : System doesn't support execution of the test";
exit 0; fi



Following are results as obtained on various machines/architectures:
=====================================================================
=====================================================================
1) Linux 2.6.23.13 #1 SMP Wed Jan 9 18:14:28 PST 2008 ia64 GNU/Linux
[io_cancel: No Build Failure, No Install, Will give error while running
as Binary not present in testcases/bin]
=====================================================================
2) Linux 2.6.16.21-0.8-default #1 SMP Mon Jul 3 18:25:39 UTC 2006 ia64
ia64 ia64 GNU/Linux
[io_cancel: No Build Failure, Installed and Run Successfully]
=====================================================================
3) Linux 2.6.9-70.EL #1 Fri May 2 13:00:36 EDT 2008 x86_64 x86_64 x86_64
GNU/Linux
[io_cancel: No Build Failure, Installed and Run Successful]
=====================================================================
4) Linux 2.6.18-92.el5 #1 SMP Tue Apr 29 13:16:15 EDT 2008 x86_64 x86_64
x86_64 GNU/Linux
[io_cancel: No Build Failure, No Install, Will give error while running
as Binary not present in testcases/bin]
=====================================================================
5) Linux 2.6.15-23-server #1 SMP Tue May 23 15:10:35 UTC 2006 i686
GNU/Linux
[io_cancel: No Build Failure, No Install, Will give error while running
as Binary not present in testcases/bin]
=====================================================================
6) Linux 2.6.7 #1 SMP Tue Aug 10 15:35:24 PDT 2004 i686 GNU/Linux  
[io_cancel: Build Failure,
cc -Wall  -I../../include -g -Wall -I../../../../include -Wall
io_cancel01.c  -laio -L../../../../lib -lltp -o io_cancel01
/usr/bin/ld: cannot find -laio
collect2: ld returned 1 exit status
make[4]: *** [io_cancel01] Error 1
]
=====================================================================
7) Linux 2.6.9-42.EL #1 SMP Wed Jul 12 23:22:51 EDT 2006 ppc64 ppc64
ppc64 GNU/Linux
[io_cancel: No Build Failure, No Install, Will give error while running
as Binary not present in testcases/bin]
=====================================================================
8) Linux 2.6.18-92.el5 #1 SMP Tue Apr 29 13:21:29 EDT 2008 ppc64 ppc64
ppc64 GNU/Linux
[io_cancel: No Build Failure, No Install, Will give error while running
as Binary not present in testcases/bin]
=====================================================================
=====================================================================

Regards--
Subrata

>
>
> BTW, folowing code snippet in modify_ldt/Makefile is quite
> useful for Makefiles for io_* test cases:
>
> check_header = $(shell \
> if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
> then echo yes ; \
> else echo no ; fi)
>
>
> How do you think putting this macro to
> ltp/testcases/kernel/syscalls/check_header.mk?
>
> So modify_ldt/Makefile and io_*/Makefile can reuse it with following line:
>
>
>    include ../check_header.mk
>
>
> > > > Index: syscalls
> > > > ===================================================================
> > > > RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
> >
> > Also, when you resend your patch send across:
> >
> > RCS file: ltp/runtest/syscalls,v
>
> Likethis?
>
> retrieving revision 1.198
> diff -c -r1.198 syscalls
> *** syscalls 6 Jun 2008 08:44:40 -0000 1.198
> --- syscalls 18 Jun 2008 08:22:49 -0000
> ***************
> *** 329,334 ****
> --- 331,338 ----
>   inotify01 inotify01
>   inotify02 inotify02
>  
> + io_cancel01 io_cancel01
> +
>   ioperm01 ioperm01
>   ioperm02 ioperm02
>
>
>
> Signed-off-by: Masatake YAMATO <yamato@...>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Hi,

> Thank you for resending the patch. I have again tested across various
> architectures and kernels and had the following observation:
>
> 1) It encountered a build failure on a 2.6.7 kernel instead of presence
> of header checking. Please see whether you need to check for other
> parameters as well before building,

I've intrduce the same technique used in
ltp/testcases/realtime/scripts/check_pi.sh. See attachment.

> 2) When it installed successfully, it also ran successfully on those
> machines,
> 3) When it did not install as it did not build, the run will give errors
> due to absence of io_cancel* binary(s) in testcases/bin. User will see
> error message like:
>
> initiation_status="pan(): execvp of 'io_cancel01' (tag io_cancel01)
> failed.  errno:2  No such file or directory"
>
> Instead of that we should have some meaningful error message (the same i
> proposed to Li Zefan and Vijay Kumar) like:
>
> io_cancel01 0 CONF : System doesn't support execution of the test
>
> For this to happen, the runtest/syscalls should have the following code
> instead:
>
> io_cancel01 if [ -f io_cancel01 ]; then io_cancel; else echo
> "io_cancel01 0 CONF : System doesn't support execution of the test";
> exit 0; fi

Instead of editing runtest/syscalls, I've used #ifdef/#endif in
io_cancel01.c. See the attachment.

Signed-off-by: Masatake YAMATO <yamato@...>



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

I am afraid that this new version introduced more failures than the
previous one. I have resorted to and merged the last stable patch given
by you. I have additionally included run-io_cancel.sh to check for
io_cancel01 binary availability on machines where it has not been built.
If the tests are built it will run the tests, else will show the CONF
message.

Thanks for bearing with me multiple testing cycles. This is now merged.
When you do porting in future you can look into this model as well.

I will not be expecting more patches for the porting project.

Regards--
Subrata

On Mon, 2008-06-23 at 22:24 +0900, Masatake YAMATO wrote:

> Hi,
>
> > Thank you for resending the patch. I have again tested across various
> > architectures and kernels and had the following observation:
> >
> > 1) It encountered a build failure on a 2.6.7 kernel instead of presence
> > of header checking. Please see whether you need to check for other
> > parameters as well before building,
>
> I've intrduce the same technique used in
> ltp/testcases/realtime/scripts/check_pi.sh. See attachment.
>
> > 2) When it installed successfully, it also ran successfully on those
> > machines,
> > 3) When it did not install as it did not build, the run will give errors
> > due to absence of io_cancel* binary(s) in testcases/bin. User will see
> > error message like:
> >
> > initiation_status="pan(): execvp of 'io_cancel01' (tag io_cancel01)
> > failed.  errno:2  No such file or directory"
> >
> > Instead of that we should have some meaningful error message (the same i
> > proposed to Li Zefan and Vijay Kumar) like:
> >
> > io_cancel01 0 CONF : System doesn't support execution of the test
> >
> > For this to happen, the runtest/syscalls should have the following code
> > instead:
> >
> > io_cancel01 if [ -f io_cancel01 ]; then io_cancel; else echo
> > "io_cancel01 0 CONF : System doesn't support execution of the test";
> > exit 0; fi
>
>
> Instead of editing runtest/syscalls, I've used #ifdef/#endif in
> io_cancel01.c. See the attachment.
>
> Signed-off-by: Masatake YAMATO <yamato@...>
>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak-2]

On Thu, Jun 26, 2008 at 7:03 PM, Subrata Modak <subrata@...> wrote:

I am afraid that this new version introduced more failures than the
previous one. I have resorted to and merged the last stable patch given
by you. I have additionally included run-io_cancel.sh to check for
io_cancel01 binary availability on machines where it has not been built.
If the tests are built it will run the tests, else will show the CONF
message.

Thanks for bearing with me multiple testing cycles. This is now merged.
When you do porting in future you can look into this model as well.

I will not be expecting more patches for the porting project.

I had a hangover when i types this. It should be:

I will now be expecting more patches for the porting project.

Regards--
Subrata

Regards--
Subrata

On Mon, 2008-06-23 at 22:24 +0900, Masatake YAMATO wrote:
> Hi,
>
> > Thank you for resending the patch. I have again tested across various
> > architectures and kernels and had the following observation:
> >
> > 1) It encountered a build failure on a 2.6.7 kernel instead of presence
> > of header checking. Please see whether you need to check for other
> > parameters as well before building,
>
> I've intrduce the same technique used in
> ltp/testcases/realtime/scripts/check_pi.sh. See attachment.
>
> > 2) When it installed successfully, it also ran successfully on those
> > machines,
> > 3) When it did not install as it did not build, the run will give errors
> > due to absence of io_cancel* binary(s) in testcases/bin. User will see
> > error message like:
> >
> > initiation_status="pan(): execvp of 'io_cancel01' (tag io_cancel01)
> > failed.  errno:2  No such file or directory"
> >
> > Instead of that we should have some meaningful error message (the same i
> > proposed to Li Zefan and Vijay Kumar) like:
> >
> > io_cancel01 0 CONF : System doesn't support execution of the test
> >
> > For this to happen, the runtest/syscalls should have the following code
> > instead:
> >
> > io_cancel01 if [ -f io_cancel01 ]; then io_cancel; else echo
> > "io_cancel01 0 CONF : System doesn't support execution of the test";
> > exit 0; fi
>
>
> Instead of editing runtest/syscalls, I've used #ifdef/#endif in
> io_cancel01.c. See the attachment.
>
> Signed-off-by: Masatake YAMATO <yamato@...>
>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

--
Regards & Thanks--
Subrata
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

> I am afraid that this new version introduced more failures than the
> previous one. I have resorted to and merged the last stable patch given
> by you. I have additionally included run-io_cancel.sh to check for
> io_cancel01 binary availability on machines where it has not been built.
> If the tests are built it will run the tests, else will show the CONF
> message.

I see. Could you apply following patch?
I'd like to use the mechanism you introduced in io_* testcases.
So I've made 'io_cancel' string in the script and Makefile a variable
to avoid mistake.

I made the patch from testcases/kernel/syscalls/io_cancel/Makefile,
not from ltp/testcases/kernel/syscalls/io_cancel/Makefile. Is this acceptable.
CVS reports like testcases/kernel/syscalls/io_cancel/Makefile.


Signed-off-by: Masatake YAMATO <yamato@...>

Index: testcases/kernel/syscalls/io_cancel/Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- testcases/kernel/syscalls/io_cancel/Makefile 26 Jun 2008 13:27:18 -0000 1.1
+++ testcases/kernel/syscalls/io_cancel/Makefile 27 Jun 2008 06:40:00 -0000
@@ -23,6 +23,8 @@
 
 SRCS    = $(wildcard *.c)
 TARGETS = $(patsubst %.c,%,$(SRCS))
+SYSCALL = io_cancel
+
 
 check_header = $(shell \
  if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
@@ -38,7 +40,7 @@
 
 install:
  @set -e; for i in $(TARGETS); do ln -f $$i ../../../bin/$$i ; done
- cp run-io_cancel.sh ../../../bin/run-io_cancel.sh
+ cp run-$(SYSCALL).sh ../../../bin/run-$(SYSCALL).sh
 
 else ### does not have libaio.h ###
 
Index: testcases/kernel/syscalls/io_cancel/run-io_cancel.sh
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/run-io_cancel.sh,v
retrieving revision 1.1
diff -u -r1.1 run-io_cancel.sh
--- testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 26 Jun 2008 13:27:18 -0000 1.1
+++ testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 27 Jun 2008 06:40:00 -0000
@@ -1,9 +1,11 @@
 #!/bin/sh
 
-if [ -f $LTPROOT/testcases/bin/io_cancel01 ]; then
-         $LTPROOT/testcases/bin/io_cancel01
+syscall=io_cancel
+
+if [ -f $LTPROOT/testcases/bin/${syscall}01 ]; then
+         $LTPROOT/testcases/bin/${syscall}01
 else
-         echo "io_cancel01 0 CONF : System doesn't support execution of the test"
+         echo "${syscall}01 0 CONF : System doesn't support execution of the test"
 
 fi
 

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Fri, 2008-06-27 at 16:16 +0900, Masatake YAMATO wrote:

> > I am afraid that this new version introduced more failures than the
> > previous one. I have resorted to and merged the last stable patch given
> > by you. I have additionally included run-io_cancel.sh to check for
> > io_cancel01 binary availability on machines where it has not been built.
> > If the tests are built it will run the tests, else will show the CONF
> > message.
>
> I see. Could you apply following patch?
> I'd like to use the mechanism you introduced in io_* testcases.
> So I've made 'io_cancel' string in the script and Makefile a variable
> to avoid mistake.
>
> I made the patch from testcases/kernel/syscalls/io_cancel/Makefile,
> not from ltp/testcases/kernel/syscalls/io_cancel/Makefile. Is this acceptable.

Yes it is.

> CVS reports like testcases/kernel/syscalls/io_cancel/Makefile.
>
>
> Signed-off-by: Masatake YAMATO <yamato@...>
>

Thanks. This has been merged.

I would be eagerly waiting to see the next set of porting Patches
hitting LTP mailing list soon.

Regards--
Subrata

> Index: testcases/kernel/syscalls/io_cancel/Makefile
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/Makefile,v
> retrieving revision 1.1
> diff -u -r1.1 Makefile
> --- testcases/kernel/syscalls/io_cancel/Makefile 26 Jun 2008 13:27:18 -0000 1.1
> +++ testcases/kernel/syscalls/io_cancel/Makefile 27 Jun 2008 06:40:00 -0000
> @@ -23,6 +23,8 @@
>
>  SRCS    = $(wildcard *.c)
>  TARGETS = $(patsubst %.c,%,$(SRCS))
> +SYSCALL = io_cancel
> +
>
>  check_header = $(shell \
>   if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
> @@ -38,7 +40,7 @@
>
>  install:
>   @set -e; for i in $(TARGETS); do ln -f $$i ../../../bin/$$i ; done
> - cp run-io_cancel.sh ../../../bin/run-io_cancel.sh
> + cp run-$(SYSCALL).sh ../../../bin/run-$(SYSCALL).sh
>
>  else ### does not have libaio.h ###
>
> Index: testcases/kernel/syscalls/io_cancel/run-io_cancel.sh
> ===================================================================
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/run-io_cancel.sh,v
> retrieving revision 1.1
> diff -u -r1.1 run-io_cancel.sh
> --- testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 26 Jun 2008 13:27:18 -0000 1.1
> +++ testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 27 Jun 2008 06:40:00 -0000
> @@ -1,9 +1,11 @@
>  #!/bin/sh
>
> -if [ -f $LTPROOT/testcases/bin/io_cancel01 ]; then
> -         $LTPROOT/testcases/bin/io_cancel01
> +syscall=io_cancel
> +
> +if [ -f $LTPROOT/testcases/bin/${syscall}01 ]; then
> +         $LTPROOT/testcases/bin/${syscall}01
>  else
> -         echo "io_cancel01 0 CONF : System doesn't support execution of the test"
> +         echo "${syscall}01 0 CONF : System doesn't support execution of the test"
>
>  fi
>

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Subrata Modak]

On Fri, 2008-06-27 at 16:28 +0530, Subrata Modak wrote:

> On Fri, 2008-06-27 at 16:16 +0900, Masatake YAMATO wrote:
> > > I am afraid that this new version introduced more failures than the
> > > previous one. I have resorted to and merged the last stable patch given
> > > by you. I have additionally included run-io_cancel.sh to check for
> > > io_cancel01 binary availability on machines where it has not been built.
> > > If the tests are built it will run the tests, else will show the CONF
> > > message.
> >
> > I see. Could you apply following patch?
> > I'd like to use the mechanism you introduced in io_* testcases.
> > So I've made 'io_cancel' string in the script and Makefile a variable
> > to avoid mistake.
> >
> > I made the patch from testcases/kernel/syscalls/io_cancel/Makefile,
> > not from ltp/testcases/kernel/syscalls/io_cancel/Makefile. Is this acceptable.
>
> Yes it is.
>
> > CVS reports like testcases/kernel/syscalls/io_cancel/Makefile.
> >
> >
> > Signed-off-by: Masatake YAMATO <yamato@...>
> >
>
> Thanks. This has been merged.
>
> I would be eagerly waiting to see the next set of porting Patches
> hitting LTP mailing list soon.

Hi Yamato,

Are we ready to resume again :-)

Regards--
Subrata

>
> Regards--
> Subrata
>
> > Index: testcases/kernel/syscalls/io_cancel/Makefile
> > ===================================================================
> > RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/Makefile,v
> > retrieving revision 1.1
> > diff -u -r1.1 Makefile
> > --- testcases/kernel/syscalls/io_cancel/Makefile 26 Jun 2008 13:27:18 -0000 1.1
> > +++ testcases/kernel/syscalls/io_cancel/Makefile 27 Jun 2008 06:40:00 -0000
> > @@ -23,6 +23,8 @@
> >
> >  SRCS    = $(wildcard *.c)
> >  TARGETS = $(patsubst %.c,%,$(SRCS))
> > +SYSCALL = io_cancel
> > +
> >
> >  check_header = $(shell \
> >   if echo "\#include <$(1)>" | $(CC) -E - > /dev/null 2>&1 ; \
> > @@ -38,7 +40,7 @@
> >
> >  install:
> >   @set -e; for i in $(TARGETS); do ln -f $$i ../../../bin/$$i ; done
> > - cp run-io_cancel.sh ../../../bin/run-io_cancel.sh
> > + cp run-$(SYSCALL).sh ../../../bin/run-$(SYSCALL).sh
> >
> >  else ### does not have libaio.h ###
> >
> > Index: testcases/kernel/syscalls/io_cancel/run-io_cancel.sh
> > ===================================================================
> > RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/run-io_cancel.sh,v
> > retrieving revision 1.1
> > diff -u -r1.1 run-io_cancel.sh
> > --- testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 26 Jun 2008 13:27:18 -0000 1.1
> > +++ testcases/kernel/syscalls/io_cancel/run-io_cancel.sh 27 Jun 2008 06:40:00 -0000
> > @@ -1,9 +1,11 @@
> >  #!/bin/sh
> >
> > -if [ -f $LTPROOT/testcases/bin/io_cancel01 ]; then
> > -         $LTPROOT/testcases/bin/io_cancel01
> > +syscall=io_cancel
> > +
> > +if [ -f $LTPROOT/testcases/bin/${syscall}01 ]; then
> > +         $LTPROOT/testcases/bin/${syscall}01
> >  else
> > -         echo "io_cancel01 0 CONF : System doesn't support execution of the test"
> > +         echo "${syscall}01 0 CONF : System doesn't support execution of the test"
> >
> >  fi
> >
>
>
> -------------------------------------------------------------------------
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@...
> https://lists.sourceforge.net/lists/listinfo/ltp-list

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list

[Masatake YAMATO-2]

Could you merge one more patch?

TEST_RETURN should not be inverted when logging.

Signed-off-by: Masatake YAMATO <yamato@...>

Index: testcases/kernel/syscalls/io_cancel/io_cancel01.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/io_cancel/io_cancel01.c,v
retrieving revision 1.1
diff -u -r1.1 io_cancel01.c
--- testcases/kernel/syscalls/io_cancel/io_cancel01.c 26 Jun 2008 13:27:18 -0000 1.1
+++ testcases/kernel/syscalls/io_cancel/io_cancel01.c 4 Jul 2008 05:09:11 -0000
@@ -115,7 +115,7 @@
 
  if (TEST_RETURN == expected_return) {
  tst_resm(TPASS, "expected failure - "
- "returned value = %d : %s", (-1 * TEST_RETURN),
+ "returned value = %d : %s", TEST_RETURN,
  strerror(-1 * TEST_RETURN));
  } else {
  tst_resm(TFAIL, "unexpected returned value - %d - "

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Ltp-list mailing list
Ltp-list@...
https://lists.sourceforge.net/lists/listinfo/ltp-list