speakup fixes

[Samuel Thibault]

Hello,

speakup modules didn't compile on arm & armel on first try, I had to
fix a few things.  Before I submit changes for a new package and ask
linux-modules-extra-2.6 to recompile it, could somebody

- install the attached speakup-source package
- apt-get source -t unstable linux-modules-extra-2.6
- apply the attached patch to re-enable arm archs and just compile the
speakup modules
- install any needed dependency
- dpkg-buildpackage -B

and tell me whether that worked?

Thanks,
Samuel


Index: linux-modules-extra-2.6/speakup/defines
===================================================================
--- linux-modules-extra-2.6/speakup/defines (r�vision 11720)
+++ linux-modules-extra-2.6/speakup/defines (copie de travail)
@@ -1,5 +1,5 @@
 [base]
-not-arches: arm armel sparc s390
+not-arches: s390
 desc: screen review module
 longdesc:
  Speakup allows you to interact with applications and Linux with audible
Index: linux-modules-extra-2.6/defines
===================================================================
--- linux-modules-extra-2.6/defines (r�vision 11720)
+++ linux-modules-extra-2.6/defines (copie de travail)
@@ -1,22 +1,3 @@
 [base]
 modules:
- atl2
- aufs
- btrfs
- drbd8
- eeepc-acpi
- et131x
- gspca
- kqemu
- iscsitarget
- loop-aes
- lzma
- nilfs2
- r6040
- redhat-cluster
- sfc
  speakup
- squashfs
- tp-smapi
- virtualbox-ose
- virtualbox-ose-guest

[Martin Guy]

On 6/29/08, Samuel Thibault <samuel.thibault@...> wrote:
>  - install the attached speakup-source package
>  - apt-get source -t unstable linux-modules-extra-2.6
>  - apply the attached patch to re-enable arm archs and just compile the
>  speakup modules

n2100:/home/martin/arm/linux-modules-extra-2.6-2.6.25# patch -p1 <
../speakup.patch
patching file speakup/defines
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file speakup/defines.rej
patching file defines
n2100:/home/martin/arm/linux-modules-extra-2.6-2.6.25#

Because it was "arm armel sparc" not arm armel sparc s390"
(applied by hand...)

>  - install any needed dependency
>  - dpkg-buildpackage -B

Runs to completion on armel, producing 96 .debs.
I don't see a *speakup*deb among them, though - is that right?

   M


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Martin Guy, le Sun 29 Jun 2008 10:49:31 +0100, a écrit :

> On 6/29/08, Samuel Thibault <samuel.thibault@...> wrote:
> >  - install the attached speakup-source package
> >  - apt-get source -t unstable linux-modules-extra-2.6
> >  - apply the attached patch to re-enable arm archs and just compile the
> >  speakup modules
>
> n2100:/home/martin/arm/linux-modules-extra-2.6-2.6.25# patch -p1 <
> ../speakup.patch
> patching file speakup/defines
> Hunk #1 FAILED at 1.
> 1 out of 1 hunk FAILED -- saving rejects to file speakup/defines.rej
> patching file defines
> n2100:/home/martin/arm/linux-modules-extra-2.6-2.6.25#
>
> Because it was "arm armel sparc" not arm armel sparc s390"
> (applied by hand...)

Mmm, you probably got the -4 version while my patch was against -5.
Never mind.

> >  - install any needed dependency
> >  - dpkg-buildpackage -B
>
> Runs to completion on armel, producing 96 .debs.
> I don't see a *speakup*deb among them, though - is that right?

Oops, no, I would have expected 8 speakup-modules-*deb packages.
I forgot to say you need to run ./debian/rules setup before
dpkg-buildpackage -B

Thanks,
Samuel


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Martin Guy]

> Mmm, you probably got the -4 version while my patch was against -5.

Indeed

>  > >  - install any needed dependency
>  > >  - dpkg-buildpackage -B
>  >
>  > I don't see a *speakup*deb among them, though - is that right?
>
> Oops, no, I would have expected 8 speakup-modules-*deb packages.
>  I forgot to say you need to run ./debian/rules setup before
>  dpkg-buildpackage -B

Oh, I'll set it off again. See you in another 24 hours... :)

   M


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Martin Guy, le Sun 29 Jun 2008 11:30:45 +0100, a écrit :

> >  > >  - install any needed dependency
> >  > >  - dpkg-buildpackage -B
> >  >
> >  > I don't see a *speakup*deb among them, though - is that right?
> >
> > Oops, no, I would have expected 8 speakup-modules-*deb packages.
> >  I forgot to say you need to run ./debian/rules setup before
> >  dpkg-buildpackage -B
>
> Oh, I'll set it off again. See you in another 24 hours... :)

Err, you mean for the compile time?
My patch makes it so that it will only compile speakup, that should be
much faster.

Thanks,
Samuel


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Arnaud Patard, le Sun 29 Jun 2008 14:01:51 +0200, a écrit :

> > - install the attached speakup-source package
> > - apt-get source -t unstable linux-modules-extra-2.6
> > - apply the attached patch to re-enable arm archs and just compile the
> > speakup modules
> > - install any needed dependency
> > - dpkg-buildpackage -B
> >
> > and tell me whether that worked?
>
> I took some shortcut by using directly the tarball from speaker-source
> and used the usual 'make -C ... M=...'. I got some .ko files so I think
> you can consider it worked :)

It worked for your variant, but linux-modules-extra-2.6 compiles 4
different ARM variants, and it happens that the bug I fixed was just in
one of them (ixp4xx, namely), there may be other bugs in other variants.

Thanks,
Samuel


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Arnaud Patard (Rtp)]

Samuel Thibault <samuel.thibault@...> writes:

> Hello,
>

Salut !

> speakup modules didn't compile on arm & armel on first try, I had to
> fix a few things.  Before I submit changes for a new package and ask
> linux-modules-extra-2.6 to recompile it, could somebody
>
> - install the attached speakup-source package
> - apt-get source -t unstable linux-modules-extra-2.6
> - apply the attached patch to re-enable arm archs and just compile the
> speakup modules
> - install any needed dependency
> - dpkg-buildpackage -B
>
> and tell me whether that worked?

I took some shortcut by using directly the tarball from speaker-source
and used the usual 'make -C ... M=...'. I got some .ko files so I think
you can consider it worked :)

If you need more information, just ask.


Arnaud


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Arnaud Patard (Rtp)]

Samuel Thibault <samuel.thibault@...> writes:

> Arnaud Patard, le Sun 29 Jun 2008 14:01:51 +0200, a écrit :
>> > - install the attached speakup-source package
>> > - apt-get source -t unstable linux-modules-extra-2.6
>> > - apply the attached patch to re-enable arm archs and just compile the
>> > speakup modules
>> > - install any needed dependency
>> > - dpkg-buildpackage -B
>> >
>> > and tell me whether that worked?
>>
>> I took some shortcut by using directly the tarball from speaker-source
>> and used the usual 'make -C ... M=...'. I got some .ko files so I think
>> you can consider it worked :)
>
> It worked for your variant, but linux-modules-extra-2.6 compiles 4
> different ARM variants, and it happens that the bug I fixed was just in
> one of them (ixp4xx, namely), there may be other bugs in other variants.

Ok. I'll use the long way. fyi, I'm on iop32x not ixp4xx.

Arnaud


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Martin Guy]

On 6/29/08, Samuel Thibault <samuel.thibault@...> wrote:
>  > >  I forgot to say you need to run ./debian/rules setup before
>  > >  dpkg-buildpackage -B
>  >
>  > Oh, I'll set it off again. See you in another 24 hours... :)
>
> Err, you mean for the compile time?
>  My patch makes it so that it will only compile speakup, that should be
>  much faster.

Same again. 48 binary packages, none of them *speakup*.deb, no mention
of "speakup" in the build log
http://n2100.martinwguy.co.uk/~martin/arm/linux-modules-extra-2.6-2.6.25/errs
It feels like I am failing to understand some aspect of what you need doing.

If you want to take this any further, you are welcome to send me
private email for an ssh account on the box in question.

     M


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Martin Guy, le Mon 30 Jun 2008 19:56:10 +0100, a écrit :

> On 6/29/08, Samuel Thibault <samuel.thibault@...> wrote:
> >  > >  I forgot to say you need to run ./debian/rules setup before
> >  > >  dpkg-buildpackage -B
> >  >
> >  > Oh, I'll set it off again. See you in another 24 hours... :)
> >
> > Err, you mean for the compile time?
> >  My patch makes it so that it will only compile speakup, that should be
> >  much faster.
>
> Same again. 48 binary packages, none of them *speakup*.deb, no mention
> of "speakup" in the build log
> http://n2100.martinwguy.co.uk/~martin/arm/linux-modules-extra-2.6-2.6.25/errs
> It feels like I am failing to understand some aspect of what you need doing.

Ah, understood, let me recap:

$ apt-get source -t unstable linux-modules-extra-2.6
$ cd linux-modules-extra-2.6-2.6.25
$ patch -p1 < ../patch
$ rm debian/control.md5sum debian/control -f
$ ./debian/rules setup
$ dpkg-buildpackage -B

We need to drop the control files by hand, it looks like there is no
dependency on the defines file.

Thanks for your patience,
Samuel


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Arnaud Patard (Rtp)]

"Martin Guy" <martinwguy@...> writes:


Hi,

> On 6/29/08, Samuel Thibault <samuel.thibault@...> wrote:
>>  > >  I forgot to say you need to run ./debian/rules setup before
>>  > >  dpkg-buildpackage -B
>>  >
>>  > Oh, I'll set it off again. See you in another 24 hours... :)
>>
>> Err, you mean for the compile time?
>>  My patch makes it so that it will only compile speakup, that should be
>>  much faster.
>
> Same again. 48 binary packages, none of them *speakup*.deb, no mention
> of "speakup" in the build log
> http://n2100.martinwguy.co.uk/~martin/arm/linux-modules-extra-2.6-2.6.25/errs
> It feels like I am failing to understand some aspect of what you need doing.

oops. Sorry, forgot to tell that I got the deb :

# ls *git20080628.dfsg.1-5_armel.deb
speakup-modules-2.6.25-2-iop32x_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
speakup-modules-2.6.25-2-orion5x_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
speakup-modules-2.6.25-2-ixp4xx_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
speakup-modules-2.6.25-2-versatile_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb

The trick was to run ./debian/rules maintainers-clean before

Samuel, does it miss some debs or it's all you needed ?

Arnaud


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Samuel Thibault]

Arnaud Patard, le Tue 01 Jul 2008 01:35:22 +0200, a écrit :

> oops. Sorry, forgot to tell that I got the deb :
>
> # ls *git20080628.dfsg.1-5_armel.deb
> speakup-modules-2.6.25-2-iop32x_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
> speakup-modules-2.6.25-2-orion5x_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
> speakup-modules-2.6.25-2-ixp4xx_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
> speakup-modules-2.6.25-2-versatile_2.6.25+3.0.3+git20080628.dfsg.1-5_armel.deb
>
> The trick was to run ./debian/rules maintainers-clean before
>
> Samuel, does it miss some debs or it's all you needed ?

Ok, cool, thanks!

Samuel


--
To UNSUBSCRIBE, email to debian-arm-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...