some libvisual-plugins-0.4.0 patches

[Thomas Klausner]

Hi!

Please Cc me answers, I'm not on this list.

Attached are some fixes for libvisual-plugins-0.4.0:
patch-ab:
compilation fix for gcc-2.95

patch-ac:
weird typo? in configure script, breaks configure runs
for me both with NetBSD's /bin/sh as with bash-3.1.
I don't understand how this can work for anyone...

Please include them in the next release!

Thanks,
 Thomas

$NetBSD: patch-ab,v 1.1 2005/06/16 21:19:08 kristerw Exp $

--- plugins/actor/pseudotoad_flower/notch.c.orig Thu Jun 16 22:50:58 2005
+++ plugins/actor/pseudotoad_flower/notch.c Thu Jun 16 22:52:05 2005
@@ -25,12 +25,13 @@
 #include <stdio.h>
 #include <math.h>
 #include <string.h>
+#include <stdlib.h>
 
 #include "notch.h"
 
 NOTCH_FILTER *  init_notch(float cutoff) {
     NOTCH_FILTER * l=malloc(sizeof(NOTCH_FILTER));
-    float steep = 0.99;;
+    float steep = 0.99;
     float r = steep * 0.99609375;
     float f = cos(M_PI * cutoff / SAMPLING_RATE);
     l->cutoff = cutoff;

$NetBSD$

--- configure.orig 2006-07-03 22:48:54.000000000 +0000
+++ configure
@@ -23466,11 +23466,11 @@ fi
   if test "$HAVE_GTK" = "yes"; then
     build_actor_plugins="$build_actor_plugins gdkpixbuf"
   else
-    { echo "$as_me:$LINENO: WARNING: *** GTK+ >= ${2.0} is not found.
+    { echo "$as_me:$LINENO: WARNING: *** GTK+ >= 2.0 is not found.
    The libvisual GdkPixbuf image loader plugin won't be build.
  GdkPixbuf is included within gtk-2.0 and newer, which can be
  downloaded at http://www.gtk.org/" >&5
-echo "$as_me: WARNING: *** GTK+ >= ${2.0} is not found.
+echo "$as_me: WARNING: *** GTK+ >= 2.0 is not found.
    The libvisual GdkPixbuf image loader plugin won't be build.
  GdkPixbuf is included within gtk-2.0 and newer, which can be
  downloaded at http://www.gtk.org/" >&2;}
@@ -23559,10 +23559,10 @@ fi
   if test "$HAVE_GSTREAMER" = "yes"; then
     build_actor_plugins="$build_actor_plugins gstreamer"
   else
-    { echo "$as_me:$LINENO: WARNING: *** GStreamer >= ${0.8} is not found.
+    { echo "$as_me:$LINENO: WARNING: *** GStreamer >= 0.8 is not found.
    The libvisual GStreamer viewer plugin won't be build.
  GStreamer can be downloaded from http://www.gstreamer.org/" >&5
-echo "$as_me: WARNING: *** GStreamer >= ${0.8} is not found.
+echo "$as_me: WARNING: *** GStreamer >= 0.8 is not found.
    The libvisual GStreamer viewer plugin won't be build.
  GStreamer can be downloaded from http://www.gstreamer.org/" >&2;}
   fi

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Libvisual-devel mailing list
Libvisual-devel@...
https://lists.sourceforge.net/lists/listinfo/libvisual-devel

[Dennis Smit]

Heya again,

I comitted the typo patch. The other patch is also against a auto generated file and
is bogus.

Thanks!

Cheers,
Dennis

On 7/4/06, Thomas Klausner <thomasklausner@...> wrote:

Hi!

Please Cc me answers, I'm not on this list.

Attached are some fixes for libvisual-plugins-0.4.0 :
patch-ab:
compilation fix for gcc-2.95

patch-ac:
weird typo? in configure script, breaks configure runs
for me both with NetBSD's /bin/sh as with bash-3.1.
I don't understand how this can work for anyone...

Please include them in the next release!

Thanks,
Thomas


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642


_______________________________________________
Libvisual-devel mailing list
Libvisual-devel@...
https://lists.sourceforge.net/lists/listinfo/libvisual-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Libvisual-devel mailing list
Libvisual-devel@...
https://lists.sourceforge.net/lists/listinfo/libvisual-devel

[Thomas Klausner]

On Sun, Jul 16, 2006 at 08:50:32PM +0200, Dennis Smit wrote:
> I comitted the typo patch. The other patch is also against a auto generated
> file and
> is bogus.

Thanks for the first.
I don't understand what you mean by bogus.
gtk_required_version and gst_required_version are m4_defines, so they
shouldn't be in "${}".

Attached a patch for configure.ac for that.

Cheers,
 Thomas

>
> On 7/4/06, Thomas Klausner <thomasklausner@...> wrote:
> >
> >Hi!
> >
> >Please Cc me answers, I'm not on this list.
> >
> >Attached are some fixes for libvisual-plugins-0.4.0:
> >patch-ab:
> >compilation fix for gcc-2.95
> >
> >patch-ac:
> >weird typo? in configure script, breaks configure runs
> >for me both with NetBSD's /bin/sh as with bash-3.1.
> >I don't understand how this can work for anyone...
> >
> >Please include them in the next release!
> >
> >Thanks,
> >Thomas
> >
> >
> >Using Tomcat but need to do more? Need to support web services, security?
> >Get stuff done quickly with pre-integrated technology to make your job
> >easier
> >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >
> >
> >_______________________________________________
> >Libvisual-devel mailing list
> >Libvisual-devel@...
> >https://lists.sourceforge.net/lists/listinfo/libvisual-devel
> >
> >
> >
> >

$NetBSD$

--- configure.ac.orig 2006-03-16 17:50:41.000000000 +0100
+++ configure.ac
@@ -127,7 +127,7 @@ if test "$ENABLE_PLUGIN_GDKPIXBUF" = "ye
   if test "$HAVE_GTK" = "yes"; then
     build_actor_plugins="$build_actor_plugins gdkpixbuf"
   else
-    AC_MSG_WARN([*** GTK+ >= ${gtk_required_version} is not found.
+    AC_MSG_WARN([*** GTK+ >= gtk_required_version is not found.
    The libvisual GdkPixbuf image loader plugin won't be build.
  GdkPixbuf is included within gtk-2.0 and newer, which can be
  downloaded at http://www.gtk.org/])
@@ -148,7 +148,7 @@ if test "$ENABLE_GSTREAMER_PLUGIN" = "ye
   if test "$HAVE_GSTREAMER" = "yes"; then
     build_actor_plugins="$build_actor_plugins gstreamer"
   else
-    AC_MSG_WARN([*** GStreamer >= ${gst_required_version} is not found.
+    AC_MSG_WARN([*** GStreamer >= gst_required_version is not found.
    The libvisual GStreamer viewer plugin won't be build.
  GStreamer can be downloaded from http://www.gstreamer.org/])
   fi


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Libvisual-devel mailing list
Libvisual-devel@...
https://lists.sourceforge.net/lists/listinfo/libvisual-devel

[Dennis Smit-3]

A bit late, but it has been merged locally, will hit CVS in 2 weeks or
so. Thanks a lot for your time and patience!

Cheers,
Dennis Smit

On Sun, 2006-07-16 at 21:31 +0200, Thomas Klausner wrote:

> On Sun, Jul 16, 2006 at 08:50:32PM +0200, Dennis Smit wrote:
> > I comitted the typo patch. The other patch is also against a auto generated
> > file and
> > is bogus.
>
> Thanks for the first.
> I don't understand what you mean by bogus.
> gtk_required_version and gst_required_version are m4_defines, so they
> shouldn't be in "${}".
>
> Attached a patch for configure.ac for that.
>
> Cheers,
>  Thomas
>
> >
> > On 7/4/06, Thomas Klausner <thomasklausner@...> wrote:
> > >
> > >Hi!
> > >
> > >Please Cc me answers, I'm not on this list.
> > >
> > >Attached are some fixes for libvisual-plugins-0.4.0:
> > >patch-ab:
> > >compilation fix for gcc-2.95
> > >
> > >patch-ac:
> > >weird typo? in configure script, breaks configure runs
> > >for me both with NetBSD's /bin/sh as with bash-3.1.
> > >I don't understand how this can work for anyone...
> > >
> > >Please include them in the next release!
> > >
> > >Thanks,
> > >Thomas
> > >
> > >
> > >Using Tomcat but need to do more? Need to support web services, security?
> > >Get stuff done quickly with pre-integrated technology to make your job
> > >easier
> > >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> > >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> > >
> > >
> > >_______________________________________________
> > >Libvisual-devel mailing list
> > >Libvisual-devel@...
> > >https://lists.sourceforge.net/lists/listinfo/libvisual-devel
> > >
> > >
> > >
> > >
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Libvisual-devel mailing list
> Libvisual-devel@...
> https://lists.sourceforge.net/lists/listinfo/libvisual-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Libvisual-devel mailing list
Libvisual-devel@...
https://lists.sourceforge.net/lists/listinfo/libvisual-devel