reviewed the rajarshi-descnames/ branch

View: New views
3 Messages — Rating Filter:   Alert me  

reviewed the rajarshi-descnames/ branch

by Egon Willighagen-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


Rajarshi,

I have (peer) reviewed [0] your branch, and commited my comments as 11680 and 11681. Look for lines with // FIXME: RGDN and // TODO: RGDN
I have not check failing unit tests, etc, assuming you took care of that. The patch generally looks fine; but please look at those FIXMEs.

Egon

--
----
http://chem-bla-ics.blogspot.com/

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel

Re: reviewed the rajarshi-descnames/ branch

by Rajarshi Guha-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Jul 22, 2008, at 7:58 AM, Egon Willighagen wrote:
>
> Rajarshi,
>
> I have (peer) reviewed [0] your branch, and commited my comments as  
> 11680 and 11681. Look for lines with // FIXME: RGDN and // TODO: RGDN

Thanks

> I have not check failing unit tests, etc, assuming you took care of  
> that.

The failures are the same as in trunk (actually fewer, since I fixed  
some)

- -------------------------------------------------------------------
Rajarshi Guha  <rguha@...>
GPG Fingerprint: D070 5427 CC5B 7938 929C  DD13 66A1 922C 51E7 9E84
- -------------------------------------------------------------------
A committee is a life form with six or more legs and no brain.
        -- Lazarus Long, "Time Enough For Love"


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkiF15EACgkQZqGSLFHnnoTfJgCbBBn9zjt+kl8QHXApT7rEdDg/
3ysAoLW2UhFg8zMDA6p3Q6zuUz4qCWq2
=Ukft
-----END PGP SIGNATURE-----

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel

Re: reviewed the rajarshi-descnames/ branch

by Egon Willighagen-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tue, Jul 22, 2008 at 1:58 PM, Egon Willighagen
<egon.willighagen@...> wrote:
> I have (peer) reviewed [0] your branch,

0.http://chem-bla-ics.blogspot.com/2008/07/peer-reviewed-chemoinformatics-why.html

--
----
http://chem-bla-ics.blogspot.com/

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel
LightInTheBox - Buy quality products at wholesale price