queryAdjacency(IBond a1, IBond b1, IBond a2, IBond b2) in UniversalIsomorphismTester

View: New views
3 Messages — Rating Filter:   Alert me  

queryAdjacency(IBond a1, IBond b1, IBond a2, IBond b2) in UniversalIsomorphismTester

by Stefan Kuhn-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi all,
there is a method private static boolean queryAdjacency(IBond a1, IBond b1,
IBond a2, IBond b2) in the UniversalIsomorphismTester. This method
- has no test
- is not used inside cdk somewhere
- it is unclear what it does (the javadoc coment and the paramters don't fit)
- is odd since it does a cast which is in no way enforced by the parameters
I suggest to remove this. Does anybody have an opinion or know anything about
this?
Stefan

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel

Re: queryAdjacency(IBond a1, IBond b1, IBond a2, IBond b2) in UniversalIsomorphismTester

by Egon Willighagen-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Sep 12, 2008 at 7:13 PM, Stefan Kuhn <stefan.kuhn@...> wrote:
> there is a method private static boolean queryAdjacency(IBond a1, IBond b1,
> IBond a2, IBond b2) in the UniversalIsomorphismTester. This method
> - has no test
> - is not used inside cdk somewhere
> - it is unclear what it does (the javadoc coment and the paramters don't fit)
> - is odd since it does a cast which is in no way enforced by the parameters

Who added it? And who made the changes which made the JavaDoc invalid?
What were all commit messages attached to the involved lines? Was the
method ever used? If so, what commits removed that use?

Egon

--
----
http://chem-bla-ics.blogspot.com/

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel

Re: queryAdjacency(IBond a1, IBond b1, IBond a2, IBond b2) in UniversalIsomorphismTester

by Rajarshi Guha-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Sep 12, 2008, at 1:13 PM, Stefan Kuhn wrote:

> Hi all,
> there is a method private static boolean queryAdjacency(IBond a1,  
> IBond b1,
> IBond a2, IBond b2) in the UniversalIsomorphismTester. This method
> - has no test
> - is not used inside cdk somewhere
> - it is unclear what it does (the javadoc coment and the paramters  
> don't fit)
> - is odd since it does a cast which is in no way enforced by the  
> parameters
> I suggest to remove this. Does anybody have an opinion or know  
> anything about
> this?

This is a good question - the svn log doesn't seem to provide much  
info on this. I'm hesitatnt to do anything to that code because I  
don't know how it works (other than broadly).

However, if the code is not called at any point,anywhere it's  
probably safe to remove

-------------------------------------------------------------------
Rajarshi Guha  <rguha@...>
GPG Fingerprint: D070 5427 CC5B 7938 929C  DD13 66A1 922C 51E7 9E84
-------------------------------------------------------------------
So the Zen master asked the hot-dog vendor,
"Can you make me one with everything?"
         - TauZero on Slashdot





-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cdk-devel mailing list
Cdk-devel@...
https://lists.sourceforge.net/lists/listinfo/cdk-devel
LightInTheBox - Buy quality products at wholesale price!