problems vpopmail + spamassassin

[Tica]

Hello list,
 
I'm using the following command line to run SpamAssassin:
 
spamd -d -v -u vpopmail -g vchkpw --user-config -r /var/run/spamd/spamd.pid --siteconfigpath=/etc/mail/spamassassin --configpath=/usr/share/spamassassin -s /var/log/spamd.log
 
But I just can't put it to work with vpopmail and user_prefs files...
 
When spamd run, it creates a .spamassassin dir in the /home/vpopmail ... and doesn't read each user_pref files at the domain/user/.spamassassin
 
Also... this error keep showing in system log: spamd: handle_user unable to find user: someuser@... (someuser@... used as example).
 
I'm using SA 3.2.5, perl 5.8.8.
 
I already tried several options without success...
 
Please... anyone may help me to solve this?
 
Thanks in advance!

--
Tica ;-)

[Daniel Albers]

Hi there,

Tica wrote:
 > When spamd run, it creates a .spamassassin dir in the /home/vpopmail
... and
 > doesn't read each user_pref files at the domain/user/.spamassassin
 >
 > Also... this error keep showing in system log: spamd: handle_user
unable to
 > find user: someuser@... (someuser@... used as
 > example).

vpopmail support is broken in 3.2. This patch should solve the described
problems:
<http://svn.apache.org/viewvc/spamassassin/trunk/spamd/spamd.raw?r1=648888&r2=673480&view=patch>

It is not part of any release yet, but scheduled for 3.3. Any prior
testing would be appreciated.

Cheers, Daniel

[Tica]

Hello Daniel,

 

Thanks for the prompt reply! :)

 

To what version of spamd is this patch??

 

Check this:

 

patching file spamd/spamd.raw
Hunk #1 FAILED at 2084.
1 out of 1 hunk FAILED -- saving rejects to file spamd/spamd.raw.rej
missing header for unified diff at line 23 of patch
can't find file to patch at input line 23
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|     }
--------------------------

 

I'm using SA 3.2.5

Stand by me to testing ! :)

 

Best regards!

 

 

2008/7/16 Daniel Albers <daniel@...>:

Hi there,

Tica wrote:

When spamd run, it creates a .spamassassin dir in the /home/vpopmail ... and
doesn't read each user_pref files at the domain/user/.spamassassin

Also... this error keep showing in system log: spamd: handle_user unable to
find user: someuser@... (someuser@... used as
example).

vpopmail support is broken in 3.2. This patch should solve the described problems:
<http://svn.apache.org/viewvc/spamassassin/trunk/spamd/spamd.raw?r1=648888&r2=673480&view=patch>

It is not part of any release yet, but scheduled for 3.3. Any prior testing would be appreciated.

Cheers, Daniel

--
Tica ;-)

[Daniel Albers]

Hi Tica,

Tica wrote:

> To what version of spamd is this patch??

it was based on current svn, but you should still be able to apply it to
spamd.raw of 3.2.5.

> Check this:
>
> patching file spamd/spamd.raw
> Hunk #1 FAILED at 2084.
> 1 out of 1 hunk FAILED -- saving rejects to file spamd/spamd.raw.rej
> missing header for unified diff at line 23 of patch
> can't find file to patch at input line 23
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |     }
> --------------------------

That looks weird.

I just gave it a try and n a vanilla 3.2.5 I can apply this like so:

Mail-SpamAssassin-3.2.5$ wget -qO -
"http://svn.apache.org/viewvc/spamassassin/\
trunk/spamd/spamd.raw?r1=648888&r2=673480&view=patch" |
  patch -p2
patching file spamd/spamd.raw
Hunk #1 succeeded at 2077 (offset -7 lines).
Hunk #2 succeeded at 2110 (offset -7 lines).
Mail-SpamAssassin-3.2.5$ patch --version
patch 2.5.9

Cheers, Daniel

[Tica]

Hi Daniel,

 

After a few tries (it was my mistake about the the patch error) I was able to patch spamd, but after a few testing, I needed to fall back to unpatched 3.2.5

 

The patched version was with two problems:

 

1. Spam scanning was not working...  I got the same error to a lot of incoming e-mails.

   SA:0(?/?)

2. a lot of error like this at spamd logs:

 

Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename containing newline at /usr/sbin/spamd line 2329, <GEN14> line 2.
Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful open on filename containing newline at /usr/lib/perl5/site_perl/5.8.8/Mail/SpamAssassin.pm line 1088, <GEN14> line 2.
Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename containing newline at /usr/lib/perl5/site_perl/5.8.8/Mail/SpamAssassin.pm line 1575, <GEN14> line 2.
Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 159, <GEN14> line 2.
Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 161, <GEN14> line 2.
Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 159, <GEN14> line 2.

Wed Jul 16 18:30:03 2008 [7992] info: spamd: connection from localhost.localdomain [127.0.0.1] at port 59846
Wed Jul 16 18:30:03 2008 [7992] warn: spamd: failed to resolve vpopmail user/alias 'user@...' using vuserinfo/valias at /usr/sbin/spamd line 2131, <GEN22> line 2.

 

Any clues?

 

 

Thanks indeed, once again! :)

 

--
Tica ;-)

[Daniel Albers]

Hi Tica,

Tica wrote:

> After a few tries (it was my mistake about the the patch error) I was able
> to patch spamd, but after a few testing, I needed to fall back to unpatched
> 3.2.5
>
> The patched version was with two problems:
>
> 1. Spam scanning was not working...  I got the same error to a lot of
> incoming e-mails.
>    SA:0(?/?)
>
> 2. a lot of error like this at spamd logs:
>
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename
> containing newline at /usr/sbin/spamd line 2329, <GEN14> line 2.
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful open on filename
> containing newline at /usr/lib/perl5/site_perl/5.8.8/Mail/SpamAssassin.pm
> line 1088, <GEN14> line 2.
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename
> containing newline at /usr/lib/perl5/site_perl/5.8.8/Mail/SpamAssassin.pm
> line 1575, <GEN14> line 2.
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename
> containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 159, <GEN14>
> line 2.
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename
> containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 161, <GEN14>
> line 2.
> Wed Jul 16 18:24:28 2008 [7992] warn: Unsuccessful stat on filename
> containing newline at /usr/lib/perl5/5.8.8/File/Path.pm line 159, <GEN14>
> line 2.
> Wed Jul 16 18:30:03 2008 [7992] info: spamd: connection from
> localhost.localdomain [127.0.0.1] at port 59846
> Wed Jul 16 18:30:03 2008 [7992] warn: spamd: failed to resolve vpopmail
> user/alias 'user@...' using vuserinfo/valias at /usr/sbin/spamd
> line 2131, <GEN22> line 2.

oh, my bad. Seems I focused too much on the vpopmail error handling and
forgot to take care of the most common use cases...

The attached patch solves this problem, as also mentioned in bug 5943 ¹.

Thanks a bunch for testing and reporting!

Cheers, Daniel


¹ <https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5943>

--- spamd/spamd.raw     (revision 677728)
+++ spamd/spamd.raw     (working copy)
@@ -2093,7 +2093,9 @@
       use re 'taint';
       my $vpopdir = $suiddir; # This should work with common vpopmail setups
       $userdir = `$vpopdir/bin/vuserinfo -d \Q$username_untainted\E`;
-      if ($? != 0) {
+      if ($? == 0) {
+        chomp($userdir);
+      } else {
         $userdir = handle_user_vpopmail($username_untainted,$vpopdir);
       }
     } else {