|
»
»
»
missing include
|
View:
New views
5 Messages
—
Rating Filter:
Alert me
|
 |
missing include
by Jaroslav Hajek-2
::
Rate this Message:
hello,
attached is a trivial fix for missing include statement in MatrixType.h -- RNDr. Jaroslav Hajek computing expert Aeronautical Research and Test Institute (VZLU) Prague, Czech Republic url: www.highegg.matfyz.cz [matrix-type-incl.diff] # HG changeset patch # User Jaroslav Hajek <highegg@...> # Date 1213947295 -7200 # Node ID e4aa0baf76724c5368a58c2d98f07ac3fd2431cf # Parent 0280a546622c42bf60fb8a2839297691996359dd add missing include in MatrixType.h diff --git a/liboctave/ChangeLog b/liboctave/ChangeLog --- a/liboctave/ChangeLog +++ b/liboctave/ChangeLog @@ -1,3 +1,7 @@ +2008-06-20 Jaroslav Hajek <highegg@...> + + * MatrixType.h: Add missing include statement. + 2008-06-13 Michael Goffioul <michael.goffioul@...> * lo-mappers.cc (arg): Remove ambiguity about atan2(float,float) usage. diff --git a/liboctave/MatrixType.h b/liboctave/MatrixType.h --- a/liboctave/MatrixType.h +++ b/liboctave/MatrixType.h @@ -23,6 +23,8 @@ #if !defined (octave_MatrixType_h) #define octave_MatrixType_h + +#include "oct-types.h" class Matrix; class ComplexMatrix; _______________________________________________ Bug-octave mailing list Bug-octave@... https://www.cae.wisc.edu/mailman/listinfo/bug-octave |
|
|
missing include
by John W. Eaton
::
Rate this Message:
On 20-Jun-2008, Jaroslav Hajek wrote:
| attached is a trivial fix for missing include statement in MatrixType.h I don't object to this change, but what problem does it solve? jwe _______________________________________________ Bug-octave mailing list Bug-octave@... https://www.cae.wisc.edu/mailman/listinfo/bug-octave |
|
|
Re: missing include
by Jaroslav Hajek-2
::
Rate this Message:
On Fri, Jun 20, 2008 at 10:07 PM, John W. Eaton <jwe@...> wrote:
> On 20-Jun-2008, Jaroslav Hajek wrote: > > | attached is a trivial fix for missing include statement in MatrixType.h > > I don't object to this change, but what problem does it solve? > > jwe > Um, sorry, I should have mentioned that. It was initiated by a bug report on OctaveForge mailing list (octave-dev) by David Rainey on Jun 19. Apparently he included MatrixType.h and got spurious errors due to octave_idx_type being undeclared in MatrixType.h. Seems like a missing dependency to me. Should I forward the message to Octave? For some reason I can't see it in the list archive. -- RNDr. Jaroslav Hajek computing expert Aeronautical Research and Test Institute (VZLU) Prague, Czech Republic url: www.highegg.matfyz.cz _______________________________________________ Bug-octave mailing list Bug-octave@... https://www.cae.wisc.edu/mailman/listinfo/bug-octave |
|
|
Re: missing include
by John W. Eaton
::
Rate this Message:
On 20-Jun-2008, Jaroslav Hajek wrote:
| On Fri, Jun 20, 2008 at 10:07 PM, John W. Eaton <jwe@...> wrote: | > On 20-Jun-2008, Jaroslav Hajek wrote: | > | > | attached is a trivial fix for missing include statement in MatrixType.h | > | > I don't object to this change, but what problem does it solve? | > | > jwe | > | Um, sorry, I should have mentioned that. It was initiated by a bug | report on OctaveForge mailing list (octave-dev) by David Rainey on Jun | 19. Apparently he included MatrixType.h and got spurious errors due to | octave_idx_type being undeclared in MatrixType.h. Seems like a missing | dependency to me. OK. I guess the Octave sources always happen to include the typedef before including MatrixType.h, but I don't see a problem with doing it in the MatrixType.h header itself. I applied the changeset. Thanks, jwe _______________________________________________ Bug-octave mailing list Bug-octave@... https://www.cae.wisc.edu/mailman/listinfo/bug-octave |
|
|
Re: missing include
by Michael Goffioul-2
::
Rate this Message:
On Fri, Jun 20, 2008 at 10:41 PM, John W. Eaton <jwe@...> wrote:
> OK. I guess the Octave sources always happen to include the typedef > before including MatrixType.h, but I don't see a problem with doing it > in the MatrixType.h header itself. I applied the changeset. The problem was triggered by a user-made oct-file that happened to include <octave/Matrix.h>. If you follow the inclusion pattern, you find that MatrixType.h is the first file to be parsed, but this requires the definition of octave_idx_type. Michael. _______________________________________________ Bug-octave mailing list Bug-octave@... https://www.cae.wisc.edu/mailman/listinfo/bug-octave |
| Free Forum Powered by Nabble | Forum Help |