kernel 2.6.25 and cloop module

[stirner]

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

[Néstor Amigo Cairo]

I have also the same problem. I'm going to try to post a fix, if I'm able to.

stirner wrote:

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

[stirner]

I have also the same problem. I'm going to try to post a fix, if I'm able to.

stirner wrote:

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

There are some interesting stuff in the 2.6.25 can't wait to see the patch ;-)

Thanks

Max
The kernel 2.6.25 intoduce

[Néstor Amigo Cairo]

I have taken a look. It seems that those functions are deprecated. I'm using this at work, so it's important for me to get it working. The perfect thing would be to include the module directly inside of the kernel, not having to compile it as a module (which is awful).
I'm making my own kernel driver based on some different stuff, if I get the time, I'm going to fix things up so a new function can be used instead of do_generic_file_read (which is used to read data from raw VFS or something like that).

Of course, calling upstream would be a nice idea, I'm doing so right now.

I'm telling you when I'm able to make the patch, posting it to this list. Until that moment, if it happens, I'm using version 2.6.24, I reccomend you do the same, it works flawlessly out-of-the-box ;-) If I can't do so, then the author itself surely will take the time to fix it, sooner or later.

Néstor Amigo Cairo wrote:

I have also the same problem. I'm going to try to post a fix, if I'm able to.

stirner wrote:

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

There are some interesting stuff in the 2.6.25 can't wait to see the patch ;-)

Thanks

Max
The kernel 2.6.25 intoduce

[Néstor Amigo Cairo]

Klaus Knopper has taken the time to fix it. Here's the fix (he sent it to my mailbox), I'm attaching it. Good luck!!compressed_loop.c

stirner wrote:

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

[stirner]

Klaus Knopper has taken the time to fix it. Here's the fix (he sent it to my mailbox), I'm attaching it. Good luck!!compressed_loop.c

stirner wrote:

Hi,

it seems that cloop 2.624 (...the latest...)   can't compile with kernel 2.6.25, here's a little output:

make modules -C /usr/src/linux M=/usr/src/cloop-2.624
make[1]: Entering directory `/usr/src/linux-2.6.25'
  CC [M]  /usr/src/cloop-2.624/compressed_loop.o
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_read_from_file':
/usr/src/cloop-2.624/compressed_loop.c:226: error: implicit declaration of function 'do_generic_file_read'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_handle_request':
/usr/src/cloop-2.624/compressed_loop.c:303: warning: unused variable 'bio'
/usr/src/cloop-2.624/compressed_loop.c: In function 'cloop_thread':
/usr/src/cloop-2.624/compressed_loop.c:437: error: implicit declaration of function 'end_that_request_first'
/usr/src/cloop-2.624/compressed_loop.c:438: error: implicit declaration of function 'end_that_request_last'
make[2]: *** [/usr/src/cloop-2.624/compressed_loop.o] Error 1
make[1]: *** [_module_/usr/src/cloop-2.624] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.25'

Any clue???

Thanks

Max

Thanks very much!!!

Klaus sent the patch to me too, it works and in this moment I'm remastering my minisystem knoppix based ;-))


Max

[Klaus Knopper-2]

On Fri, May 23, 2008 at 05:38:45AM -0700, Néstor Amigo Cairo wrote:
> Klaus Knopper has taken the time to fix it. Here's the fix (he sent it to my
> mailbox), I'm attaching it. Good luck!!
> http://www.nabble.com/file/p17424674/compressed_loop.c compressed_loop.c

Thanks for posting, I just have to add that this version has not been
thoroughly tested yet, so I can't promise that there are no unexpected
failures/bugs. Especially I'm not sure yet if it is suitable for really
large image, since I replaced all vmalloc() calls by __get_free_pages()
in order to save kernel vmalloc space (i.e. the "out of vmalloc memory"
error when setting preload to high numbers), primarily for testing. For
images with a block index larger than 2MB, this will for sure fail to
work!  So, please wait for an official release before using cloop 2.625
for a cloop-based distribution, or at least, please do a lot of
stress-testing before.

With kind regards
-Klaus Knopper


--
To UNSUBSCRIBE, email to debian-knoppix-request@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...