Hi everyone,
I'm trying to fix some invalid read of size errors and broken files in
file-sync. I already tried a few things but it seems to me that there
are more bugs in libopensync. So I have a few questions first:
Should a plugin (e.g. irmc-sync) report a null-terminated string? If
yes, should the reported size include the null or not?
In OpenSync 0.2x we used non zero-terminated strings, which was the
reason for bug #324 [1] and commit r1304 [2]. This commit was not
ported to OpenSync 0.3x. I'm not sure if it got lost or if OpenSync
0.3x changed the behaviour.
Another bug occurs when I synchronize irmc-sync to file-sync. The
vformat plugin reports a vcard with size == strlen(vcard) and file-sync
call conv_plain_to_file. Since commit r1515 [3] this function reduced
the stored size by one and the last line in all vcards, vevents etc.
get lost!
Now I'm not sure which size I should report. If vformat reports strlen+1
the errors and bugs above are fixed, but this would mean that we
changed the default behaviour.
I hope somebody can help here. Thanks.
Best regards
Christopher
[1]
http://www.opensync.org/ticket/324[2]
http://www.opensync.org/changeset/1304[3]
http://www.opensync.org/changeset/1515--
Christopher Stender, R&D Team Mobile Devices
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel
