htcapache support in defconfigman

[Michal Panczyk]

I would like to present the defconfigman support for HTCAPACHE.
As always I have some doubts, that I would like to share with
developers/ maintainers.

Section:
-machine.builtin
PXA_SSP=y - I have no idea what it's for...

PXA27x_VOLTAGE=y
PXA27x_VOLTAGE_MAX158xx=y - the same as above. But if it is needed
thic could be moved to hardware/crossport section, as the same
configuration lies in magician.conf

WATCHDOG ?= $1 - there was an issue in other hardware that it was
needed for wake up from suspend

SPI ?= $1
SPI_MASTER ?= $1
SPI_PXA2XX ?= $1 - this is my favorite one.... Unsure what is it used
for, left alone...

HTC_EGPIO ?= $1 - the same as above...

-machine.serial
SERIAL_PXA_COUNT=4 - unsure ....

-machine.lcd
FB_CFB_FILLRECT ?= $1
FB_CFB_COPYAREA ?= $1
FB_CFB_IMAGEBLIT ?= $1 - unsure what these 3 are for....


- machine.touchscreen :
  original defconfig used TOUCHSCREEN_ADC, which I have changed to
TOUCHSCREEN_ADC_DEBOUNCE. I hope this should not be a problem.

machine.wifi:
 no hardware specific driver in this section...


-- unclassified :
RTC_HCTOSYS
RTC_HCTOSYS_DEVICE="rtc0"

RTC_DRV_PCF8563
RTC_DRV_SA1100

Also - wiki says that device has USB host functionality but I have not
found one in defconfig (unless this is marked as USB_ARCH_HAS_OHCI).
There was no MTD support in original defconfig but this configuration
file adds one to configuration.

I just have to add that kernel does not build for htcapache with
original defconfig nor for the one generated by defconfigman - stops
at touchscreen-adc.h [1], so I was unable to verify my work.

--

Michal


[1]
  CC      arch/arm/mach-pxa/htcapache/htcapache.o
In file included from arch/arm/mach-pxa/htcapache/htcapache.c:18:
include/linux/touchscreen-adc.h:33: error: expected
specifier-qualifier-list before '<<' token
arch/arm/mach-pxa/htcapache/htcapache.c:195: error: unknown field
'max_sense' specified in initializer
arch/arm/mach-pxa/htcapache/htcapache.c:199: error: unknown field
'x_pin' specified in initializer
arch/arm/mach-pxa/htcapache/htcapache.c:199: warning: initialization
makes integer from pointer without a cast
arch/arm/mach-pxa/htcapache/htcapache.c:200: error: unknown field
'y_pin' specified in initializer
arch/arm/mach-pxa/htcapache/htcapache.c:200: warning: initialization
makes integer from pointer without a cast
arch/arm/mach-pxa/htcapache/htcapache.c:201: error: unknown field
'z1_pin' specified in initializer
arch/arm/mach-pxa/htcapache/htcapache.c:201: warning: initialization
makes integer from pointer without a cast
arch/arm/mach-pxa/htcapache/htcapache.c:202: error: unknown field
'z2_pin' specified in initializer
arch/arm/mach-pxa/htcapache/htcapache.c:202: warning: initialization
makes integer from pointer without a cast


_______________________________________________
Kernel-discuss mailing list
Kernel-discuss@...
https://handhelds.org/mailman/listinfo/kernel-discuss

[Paul Sokolovsky]

Hello Michal,

Wednesday, July 4, 2007, 5:53:27 PM, you wrote:

> I would like to present the defconfigman support for HTCAPACHE.
> As always I have some doubts, that I would like to share with
> developers/ maintainers.

> Section:
> -machine.builtin
> PXA_SSP=y - I have no idea what it's for...

  As was discussed previously, SSP is internal interface, so should go
to "external" feature which uses it, which is adc in this (and
with high probability any other ;-) ) case.

> PXA27x_VOLTAGE=y
> PXA27x_VOLTAGE_MAX158xx=y - the same as above. But if it is needed
> thic could be moved to hardware/crossport section, as the same
> configuration lies in magician.conf

  This is actually mostly CPU feature, all PXA27x has such ability,
which of course subject to actual hardware availability. 3 machines -
hx4700, magician and htcapache has such in form of MAX158X chip, so
you're right that it calls for driver.*.

> WATCHDOG ?= $1 - there was an issue in other hardware that it was
> needed for wake up from suspend

  Nope, not really a machine feature.

> SPI ?= $1
> SPI_MASTER ?= $1
> SPI_PXA2XX ?= $1 - this is my favorite one.... Unsure what is it used
> for, left alone...

  This kinda another interface for the same thing which PXA_SSP does.
Unless used on another SSP port (probability is low), not needed.

> HTC_EGPIO ?= $1 - the same as above...

  Well, this is peripheral controller, kind of asic3/samcop.

> -machine.serial
> SERIAL_PXA_COUNT=4 - unsure ....

  Other machines don't have it, so, should go.

> -machine.lcd
> FB_CFB_FILLRECT ?= $1
> FB_CFB_COPYAREA ?= $1
> FB_CFB_IMAGEBLIT ?= $1 - unsure what these 3 are for....

  Not machine feature.

> - machine.touchscreen :
>   original defconfig used TOUCHSCREEN_ADC, which I have changed to
> TOUCHSCREEN_ADC_DEBOUNCE. I hope this should not be a problem.


  Well, nope, apache uses ts-adc so far. But with the latest changes
from  Gerhard ts-adc-debounce indeed supersedes its functionality, so
we should switch to it.

> machine.wifi:
>  no hardware specific driver in this section...


> -- unclassified :
> RTC_HCTOSYS
> RTC_HCTOSYS_DEVICE="rtc0"

> RTC_DRV_PCF8563

Well-well, IIRC, apache indeed has standalone RTC chip, would need to
add machine.rtc .... So far put into into machine.builtin.

> RTC_DRV_SA1100

> Also - wiki says that device has USB host functionality but I have not
> found one in defconfig (unless this is marked as USB_ARCH_HAS_OHCI).
> There was no MTD support in original defconfig but this configuration
> file adds one to configuration.

  Well, if it has, it's on PXA, so would be the same settings as ...,
well, as on asus730 ;-).

> I just have to add that kernel does not build for htcapache with
> original defconfig nor for the one generated by defconfigman

  Please use http://handhelds.org/~pfalcon/busyb/buildlogs/ as the
reference for what's builds and what doesn't. If you have discrepancy
with it's state, feel free to check state of your tree, etc.

> - stops
> at touchscreen-adc.h [1], so I was unable to verify my work.

... In this case, it's very simple - you have CVS conflict in this
file.



Thanks!
--
Best regards,
 Paul                            mailto:pmiscml@...

_______________________________________________
Kernel-discuss mailing list
Kernel-discuss@...
https://handhelds.org/mailman/listinfo/kernel-discuss