first patch

View: New views
2 Messages — Rating Filter:   Alert me  

first patch

by Abderrahim Kitouni-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

I'm going to send my first patch to bugzilla [1], I'm having some problems with
valac which isn't mature enough, the project template I've written has some
hacks to work around valac bugs, It isn't ready to be used extensively but it's
okay IMHO.

I have some questions though :
  1. Should I include the files needed to generate the vapi in addition to the
vapi ? (they are in my hg repo [2])
  2. the template is based on the C version should I just copy the files and
modify them or should I use 'svn cp' to preserve history? trying the latter
copied files don't apear in 'svn diff'. Is there a way to make them show (svn
diff --git anyone?) or should I just use classic copy.


[1] http://bugzilla.gnome.org/show_bug.cgi?id=538021
[2] http://freehg.org/u/abderrahim/anjuta-vala-plugin/

Regards,
Abderrahim

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Anjuta-devel mailing list
Anjuta-devel@...
https://lists.sourceforge.net/lists/listinfo/anjuta-devel

Re: first patch

by Johannes Schmid-4 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi!

> I have some questions though :
>   1. Should I include the files needed to generate the vapi in addition to the
> vapi ? (they are in my hg repo [2])

Include all files needed to bootstrap it. If there are additional files
needed to generate the vapi, include them, because we might need to
change those later if the api changes.

>   2. the template is based on the C version should I just copy the files and
> modify them or should I use 'svn cp' to preserve history? trying the latter
> copied files don't apear in 'svn diff'. Is there a way to make them show (svn
> diff --git anyone?) or should I just use classic copy.

You don't need to preserve the history at this point.

Regards,
Johannes


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Anjuta-devel mailing list
Anjuta-devel@...
https://lists.sourceforge.net/lists/listinfo/anjuta-devel

signature.asc (196 bytes) Download Attachment
LightInTheBox - Buy quality products at wholesale price