file descriptor passing

[Marc Balmer-2]

for quite some time (more than a year) I have a local patch for
clamd which makes it accept filedescriptors being passed (the code
currently in clamd does _not_ work at all).

whom can I send that patch to, so that it might get included in
the code?

--
        SELECT services FROM companies WHERE name = 'micro systems'

marc balmer, micro systems, wiesendamm 2a, postfach, ch-4019 basel
internet www.msys.ch, phone [phone], fax [phone]
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Tomasz Kojm]

On Sat, 29 Mar 2008 10:34:44 +0100
Marc Balmer <marc@...> wrote:

> for quite some time (more than a year) I have a local patch for
> clamd which makes it accept filedescriptors being passed (the code
> currently in clamd does _not_ work at all).

Hi Mark,

due to portability issues and a general lack of interest in this feature (which
didn't work correctly anyway) from our users, the code has been dropped
a few months ago and currently we have no plans for re-including it.
However, feel free to open a bug in our bugzilla and attach your patch
so that we may consider it in the near future.

Thanks,

--
   oo    .....         Tomasz Kojm <tkojm@...>
  (\/)\.........         http://www.ClamAV.net/gpg/tkojm.gpg
     \..........._         0DCA5A08407D5288279DB43454822DC8985A444B
       //\   /\              Mon Mar 31 12:32:49 CEST 2008
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Marc Balmer-2]

Tomasz Kojm wrote:

> On Sat, 29 Mar 2008 10:34:44 +0100
> Marc Balmer <marc@...> wrote:
>
>> for quite some time (more than a year) I have a local patch for
>> clamd which makes it accept filedescriptors being passed (the code
>> currently in clamd does _not_ work at all).
>
> Hi Mark,
>
> due to portability issues and a general lack of interest in this feature (which
> didn't work correctly anyway) from our users, the code has been dropped
> a few months ago and currently we have no plans for re-including it.

Yes, the code in ClamAV was all wrong and could never work.  The code we
use in OpenBSD, however, works and is portable.  And it speeds up
scanning here a lot.

> However, feel free to open a bug in our bugzilla and attach your patch
> so that we may consider it in the near future.

Ok, I will do that.

--
        SELECT services FROM companies WHERE name = 'micro systems'

marc balmer, micro systems, wiesendamm 2a, postfach, ch-4019 basel
internet www.msys.ch, phone [phone], fax [phone]
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Scott Gifford]

Marc Balmer <marc@...> writes:

> Tomasz Kojm wrote:
>> On Sat, 29 Mar 2008 10:34:44 +0100
>> Marc Balmer <marc@...> wrote:
>>
>>> for quite some time (more than a year) I have a local patch for
>>> clamd which makes it accept filedescriptors being passed (the code
>>> currently in clamd does _not_ work at all).

[...]

>> feel free to open a bug in our bugzilla and attach your patch so
>> that we may consider it in the near future.
>
> Ok, I will do that.

Please post the bug number; the patch sounds extremely useful to me.

Thanks,

----Scott.
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Marc Balmer-2]

Scott Gifford wrote:

>> Tomasz Kojm wrote:
>>> On Sat, 29 Mar 2008 10:34:44 +0100
>>> Marc Balmer <marc@...> wrote:
>>>
>>>> for quite some time (more than a year) I have a local patch for
>>>> clamd which makes it accept filedescriptors being passed (the code
>>>> currently in clamd does _not_ work at all).
>
> [...]
>
>>> feel free to open a bug in our bugzilla and attach your patch so
>>> that we may consider it in the near future.
>> Ok, I will do that.
>
> Please post the bug number; the patch sounds extremely useful to me.

I just noticed that I need to register and login to propose this via
bugzilla.  The developers do not accept diffs via email, it seems.

I will mail a diff against 0.93 here once I adapted it, but first I need
to see what's going one with ClamAV and pthreads on OpenBSD...
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Török Edwin]

Marc Balmer wrote:
> I just noticed that I need to register and login to propose this via
> bugzilla.

Registration is automatic, and needed to avoid spam. Did you encounter
problems during registration?

>  The developers do not accept diffs via email, it seems.
>
> I will mail a diff against 0.93 here once I adapted it, but first I need
> to see what's going one with ClamAV and pthreads on OpenBSD...
>  

You'll need the patch from here:
https://wwws.clamav.net/bugzilla/show_bug.cgi?id=885

Best regards,
--Edwin
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Marc Balmer-2]

Török Edwin wrote:

>> I will mail a diff against 0.93 here once I adapted it, but first I need
>> to see what's going one with ClamAV and pthreads on OpenBSD...
>>  
>
> You'll need the patch from here:
> https://wwws.clamav.net/bugzilla/show_bug.cgi?id=885

I seriously doubt this is a bug in OpenBSD's threading.  It will of
course need some further investigation, but I think the reported
behaviour is a result of wrong use of threading functions.

It will take a bit longer till 0.93 is available on OpenBSD this
time, since I have to retrofit the file descriptor passing code,
scanning by filedescriptor passing (which I fixed and which works
like a charm if you do it correct).


--
        SELECT services FROM companies WHERE name = 'micro systems'

marc balmer, micro systems, wiesendamm 2a, postfach, ch-4019 basel
internet www.msys.ch, phone [phone], fax [phone]
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

[Marc Balmer-2]

Török Edwin wrote:
> Marc Balmer wrote:
>> I just noticed that I need to register and login to propose this via
>> bugzilla.
>
> Registration is automatic, and needed to avoid spam. Did you encounter
> problems during registration?

I don't want to.  I mail you a diff and if that is not enough, well,
then this code will not be made available.

It's easy to pass a filedescriptor, it just does not work the way
the ClamAV team coded it.  You can not just pass a stringified
fd number (printf("%d", fd) to the server and do an atoi() there.
The have to be passed in cmsgs over a local UNIX socket.  This is
portable by the way...

It speeds up scanning a lot in many situation and has some security
benefits as well.  To bad I need to add this as a local patch now.
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net