dolphin bug ( bug.kde.org isnt working for me )

hi

i have this bug for dolphin. you can see it in this screenshot :
http://img124.imageshack.us/img124/2909/dolphinbuguh8.jpg

in portuguese : Ontem -> Yesterday
Hoje -> Today

it should be sorted by date, desc. so "Hoje" should be before "Ontem"

thanks

On Friday, 30. May 2008 17:19:17 Iori Yagami wrote:
> hi
>
> i have this bug for dolphin. you can see it in this screenshot :
> http://img124.imageshack.us/img124/2909/dolphinbuguh8.jpg
>
> in portuguese : Ontem -> Yesterday
> Hoje -> Today
>
> it should be sorted by date, desc. so "Hoje" should be before "Ontem"

Thanks for the report, I could reproduce the issue and have added this to my
TODO-list. If you want to track when your issues get fixed, please use
bugs.kde.org to submit bugs :-)

Bye,
Peter

>
> thanks

On Saturday, 31. May 2008 16:19:12 Peter Penz wrote:

> On Friday, 30. May 2008 17:19:17 Iori Yagami wrote:
> > hi
> >
> > i have this bug for dolphin. you can see it in this screenshot :
> > http://img124.imageshack.us/img124/2909/dolphinbuguh8.jpg
> >
> > in portuguese : Ontem -> Yesterday
> > Hoje -> Today
> >
> > it should be sorted by date, desc. so "Hoje" should be before "Ontem"
>
> Thanks for the report, I could reproduce the issue and have added this to
> my TODO-list. If you want to track when your issues get fixed, please use
> bugs.kde.org to submit bugs :-)

Ah, I'm sorry - I did not see the headline that bugs.kde.org seems to be
down :-)

>
> Bye,
> Peter
>
> > thanks

[Rafael Fernández López-3]

Hi all,

Well, I couldn't reproduce this issue, but taking a look at the code I tried
to fix it, as well as another problem:

- On the code it is checked Year == Year, Month == Month. That is talking in
logic wrong. Take in count a day 1st of Foo can be in the same week as 28 of
Bar, for example, so it should show the week preference still.

Please, try out the patch at:
http://media.ereslibre.es/2008/06/kdebase.diff
and tell me if it fixes the problems.


Regards,
Rafael Fernández López.

[Rafael Fernández López-3]

Hi all,

The patch has been heavily updated. Now it takes in count lots of more things
than before. You can have an idea of how it works by looking at the
screenshots:

http://media.ereslibre.es/2008/06/dolphin1.png
http://media.ereslibre.es/2008/06/dolphin2.png

The patch is at
http://media.ereslibre.es/2008/06/kdebase.diff. If you apply it, don't forget
to do it with "patch -p1", since it is a "git diff".


Regards,
Rafael Fernández López.

Hi Rafael,

On Sunday, 1. June 2008 11:39:29 Rafael Fernández López wrote:

> Hi all,
>
> The patch has been heavily updated. Now it takes in count lots of more
> things than before. You can have an idea of how it works by looking at the
> screenshots:
>
> http://media.ereslibre.es/2008/06/dolphin1.png
> http://media.ereslibre.es/2008/06/dolphin2.png
>
> The patch is at
> http://media.ereslibre.es/2008/06/kdebase.diff. If you apply it, don't
> forget to do it with "patch -p1", since it is a "git diff".

Thanks a lot! I've just tested it and it works very well. I like that
the "weeks" headling is not restricted anymore to the current month :-)

There is just one minor detail that needs to be fixed: The patch turns around
the logic of ascending/descending sorting.

To reproduce:
- Use the icon mode + categorization turned on. Result: In the "Ascending"
mode the newest item ("Today") is on the top.
- Switch to the detail mode. Result: In the "Ascending" mode the newest item
("Today") is on the bottom.

May I fix your patch to revert this logic and commit it (the sort order in the
details mode is correct)?

Best regards,
Peter

>
>
> Regards,
> Rafael Fernández López.