acinclude.m4 leaves unexpanded macro

[Jason Stover-3]

Ben, your commit of acinclude.m4 left AS_ECHO unexpanded in configure
on my machine:

checking whether GSL needs -fgnu89-inline to link... ./configure: line 26587: syntax error near unexpected token `"$as_me: failed source file 1 of 2 was:"'
./configure: line 26587: `  AS_ECHO("$as_me: failed source file 1 of 2 was:") >&5'

The section of acinclude.m4 seems to be here:

+sed 's/^/| /' conftest1.$ac_ext >&AS_MESSAGE_LOG_FD
+AS_ECHO(["$as_me: failed source file 2 of 2 was:"]) >&AS_MESSAGE_LOG_FD
+sed 's/^/| /' conftest2.$ac_ext >&AS_MESSAGE_LOG_FD


$ aclocal --print-ac-dir
/usr/share/aclocal

$ grep AS_ECHO /usr/share/aclocal/*
$

I don't have it in gl/ either.

Where is AS_ECHO supposed to be defined?

-Jason


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[Ben Pfaff]

Jason Stover <jhs@...> writes:

> Where is AS_ECHO supposed to be defined?

Oops.  That macro is new in Autoconf 2.62.

I don't want Autoconf 2.62 to be a PSPP dependency yet, because
Debian unstable only has 2.61, so I'll fix it soon.
--
"Welcome to the Slippery Slope. Here is your handbasket.
 Say, can you work 70 hours this week?"
--Ron Mansolino


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[John Darrington]

On Sun, Jul 13, 2008 at 05:39:32PM -0400, Jason Stover wrote:
     Ben, your commit of acinclude.m4 left AS_ECHO unexpanded in configure
     on my machine:


I get the same symptoms.

J'

--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://pgp.mit.edu or any PGP keyserver for public key.




_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[Ben Pfaff]

Jason Stover <jhs@...> writes:
> Ben, your commit of acinclude.m4 left AS_ECHO unexpanded in configure
> on my machine:

John Darrington <john@...> writes:
> I get the same symptoms.

Apologies.  Would you two mind trying out the following patch?  I
believe that it should fix the problem.

commit b9bcafa33dd29ddf22de47e42c5e8cac4a75d0e9
Author: Ben Pfaff <blp@...>
Date:   Wed Jul 16 10:18:35 2008 -0700

    Make PSPP_LINK2_IFELSE macro work with Autoconf earlier than 2.62.

diff --git a/acinclude.m4 b/acinclude.m4
index 10ea269..11154ee 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -223,7 +223,7 @@ mv conftest.$ac_ext conftest1.$ac_ext
 m4_ifvaln([$2], [AC_LANG_CONFTEST([$2])])dnl
 mv conftest.$ac_ext conftest2.$ac_ext
 rm -f conftest1.$ac_objext conftest2.$ac_objext conftest$ac_exeext
-pspp_link2='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest1.$ac_ext conftest2.$ac_ext $LIBS >&AS_MESSAGE_LOG_FD'
+pspp_link2='$CC -o conftest$ac_exeext $CFLAGS $CPPFLAGS $LDFLAGS conftest1.$ac_ext conftest2.$ac_ext $LIBS >&5'
 AS_IF([_AC_DO_STDERR($pspp_link2) && {
  test -z "$ac_[]_AC_LANG_ABBREV[]_werror_flag" ||
  test ! -s conftest.err
@@ -232,10 +232,10 @@ AS_IF([_AC_DO_STDERR($pspp_link2) && {
  AS_TEST_X([conftest$ac_exeext])
        }],
       [$3],
-      [AS_ECHO(["$as_me: failed source file 1 of 2 was:"]) >&AS_MESSAGE_LOG_FD
-sed 's/^/| /' conftest1.$ac_ext >&AS_MESSAGE_LOG_FD
-AS_ECHO(["$as_me: failed source file 2 of 2 was:"]) >&AS_MESSAGE_LOG_FD
-sed 's/^/| /' conftest2.$ac_ext >&AS_MESSAGE_LOG_FD
+      [echo "$as_me: failed source file 1 of 2 was:" >&5
+sed 's/^/| /' conftest1.$ac_ext >&5
+echo "$as_me: failed source file 2 of 2 was:" >&5
+sed 's/^/| /' conftest2.$ac_ext >&5
  $4])
 dnl Delete also the IPA/IPO (Inter Procedural Analysis/Optimization)
 dnl information created by the PGI compiler (conftest_ipa8_conftest.oo),

--
"Unix... is not so much a product
 as it is a painstakingly compiled oral history
 of the hacker subculture."
--Neal Stephenson


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[Jason Stover-3]

On Wed, Jul 16, 2008 at 10:19:23AM -0700, Ben Pfaff wrote:
> Jason Stover <jhs@...> writes:
> > Ben, your commit of acinclude.m4 left AS_ECHO unexpanded in configure
> > on my machine:
>
> John Darrington <john@...> writes:
> > I get the same symptoms.
>
> Apologies.  Would you two mind trying out the following patch?  I
> believe that it should fix the problem.

That worked for me.

-Jason


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev

[Ben Pfaff]

Jason Stover <jhs@...> writes:

> On Wed, Jul 16, 2008 at 10:19:23AM -0700, Ben Pfaff wrote:
>> Jason Stover <jhs@...> writes:
>> > Ben, your commit of acinclude.m4 left AS_ECHO unexpanded in configure
>> > on my machine:
>>
>> John Darrington <john@...> writes:
>> > I get the same symptoms.
>>
>> Apologies.  Would you two mind trying out the following patch?  I
>> believe that it should fix the problem.
>
> That worked for me.

Great, thanks.  I pushed the fixed version.
--
Ben Pfaff
http://benpfaff.org


_______________________________________________
pspp-dev mailing list
pspp-dev@...
http://lists.gnu.org/mailman/listinfo/pspp-dev