a couple bug fixes for latest version of SoX

[Michael Harville]

Hi,

I downloaded the latest CVS snapshot of SoX version 14.0.1 to fix
some build issues with ffmpeg on Linux. (See discussion thread
http://thread.gmane.org/gmane.comp.audio.sox/1546.)
I was able to run

  autoreconf -i
  configure --with-ffmpeg=yes

successfully, but the build was broken. Specifically, I got lots
of undefined symbols when it tried to build
libsox_fmt_ffmpeg.la. For example, some build output:

/bin/sh ../libtool --silent --tag=CC  --silent --mode=link
gcc -Wconversion -g -O2 -D_FORTIFY_SOURCE=2 -Wall -W
-Wmissing-prototypes -Wstrict-prototypes -pedantic -lltdl -Wl,
-z,defs -o libsox_fmt_ffmpeg.la -rpath /usr/local/lib/sox
ffmpeg.lo libsox.la -lavformat -lavcodec -lavutil  -lm
/usr/local/lib/libavformat.a(mov.o): In function `mov_read_cmov':
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/mov.c:1190:
undefined reference to `uncompress'
/usr/local/lib/libavformat.a(libogg.o): In function `ogg_write_trailer':
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/libogg.c:143:
undefined reference to `ogg_stream_flush'
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/libogg.c:149:
undefined reference to `ogg_stream_clear'
/usr/local/lib/libavformat.a(libogg.o): In function `ogg_write_packet':
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/libogg.c:126:
undefined reference to `ogg_stream_packetin'
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/libogg.c:128:
undefined reference to `ogg_stream_pageout'
/home/mike/Projects/ctv/vendor/codec/ffmpeg/libavformat/libogg.c:111:
undefined reference to `ogg_stream_flush'
.
.
.

My ffmpeg build was configured to use all sorts of other
codecs (e.g. ogg, vorbis, x264, etc.) and none of these were
being included on the link line above. To fix the problem,
I reconfigured sox as follows, adding one extra step
at the start:

  autoreconf -i
  export FFMPEG_LIBS="-lz -logg -lx264 -lfaac -lfaad -lmp3lame
                      -lmp4v2 -lvorbis -lvorbisenc -lvorbisfile"
  configure --with-ffmpeg=yes
  make

That works! Please fix the configure/Makefiles, though, in Sox if
you can, to pull in the necessary libs. I do not know if that
is possible...

When I moved the latest package back to my Mac and tried these
same steps, I got a compile error:

gcc -DHAVE_CONFIG_H -I.  -DLADSPA_PATH="\"/usr/local/lib/ladspa\""
-DPKGLIBDIR="\"/usr/local/lib/sox\""  -Wconversion  -g -O2 -D_FORTIFY_SOURCE=2
-Wall -W -Wmissing-prototypes -Wstrict-prototypes -pedantic -MT sox.o -MD -MP
-MF .deps/sox.Tpo -c -o sox.o sox.c
In file included from sox.c:25:
sox_i.h:107: error: ‘_FILE_OFFSET_BITS’ undeclared here (not in a function)

To fix, I commented out the assert statement in sox_i.h that is causing the
problem. If you could please propagate (a better fix) to the original source,
that would be great.

Thanks!
Mike




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[robs-5]

--- Michael Harville <mlharville@...> wrote:

> When I moved the latest package back to my Mac and tried these
> same steps, I got a compile error:
>
> gcc -DHAVE_CONFIG_H -I.  -DLADSPA_PATH="\"/usr/local/lib/ladspa\""
> -DPKGLIBDIR="\"/usr/local/lib/sox\""  -Wconversion  -g -O2
> -D_FORTIFY_SOURCE=2
> -Wall -W -Wmissing-prototypes -Wstrict-prototypes -pedantic -MT sox.o -MD -MP
>
> -MF .deps/sox.Tpo -c -o sox.o sox.c
> In file included from sox.c:25:
> sox_i.h:107: error: ‘_FILE_OFFSET_BITS’ undeclared here (not in a
> function)

Thanks for pointing this out; fix now in CVS.


      __________________________________________________________
Sent from Yahoo! Mail.
The World's Favourite Email http://uk.docs.yahoo.com/nowyoucan.html

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[Chris Bagwell]

Michael Harville wrote:.

> My ffmpeg build was configured to use all sorts of other
> codecs (e.g. ogg, vorbis, x264, etc.) and none of these were
> being included on the link line above. To fix the problem,
> I reconfigured sox as follows, adding one extra step
> at the start:
>
>   autoreconf -i
>   export FFMPEG_LIBS="-lz -logg -lx264 -lfaac -lfaad -lmp3lame
>                       -lmp4v2 -lvorbis -lvorbisenc -lvorbisfile"
>   configure --with-ffmpeg=yes
>   make
>
> That works! Please fix the configure/Makefiles, though, in Sox if
> you can, to pull in the necessary libs. I do not know if that
> is possible...
>
>  

I will be working on this next.  Basically, I need to move to querying
pkg-config to find out what libraries are required for FFMPEG_LIBS since
its unpredictable what features the user will have linked into ffmpeg.

I haven't compiled on OS X yet... do you have pkg-config available on
that platform?

Also, slightly related was a bug tracker just submitted.  Linking in the
static version of ffmpeg has issues.  There is duplication between its
GSM symbols and libsox's GSM symbols.  Not sure how I'll detect and fix
that off hand.

Chris

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[Murray Hooper]

I have been using Sox for many years on RedHat 32 bit, but as the adage goes
"if it ain't broke, don't fix it" and now I'm being pushed onto a RH EL5
64bit machine.  Are there any known issues with Sox 14.0.1 on this platform?

thanks



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[Chris Bagwell]

On Wed, Mar 19, 2008 at 04:41:04PM -0400, Murray Hooper wrote:
> I have been using Sox for many years on RedHat 32 bit, but as the adage goes
> "if it ain't broke, don't fix it" and now I'm being pushed onto a RH EL5
> 64bit machine.  Are there any known issues with Sox 14.0.1 on this platform?
>
> thanks

Is the 64-bit box going to be an intel/amd machine?  If so then 14.0.1
is probably the most well tested version on those machines to date.

I know of nothing unique to RH EL5 as long as you stick with stock
RPM kernels.

I saw some bugfixes submitted to CVS post-14.0.1 with a comment
about issues on 64-bit big-endian machines.  Not sure what
the bugfixes were and if they exist in 14.0.1 or not.

Chris

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[Pascal Giard]

As a amd64 user, there are no issues that i'm aware of.
Note that there have been reports of issues with some distros shipping
old versions of glibc with recent kernels [1].

I can't tell if that applies to RHEL5 tho.

-Pascal
[1] http://thread.gmane.org/gmane.comp.audio.sox/1575/focus=1576

On Wed, Mar 19, 2008 at 4:41 PM, Murray Hooper <m-hooper@...> wrote:

> I have been using Sox for many years on RedHat 32 bit, but as the adage goes
>  "if it ain't broke, don't fix it" and now I'm being pushed onto a RH EL5
>  64bit machine.  Are there any known issues with Sox 14.0.1 on this platform?
>
>  thanks
>
>
>
>  -------------------------------------------------------------------------
>  This SF.net email is sponsored by: Microsoft
>  Defy all challenges. Microsoft(R) Visual Studio 2008.
>  http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
>  _______________________________________________
>  Sox-users mailing list
>  Sox-users@...
>  https://lists.sourceforge.net/lists/listinfo/sox-users
>

--
Homepage (http://organact.mine.nu)
Debian GNU/Linux (http://www.debian.org)
LACIME: École de technologie supérieure (http://lacime.etsmtl.ca)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users

[Murray Hooper]

-----Original Message-----
From: sox-users-bounces@...
[mailto:sox-users-bounces@...] On Behalf Of Chris Bagwell
Sent: Wednesday, March 19, 2008 4:49 PM
To: sox-users@...
Subject: Re: [SoX-users] RH Enterprise Linux 64. Issues?

On Wed, Mar 19, 2008 at 04:41:04PM -0400, Murray Hooper wrote:
> I have been using Sox for many years on RedHat 32 bit, but as the adage
goes
> "if it ain't broke, don't fix it" and now I'm being pushed onto a RH EL5
> 64bit machine.  Are there any known issues with Sox 14.0.1 on this
platform?
>
> thanks

Is the 64-bit box going to be an intel/amd machine?  If so then 14.0.1
is probably the most well tested version on those machines to date.

I know of nothing unique to RH EL5 as long as you stick with stock
RPM kernels.

I saw some bugfixes submitted to CVS post-14.0.1 with a comment
about issues on 64-bit big-endian machines.  Not sure what
the bugfixes were and if they exist in 14.0.1 or not.

Chris

Intel Xeon Quad-Core.  I will grab the latest from CVS and report any issues
I find.

murray
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Sox-users mailing list
Sox-users@...
https://lists.sourceforge.net/lists/listinfo/sox-users