Nabble - Tomcat - Dev

svn commit: r655992 - in /tomcat/trunk/bin: catalina.bat catalina.sh

2008-05-13T13:13:22Z

Author: markt
Date: Tue May 13 13:13:22 2008
New Revision: 655992

URL: http://svn.apache.org/viewvc?rev=655992&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44988
Use Java 5 syntax to start debugger.
Patch provided by Cédrik Lime.

Modified:
tomcat/trunk/bin/catalina.bat
tomcat/trunk/bin/catalina.sh

Modified: tomcat/trunk/bin/catalina.bat
URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=655992&r1=655991&r2=655992&view=diff
==============================================================================
--- tomcat/trunk/bin/catalina.bat (original)
+++ tomcat/trunk/bin/catalina.bat Tue May 13 13:13:22 2008
@@ -149,7 +149,7 @@
set JPDA_SUSPEND=n
:gotJpdaSuspend
if not "%JPDA_OPTS%" == "" goto gotJpdaOpts
-set JPDA_OPTS=-Xdebug -Xrunjdwp:transport=%JPDA_TRANSPORT%,address=%JPDA_ADDRESS%,server=y,suspend=%JPDA_SUSPEND%
+set JPDA_OPTS=-agentlib:jdwp=transport=%JPDA_TRANSPORT%,address=%JPDA_ADDRESS%,server=y,suspend=%JPDA_SUSPEND%
:gotJpdaOpts
shift
:noJpda

Modified: tomcat/trunk/bin/catalina.sh
URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=655992&r1=655991&r2=655992&view=diff
==============================================================================
--- tomcat/trunk/bin/catalina.sh (original)
+++ tomcat/trunk/bin/catalina.sh Tue May 13 13:13:22 2008
@@ -210,7 +210,7 @@
JPDA_SUSPEND="n"
fi
if [ -z "$JPDA_OPTS" ]; then
- JPDA_OPTS="-Xdebug -Xrunjdwp:transport=$JPDA_TRANSPORT,address=$JPDA_ADDRESS,server=y,suspend=$JPDA_SUSPEND"
+ JPDA_OPTS="-agentlib:jdwp=transport=$JPDA_TRANSPORT,address=$JPDA_ADDRESS,server=y,suspend=$JPDA_SUSPEND"
fi
CATALINA_OPTS="$CATALINA_OPTS $JPDA_OPTS"
shift

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "DocumentInOtherLanguages" by Jun Lu

2008-05-13T12:48:33Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by Jun Lu:
http://wiki.apache.org/tomcat/DocumentInOtherLanguages

------------------------------------------------------------------------------

Here is a list of Tomcat documents in other languages.

- * [http://tomcat.jaxmao.org/appdev/index.html Tomcat 5.5 ä¸æåºç¨æå] Chinese translation of Tomcat 5.5 document
+ * [http://tomcat.jaxmao.org/ Tomcat 5.5 ä¸æåºç¨æå] Chinese translation of Tomcat 5.5 document

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "DocumentInOtherLanguages" by Jun Lu

2008-05-13T12:44:20Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by Jun Lu:
http://wiki.apache.org/tomcat/DocumentInOtherLanguages

------------------------------------------------------------------------------
+ == Document in Other Languages ==
+
Here is a list of Tomcat documents in other languages.

* [http://tomcat.jaxmao.org/appdev/index.html Tomcat 5.5 ä¸æåºç¨æå] Chinese translation of Tomcat 5.5 document

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "DocumentInOtherLanguages" by Jun Lu

2008-05-13T12:37:49Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by Jun Lu:
http://wiki.apache.org/tomcat/DocumentInOtherLanguages

New page:
Here is a list of Tomcat documents in other languages.

* [http://tomcat.jaxmao.org/appdev/index.html Tomcat 5.5 ä¸æåºç¨æå] Chinese translation of Tomcat 5.5 document

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "FrontPage" by Jun Lu

2008-05-13T12:30:58Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by Jun Lu:
http://wiki.apache.org/tomcat/FrontPage

------------------------------------------------------------------------------
* '''["UsingPhp"]''' - Using PHP with Tomcat 4 or later.
* '''["WhatIsComet"]''' - What is the Tomcat Comet API.
* '''["6xFeatures"]''' - Feature list for 6.x release.
+ * '''["DocumentInOtherLanguages"]''' - List of Tomcat documents in other languages.

The old Tomcat Wiki content can be found at TomcatProjectPages.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "GettingStarted" by Jun Lu

2008-05-13T12:09:25Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by Jun Lu:
http://wiki.apache.org/tomcat/GettingStarted

------------------------------------------------------------------------------

== Getting your first webapp up and running ==
* [http://tomcat.apache.org/tomcat-5.5-doc/appdev/index.html Introduction in the Application Developer Guide]
+ * [http://tomcat.jaxmao.org/appdev/index.html åºç¨å¼åäººåæå] Chinese translation of the Application Developer Guide

== Useful links ==

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: Manage connection

2008-05-13T10:49:18Z

Liang Xiao Zhu wrote:

> Hi everyone!
>
> I am wondering, how can i manage connection? What I want to do is
> simplely filter connections, such as when I have 50 request I want the
> follow connections will be refused. I am using a NIO protocol for to do
> that, in fact, I am looking at a Http11NioProcessor.java and
> Http11NioProtocol.java, and I can capture the request, but I dont know
> how I can refuse the request. I mean, how I can build a response when
> the user with request 51 will be refused.
>
> Thanks in advance!!!

This is a question for the users list, not the dev list.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Re: URL decoding of plus (aka space) isn't done

2008-05-13T08:57:40Z

To answer my own question:

I looked at the RFC (http://www.ietf.org/rfc/rfc2396.txt) and it appears that '+' is only reserved for query strings. The use of java.net.URLEncoder for path-portions of a URL (or even an entire URL) is incorrect.

-Doug

Doug Donohoe wrote:

I'm tracking down a bug in Wicket that appears in Tomcat (also Jetty). The issue is this:

I'm submitting a URL with spaces and pluses in it. It is URL encoded (using java.net.URLEncoder) as follows:

http://localhost:8080/bugs/home/message/message+with+spaces+and%2Bsome%2Bpluses/

On both Tomcat and Jetty, the request.getServletPath() call returns this:

/home/message/message+with+spaces+and+some+plusses=bug/

Only the %2B (+) encodings are URL-decoded. The + (space) encodings are left as-is. As you can see, through this process some information is lost (what the original pluses were).

This happens in Tomcat in CoyoteAdapter:393:

req.getURLDecoder().convert(decodedURI, false);

The 'false' is for the "query" param, which when false, skips converting of +

Jetty's code is similar - it just ignores '+' altogether.

My question is this. If it is correct to URL encode spaces with +, which doesn't Tomcat (or Jetty) decode them? Or is the java.net.URLEncoder doing this incorrectly? Are + only allowed in the query string portion? There seems to be an impedance mismatch between what a client will allow in a URL versus what the server is expecting. Anyone have any insight into this?

Thanks,

-Doug

URL decoding of plus (aka space) isn't done

2008-05-13T08:41:23Z

I'm tracking down a bug in Wicket that appears in Tomcat (also Jetty). The issue is this:

I'm submitting a URL with spaces and pluses in it. It is URL encoded (using java.net.URLEncoder) as follows:

http://localhost:8080/bugs/home/message/message+with+spaces+and%2Bsome%2Bpluses/

On both Tomcat and Jetty, the request.getServletPath() call returns this:

/home/message/message+with+spaces+and+some+plusses=bug/

Only the %2B (+) encodings are URL-decoded. The + (space) encodings are left as-is. As you can see, through this process some information is lost (what the original pluses were).

This happens in Tomcat in CoyoteAdapter:393:

req.getURLDecoder().convert(decodedURI, false);

The 'false' is for the "query" param, which when false, skips converting of +

Jetty's code is similar - it just ignores '+' altogether.

My question is this. If it is correct to URL encode spaces with +, which doesn't Tomcat (or Jetty) decode them? Or is the java.net.URLEncoder doing this incorrectly? Are + only allowed in the query string portion? There seems to be an impedance mismatch between what a client will allow in a URL versus what the server is expecting. Anyone have any insight into this?

Thanks,

-Doug

DO NOT REPLY [Bug 44989] using NIO connector with compression consumes all CPU

2008-05-13T08:03:51Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44989

Filip Hanik <fhanik@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO

--- Comment #2 from Filip Hanik <fhanik@...> 2008-05-13 08:03:51 PST ---
Hi there, many thanks for the report.
I would like to ask you for two things

1. Test the latest 6.0.x trunk, there has been changes in the exact code you
are refering to

fairly simple to build
(build with JDK 1.5)

svn co http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk
cd trunk
ant download
ant

output ends up in output/build

and if that doesn't change your scenario, make sure we are not running into a
JDK/NIO bug on linux, so test with the latest 1.6 JVM

best
Filip

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44989] using NIO connector with compression consumes all CPU

2008-05-13T07:39:10Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44989

--- Comment #1 from Clóvis Wichoski <clovis.wichoski@...> 2008-05-13 07:39:10 PST ---
Created an attachment (id=21958)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21958)
JConsole TopThreads

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44989] New: using NIO connector with compression consumes all CPU

2008-05-13T07:38:24Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44989

Summary: using NIO connector with compression consumes all CPU
Product: Tomcat 6
Version: 6.0.16
Platform: PC
OS/Version: Linux
Status: NEW
Severity: critical
Priority: P1
Component: Connectors
AssignedTo: tomcat-dev@...
ReportedBy: clovis.wichoski@...

Created an attachment (id=21957)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=21957)
JConsole overview

Hi, i migrated from version 6.0.14 to version 6.0.16, and configured tomcat to
use NIO connector and compression on, with that i'm getting a thread name
'http-exec-80-2' that consumes 49-50% of CPU, and the thread
'http-80-ClientPoller' that consumes 46-48% of CPU, with this i have a jvm that
consumes 100% o my CPU.

uname -a output:
Linux 2.6.23.1-10.fc7 #1 SMP Fri Oct 19 15:39:08 EDT 2007 i686 i686 i386
GNU/Linux

java -version output:
java version "1.5.0_15"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_15-b04)
Java HotSpot(TM) Server VM (build 1.5.0_15-b04, mixed mode)

http-exec-80-2 stack:
org.apache.coyote.http11.InternalNioOutputBuffer$SocketOutputBuffer.doWrite(InternalNioOutputBuffer.java:806)
org.apache.coyote.http11.filters.ChunkedOutputFilter.doWrite(ChunkedOutputFilter.java:126)
org.apache.coyote.http11.filters.GzipOutputFilter$FakeOutputStream.write(GzipOutputFilter.java:164)
java.util.zip.GZIPOutputStream.finish(GZIPOutputStream.java:95)
org.apache.coyote.http11.filters.GzipOutputFilter.end(GzipOutputFilter.java:122)
org.apache.coyote.http11.InternalNioOutputBuffer.endRequest(InternalNioOutputBuffer.java:390)
org.apache.coyote.http11.Http11NioProcessor.action(Http11NioProcessor.java:1079)
org.apache.coyote.Response.action(Response.java:183)
org.apache.coyote.Response.finish(Response.java:305)
org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:276)
org.apache.catalina.connector.Response.finishResponse(Response.java:492)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:310)
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:879)
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:719)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2080)
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
java.lang.Thread.run(Thread.java:595)

sometimes the stack of http-exec-80-2 is just changing from this to above:
org.apache.coyote.http11.InternalNioOutputBuffer.addToBB(InternalNioOutputBuffer.java:620)
org.apache.coyote.http11.InternalNioOutputBuffer.access$000(InternalNioOutputBuffer.java:46)
org.apache.coyote.http11.InternalNioOutputBuffer$SocketOutputBuffer.doWrite(InternalNioOutputBuffer.java:803)
org.apache.coyote.http11.filters.ChunkedOutputFilter.doWrite(ChunkedOutputFilter.java:126)
org.apache.coyote.http11.filters.GzipOutputFilter$FakeOutputStream.write(GzipOutputFilter.java:164)
java.util.zip.GZIPOutputStream.finish(GZIPOutputStream.java:95)
org.apache.coyote.http11.filters.GzipOutputFilter.end(GzipOutputFilter.java:122)
org.apache.coyote.http11.InternalNioOutputBuffer.endRequest(InternalNioOutputBuffer.java:390)
org.apache.coyote.http11.Http11NioProcessor.action(Http11NioProcessor.java:1079)
org.apache.coyote.Response.action(Response.java:183)
org.apache.coyote.Response.finish(Response.java:305)
org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:276)
org.apache.catalina.connector.Response.finishResponse(Response.java:492)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:310)
org.apache.coyote.http11.Http11NioProcessor.process(Http11NioProcessor.java:879)
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:719)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:2080)
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
java.lang.Thread.run(Thread.java:595)

http-80-ClientPoller stack:
sun.nio.ch.PollArrayWrapper.poll0(Native Method)
sun.nio.ch.PollArrayWrapper.poll(PollArrayWrapper.java:100)
sun.nio.ch.PollSelectorImpl.doSelect(PollSelectorImpl.java:56)
sun.nio.ch.SelectorImpl.lockAndDoSelect(SelectorImpl.java:69)
sun.nio.ch.SelectorImpl.select(SelectorImpl.java:80)
org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1473)
java.lang.Thread.run(Thread.java:595)

attached are the screenshots of JConsole from where you can see the graphs...

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Manage connection

2008-05-13T07:33:27Z

Hi everyone!

I am wondering, how can i manage connection? What I want to do is
simplely filter connections, such as when I have 50 request I want the
follow connections will be refused. I am using a NIO protocol for to do
that, in fact, I am looking at a Http11NioProcessor.java and
Http11NioProtocol.java, and I can capture the request, but I dont know
how I can refuse the request. I mean, how I can build a response when
the user with request 51 will be refused.

Thanks in advance!!!

Regards

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44988] New: JPDA_OPTS in catalina.sh / catalina. bat is using old JDWP semantics

2008-05-13T06:10:34Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44988

Summary: JPDA_OPTS in catalina.sh / catalina.bat is using old
JDWP semantics
Product: Tomcat 6
Version: 6.0.16
Platform: All
OS/Version: All
Status: NEW
Keywords: JDK1.5
Severity: minor
Priority: P4
Component: Native:Integration
AssignedTo: tomcat-dev@...
ReportedBy: cedrik.lime@...

Since Java 5, the recommended option to start a JVM in debug mode has changed
from
-Xdebug -Xrunjdwp:...
to
-agentlib:jdwp=...
as described in
http://java.sun.com/j2se/1.5.0/docs/guide/jpda/conninv.html#Invocation

Since Tomcat 6 requires Java 5, this change should be propagated in catalina.sh
(line 212) / catalina.bat (line 152):
change "JPDA_OPTS=-Xdebug -Xrunjdwp:" to "JPDA_OPTS=-agentlib:jdwp="

Note that this change should not be back-ported to Tomcat 5.x, since this
version runs with Java 1.4.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44986] New: JSP compilation exception with pageEncoding=" utf-8" and file with byte order marks

2008-05-13T04:42:12Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44986

Summary: JSP compilation exception with pageEncoding="utf-8" and
file with byte order marks
Product: Tomcat 6
Version: unspecified
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: tomcat-dev@...
ReportedBy: ralf.zimmermann@...

JSP-File has byte order marks. If the attribute is set to "UTF-8" (upper case)
or the file has no byte order marks, the compilation workes fine.

{code}
12:32:16,946 ERROR [[jsp]] Servlet.service() for servlet jsp threw exception
org.apache.jasper.JasperException: /dialog.jsp(2,0) Page-encoding specified in
XML prolog (UTF-8) is different from that specified in page directive (utf-8)
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:40)
at
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:407)
at
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:236)
at
org.apache.jasper.compiler.Validator$DirectiveVisitor.comparePageEncodings(Validator.java:362)
at
org.apache.jasper.compiler.Validator$DirectiveVisitor.visit(Validator.java:197)
at org.apache.jasper.compiler.Node$PageDirective.accept(Node.java:590)
at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2338)
at org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2388)
at org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2394)
at org.apache.jasper.compiler.Node$Root.accept(Node.java:489)
at org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2338)
at org.apache.jasper.compiler.Validator.validate(Validator.java:1700)
at org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:178)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:306)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:286)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:273)
at
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:566)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:316)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:336)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:654)
at
org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:445)
at
org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:379)
at
org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:292)
at de.cit.jsp.control.DispatchServlet.forward(DispatchServlet.java:286)
at de.cit.jsp.control.DispatchServlet.doGet(DispatchServlet.java:272)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
de.cit.util.javax.servlet.ValidationFilter.doFilter(ValidationFilter.java:108)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
de.cit.util.javax.servlet.jsp.XHtmlContentTypeFilter.doFilter(XHtmlContentTypeFilter.java:36)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:230)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
at
org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:179)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:432)
at
org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:84)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at
org.jboss.web.tomcat.service.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:157)
at org.apache.catalina.authenticator.SingleSignOn.invoke(SingleSignOn.java:420)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:262)
at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:437)
at
org.apache.coyote.ajp.AjpProtocol$AjpConnectionHandler.process(AjpProtocol.java:366)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:446)
at java.lang.Thread.run(Thread.java:619)
{code}

Case insensitive camparison in
org.apache.jasper.compiler.Validator.comparePageEncodings(...) seems to fix the
problem:
{code}
/*
* Compares page encodings specified in various places, and throws
* exception in case of page encoding mismatch.
*
* @param pageDirEnc The value of the pageEncoding attribute of the
page
* directive @param pageDir The page directive node
*
* @throws JasperException in case of page encoding mismatch
*/
private String comparePageEncodings(String pageDirEnc,
Node.PageDirective pageDir) throws JasperException {

Node.Root root = pageDir.getRoot();
String configEnc = root.getJspConfigPageEncoding();

/*
* Compare the 'pageEncoding' attribute of the page directive with
* the encoding specified in the JSP config element whose URL
* pattern matches this page. Treat "UTF-16", "UTF-16BE", and
* "UTF-16LE" as identical.
*/
if (configEnc != null) {
if (!pageDirEnc.equalsIgnoreCase(configEnc)
&& (!pageDirEnc.toUpperCase().startsWith("UTF-16") ||
!configEnc
.toUpperCase().startsWith("UTF-16"))) {
err.jspError(pageDir,
"jsp.error.config_pagedir_encoding_mismatch",
configEnc, pageDirEnc);
} else {
return configEnc;
}
}

/*
* Compare the 'pageEncoding' attribute of the page directive with
* the encoding specified in the XML prolog (only for XML syntax,
* and only if JSP document contains XML prolog with encoding
* declaration). Treat "UTF-16", "UTF-16BE", and "UTF-16LE" as
* identical.
*/
if ((root.isXmlSyntax() && root.isEncodingSpecifiedInProlog()) ||
root.isBomPresent()) {
String pageEnc = root.getPageEncoding();
if (!pageDirEnc.equalsIgnoreCase(pageEnc)
&& (!pageDirEnc.toUpperCase().startsWith("UTF-16") ||
!pageEnc
.toUpperCase().startsWith("UTF-16"))) {
err.jspError(pageDir,
"jsp.error.prolog_pagedir_encoding_mismatch",
pageEnc, pageDirEnc);
} else {
return pageEnc;
}
}

return pageDirEnc;
}
{code}

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.

2008-05-13T04:31:07Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44494

Andrew Savory <asavory@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |asavory@...

--- Comment #53 from Andrew Savory <asavory@...> 2008-05-13 04:31:05 PST ---
Since this bug effectively means tomcat 6.0.16 is unable to reliably handle
requests, perhaps it should be publicised more widely, and the 6.0.16 release
pulled (or replaced with 6.0.16.1)?

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "SSLWithFORMFallback6" by VegarNeshaug

2008-05-13T01:46:52Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by VegarNeshaug:
http://wiki.apache.org/tomcat/SSLWithFORMFallback6

The comment on the change is:
Added start() and stop() delegation

------------------------------------------------------------------------------
}
}

+ @Override
+ public void start() throws LifecycleException {
+ super.start();
+ formAuthenticator.start();
+ sslAuthenticator.start();
+ }
+
+ @Override
+ public void stop() throws LifecycleException {
+ super.stop();
+ formAuthenticator.stop();
+ sslAuthenticator.stop();
+ }
+
// I'd rather not have the below, but it is necessary for the
// authenticators to work properly.
@Override

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44976] Tomcat 5.5.25 download zip is corrupt

2008-05-12T13:45:37Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44976

Mark Thomas <markt@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID

--- Comment #2 from Mark Thomas <markt@...> 2008-05-12 13:45:36 PST ---
The file is fine. Most likely cause is a cache between the OP and the ASF
holding a broken version, eg due to a cancelled download.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44976] Tomcat 5.5.25 download zip is corrupt

2008-05-12T12:55:05Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44976

--- Comment #1 from Markus Schiegl <apache@...> 2008-05-12 12:55:05 PST ---
just tested a few minutes ago: neither Windows XP nor MacOS X 10.4 (unzip +
stuffit 11) have any problems unpacking this archive.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 41504] Illegal access: this web application instance has been stopped already

2008-05-12T11:10:56Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=41504

Mark Thomas <markt@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |NEEDINFO

--- Comment #6 from Mark Thomas <markt@...> 2008-05-12 11:10:56 PST ---
A couple of questions to help get to the bottom of this:
1. Does this still happen without your classloader in the picture?
2. Does it happen with the latest 5.5.x?
3. Can you provide a simple test war (with source for any servlets etc) and/or
the steps to reproduce on a clean install.

Note for the test war you can leave out large libs in WEB-IBF/lib - just let us
know exactly which versions to add.

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 43094] Allowing non-file based keystore and other providers

2008-05-12T10:32:03Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=43094

--- Comment #4 from Bruno Harbulot <Bruno.Harbulot@...> 2008-05-12 10:32:02 PST ---
(In reply to comment #3)
> I have applied a patch to trunk based on your suggestion and proposed it for
> 6.0.x.
>

Thank you.
I've just had a look at
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?revision=653128&view=markup
It seems that you've applied a patch along the original report and not the
second patch I sent with comment #1. I believe that second patch (being able to
set the provider name) could also be useful, even for PKCS#11 applications (one
of the ways to configure PKCS#11 is to set up the PKCS#11 options as part of
the JVM security provider list, which adds a provider with a new name).

More generally, since I opened this issue, I've been making similar suggestions
for other projects, in particular Jetty [1] and Restlet [2]. This led me to
write a few classes (SSLContext factories) to make the configuration of SSL
properties a bit easier, including more advanced options such as Certificate
Revocation Lists (I must admit I'm not quite sure how CRLs are to be configured
in Tomcat). These classes are available at http://code.google.com/p/jsslutils/.
I'm not sure whether this would be useful for Tomcat, but this might be of
interest (feel free to get in touch...).

[1] http://www.mortbay.org/jetty/
[2] http://www.restlet.org/

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "SSLWithFORMFallback6" by VegarNeshaug

2008-05-12T10:24:16Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by VegarNeshaug:
http://wiki.apache.org/tomcat/SSLWithFORMFallback6

------------------------------------------------------------------------------
import org.apache.coyote.ActionCode;
/**
*
- * @author vegar
+ * @author Vegar Neshaug
*/
public class SSLWithFormFallback extends AuthenticatorBase {
// Our two authenticators

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

[Tomcat Wiki] Update of "SSLWithFORMFallback6" by VegarNeshaug

2008-05-12T10:22:09Z

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification.

The following page has been changed by VegarNeshaug:
http://wiki.apache.org/tomcat/SSLWithFORMFallback6

New page:
This is my implementation of SSL with FORM fallback. It has been tested on tomcat 6.0.16. Feel free to use at is you like. I do not know if this is the best approach, but it's simple and it works. Also see [http://wiki.apache.org/tomcat/SSLWithFORMFallback]

{{{
import java.io.IOException;
import java.security.Principal;
import java.security.cert.X509Certificate;
import javax.management.MalformedObjectNameException;
import javax.management.ObjectName;
import org.apache.catalina.Container;
import org.apache.catalina.Globals;
import org.apache.catalina.authenticator.AuthenticatorBase;
import org.apache.catalina.authenticator.Constants;
import org.apache.catalina.authenticator.FormAuthenticator;
import org.apache.catalina.authenticator.SSLAuthenticator;
import org.apache.catalina.connector.Request;
import org.apache.catalina.connector.Response;
import org.apache.catalina.deploy.LoginConfig;
import org.apache.coyote.ActionCode;
/**
*
* @author vegar
*/
public class SSLWithFormFallback extends AuthenticatorBase {
// Our two authenticators
FormAuthenticator formAuthenticator = new FormAuthenticator();
SSLAuthenticator sslAuthenticator = new SSLAuthenticator();
/**
* Descriptive information about this implementation.
*/
protected static final String info =
"net.neshaug.SSLWithFormFallback/1.0";

/**
* Return descriptive information about this Valve implementation.
*/
@Override
public String getInfo() {
return (info);
}

@Override
public boolean authenticate(Request request, Response response, LoginConfig config) throws IOException {
// Have we already authenticated someone?
Principal principal = request.getUserPrincipal();
//String ssoId = (String) request.getNote(Constants.REQ_SSOID_NOTE);
if (principal != null) {
// Associate the session with any existing SSO session in order
// to get coordinated session invalidation at logout
String ssoId = (String) request.getNote(Constants.REQ_SSOID_NOTE);
if (ssoId != null) {
associate(ssoId, request.getSessionInternal(true));
}
return (true);
}

// Get certificates from the request
boolean certAuth = true;
X509Certificate certs[] = (X509Certificate[]) request.getAttribute(Globals.CERTIFICATES_ATTR);
if ((certs == null) || (certs.length < 1)) {
request.getCoyoteRequest().action(ActionCode.ACTION_REQ_SSL_CERTIFICATE, null);
certs = (X509Certificate[]) request.getAttribute(Globals.CERTIFICATES_ATTR);
}
if ((certs == null) || (certs.length < 1)) {
// No certificates
certAuth = false;
}

// Delegate authentication request
if (certAuth) {
return sslAuthenticator.authenticate(request, response, config);
} else {
return formAuthenticator.authenticate(request, response, config);
}
}

// I'd rather not have the below, but it is necessary for the
// authenticators to work properly.
@Override
public void setContainer(Container container) {
super.setContainer(container);
sslAuthenticator.setContainer(container);
formAuthenticator.setContainer(container);
}

@Override
public ObjectName createObjectName(String domain, ObjectName parent)
throws MalformedObjectNameException {
sslAuthenticator.createObjectName(domain, parent);
formAuthenticator.createObjectName(domain, parent);
return super.createObjectName(domain, parent);
}
}
}}}

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 44976] New: Tomcat 5.5.25 download zip is corrupt

2008-05-12T09:33:36Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=44976

Summary: Tomcat 5.5.25 download zip is corrupt
Product: Tomcat 5
Version: 5.5.25
Platform: PC
OS/Version: Mac OS X 10.4
Status: NEW
Severity: major
Priority: P2
Component: Unknown
AssignedTo: tomcat-dev@...
ReportedBy: ravi.varanasi@...
CC: ravi.varanasi@...

The download to 5.5.25 zip file is not working.
http://www.apache.org/dist/tomcat/tomcat-5/v5.5.25/bin/apache-tomcat-5.5.25.zip
Ravi

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

DO NOT REPLY [Bug 41504] Illegal access: this web application instance has been stopped already

2008-05-12T06:22:05Z

https://issues.apache.org/bugzilla/show_bug.cgi?id=41504

Tapas Adhikary <tapas.adhikary@...> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tapas.adhikary@...
Status|RESOLVED |REOPENED
Resolution|INVALID |

--- Comment #5 from Tapas Adhikary <tapas.adhikary@...> 2008-05-12 06:22:03 PST ---
Hi ,
I am able to reproduce the same problem and getting the following exception
while loading the class from jDom.jar using tomcat 5.5.24.

==============================================================================
May 12, 2008 6:43:05 PM org.apache.catalina.loader.WebappClassLoader loadClass
INFO: Illegal access: this web application instance has been stopped already.
Could not load JDOMAbout$Author. The eventual following stack trace is caused
by an error thrown for debugging purposes as well as to attempt to terminate
the thread which caused the illegal access, and has no functional impact.
java.lang.IllegalStateException
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1248)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1208)
at
com.company.nps.gadgetManager.LaunchService.loadJars(LaunchService.java:654)
at
com.company.nps.gadgetManager.LaunchService.onDelegateAction(LaunchService.java:85)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
com.company.nps.gadgetManager.BaseGadgetInstance.handleAction(BaseGadgetInstance.java:2362)
at
com.company.nps.gadgetManager.GadgetManager.processInstanceRequest(GadgetManager.java:1606)
at
com.company.nps.gadgetManager.GadgetManager.processServiceRequest(GadgetManager.java:1062)
at
com.company.nps.PortalServlet.handleFrameService(PortalServlet.java:505)
at com.company.nps.PortalServlet.processRequest(PortalServlet.java:373)
at com.company.nps.PortalServlet.doPost(PortalServlet.java:279)
at com.company.nps.PortalServlet.doGet(PortalServlet.java:262)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
at
com.company.emframe.fw.servlet.AuthenticatorServlet.service(AuthenticatorServlet.java:323)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:874)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)
at java.lang.Thread.run(Thread.java:595)

===============================================================================
I have wrote a CustomClassLoader extending WebAppClassLoader and configured the
server.xml file with

<Context docBase="myProject" path="/nps" reloadable="true"
source="org.eclipse.jst.j2ee.server:myProject">
<Loader Reloadable="false" debug="10" delegate="false"
loaderClass="com.novell.nps.utils.CCL" />
</Context>

and made a jar of my custom class loader class CCL.java and keeping the jar in
common/lib of my tomcat.

Please look into the issue.

Thanks,
-Tapas

--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

SSLEnabled attribute in embedded Tomcat6.0

2008-05-12T02:41:08Z

hi
Please tell me a way to configure SSL environment using embedded tomcat 6.0

I have tried it using Embedded tomcat 5.5.9 and it accepts the https
requests. But when trying to run the same code using embedded Apache tomcat
6.0, it doesnt accepts https requests.

When I debugged it, I found that no socket is formed while using 6.0
version, but a JSSE socket was formed while using 5.0 version.

IntrospectionUtils.setProperty(this, "port", "" + port);
IntrospectionUtils.setProperty(this, "address", "" + address);
IntrospectionUtils.setProperty(this, "sslProtocol", "TLS");
IntrospectionUtils.setProperty(this, "keystoreFile", keyStoreFile);
IntrospectionUtils.setProperty(this, "keystorePass", keyStorePassword);
connector.setSecure(true);
connector.setScheme("https");
connector.setEnableLookups(false);
connector.start();
this.embedded.addConnector(connector);
than I added the connector to already started tomcat. This worked in earlier
version embedded (Apache tomcat 5.5.9 ) but not in embedded Apache tomcat
6.0.

Please help me to fnad a solution so that https requests can be handled by
embedded tomcat6.0 .

Thanks in advance

Best Regards,
Swati

SSLEnabled attribute in embedded Tomcat6.0

2008-05-12T02:23:55Z

Bug report for Watchdog [2008/05/11]

2008-05-11T23:08:23Z

+---------------------------------------------------------------------------+
| Bugzilla Bug ID |
| +---------------------------------------------------------------------+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned |
| | OPN=Reopened VER=Verified (Skipped Closed/Resolved) |
| | +-----------------------------------------------------------------+
| | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major |
| | | MIN=Minor NOR=Normal ENH=Enhancement TRV=Trivial |
| | | +-------------------------------------------------------------+
| | | | Date Posted |
| | | | +--------------------------------------------------+
| | | | | Description |
| | | | | |
| 278|Unc|Nor|2000-12-04|Bug in GetParameterValuesTestServlet.java file Bug|
| 279|Unc|Nor|2000-12-04|Logical Error in GetParameterValuesTestServlet Bug|
| 469|Unc|Nor|2001-01-17|in example-taglib.tld "urn" should be "uri" BugRat|
| 470|Unc|Nor|2001-01-17|FAIL positiveForward.jsp and positiveInclude.jsp B|
| 9634|New|Enh|2002-06-05|No tests exist for ServletContext.getResourcePaths|
|10703|New|Enh|2002-07-11|Need to test getRequestURI after RequestDispatcher|
|11336|New|Enh|2002-07-31|Test wrapped path methods with RD.foward() |
|11663|New|Maj|2002-08-13|JSP precompile tests rely on Jasper specific behav|
|11664|New|Maj|2002-08-13|A sweep is needed of all Watchdog 4.0 tag librarie|
|11665|New|Maj|2002-08-13|ServletToJSPErrorPageTest and ServletToServletErro|
|11666|New|Maj|2002-08-13|SetBufferSize_1TestServlet is invalid. |
|14004|New|Maj|2002-10-28|Incorrent behaviour of all attribute-related lifec|
|15504|New|Nor|2002-12-18|JSP positiveGetValues test relies on order preserv|
|24649|New|Nor|2003-11-12|getRemoteHost fails when agent has uppercase chara|
|29398|New|Nor|2004-06-04|Update site and note current status |
+-----+---+---+----------+--------------------------------------------------+
| Total 15 bugs |
+---------------------------------------------------------------------------+

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...