Thinstation 2.2.2 DHCP Bug

[Dan Burns]

Hi,

I believe I have come across a bug in version 2.2.2 of Thinstation.  When I build clients in this version and use DHCP the client does not appear to be passing its name to the DHCP server, as a result the DHCP leases are being registred with a blank name.  We use Windows 2003 DHCP Servers, I have checked the DHCP log and can see that the name is missing in there when the lease is assigned.  If I rollback the client to version 2.2.1 and use the exact same build.conf and thinstation.conf.buildtime files then the same client registers in DHCP along with its name so it definitely appears to be a bug in 2.2.2.

Does anyone know of an easy way to resolve this or is it better to stick with 2.2.1 for the time being (we rely on the hostname being passed to DHCP since the DHCP servers dynamically update DNS on behalf of the client).

Many thanks

Dan

[Trevor Batley]

On Tue, 2008-09-09 at 03:35 -0700, Dan Burns wrote:
> Hi,
>
> I believe I have come across a bug in version 2.2.2 of Thinstation.  

An introduced bug as part of the patch to fix the assigning of 2 IP
addresses to Workstations (did you notice they don't anymore....).

> When I
> build clients in this version and use DHCP the client does not appear to be
> passing its name to the DHCP server, as a result the DHCP leases are being
> registred with a blank name.  We use Windows 2003 DHCP Servers, I have
> checked the DHCP log and can see that the name is missing in there when the
> lease is assigned.  If I rollback the client to version 2.2.1 and use the
> exact same build.conf and thinstation.conf.buildtime files then the same
> client registers in DHCP along with its name so it definitely appears to be
> a bug in 2.2.2.
>
> Does anyone know of an easy way to resolve this or is it better to stick
> with 2.2.1 for the time being (we rely on the hostname being passed to DHCP
> since the DHCP servers dynamically update DNS on behalf of the client).
>

The two line to look at are:
packages/base/etc/init.d/network - line 214
            if udhcpc -n -i $device -C -s /etc/init.d/network_script || udhcpc
-n -i $device -C -s /etc/init.d/network_script  ; then
and packages/base/etc/thinstation.init - line 281
        udhcpc -n -i $DEVICE -C -s /etc/init.d/network_script

The -H $hostname parameter will pass the hostname to the dhcp server
(but the old script actually had -H $client_mac).

Not sure what the final fix for TS will be. If you can feedback whether
it works for you AND still only allocates 1 IP (although I gather that
this didn't worry you).

Good Luck
Trevor B

> Many thanks
>
> Dan


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Thinstation-developer mailing list
Thinstation-developer@...
https://lists.sourceforge.net/lists/listinfo/thinstation-developer

[Dan Burns]

Hi Trevor

Thanks for getting back so quickly !  I had noticed that the duplicate IPs had disappeared in DHCP.  I have found the section in the first file (network) and made the change by adding '-H $hostname', however I cannot find any such line in /packages/etc/thinstation.init (I've searched the whole file for udhcpc), in fact the file only has around 141 lines in it, is this correct ?  I checked the same file in version 2.2.1 and it is the same, this line isn't in it, am I missing something ?

Many thanks

Dan

Trevor Batley wrote:

On Tue, 2008-09-09 at 03:35 -0700, Dan Burns wrote:
> Hi,
>
> I believe I have come across a bug in version 2.2.2 of Thinstation.  

An introduced bug as part of the patch to fix the assigning of 2 IP
addresses to Workstations (did you notice they don't anymore....).

> When I
> build clients in this version and use DHCP the client does not appear to be
> passing its name to the DHCP server, as a result the DHCP leases are being
> registred with a blank name.  We use Windows 2003 DHCP Servers, I have
> checked the DHCP log and can see that the name is missing in there when the
> lease is assigned.  If I rollback the client to version 2.2.1 and use the
> exact same build.conf and thinstation.conf.buildtime files then the same
> client registers in DHCP along with its name so it definitely appears to be
> a bug in 2.2.2.
>
> Does anyone know of an easy way to resolve this or is it better to stick
> with 2.2.1 for the time being (we rely on the hostname being passed to DHCP
> since the DHCP servers dynamically update DNS on behalf of the client).
>
The two line to look at are:
packages/base/etc/init.d/network - line 214
            if udhcpc -n -i $device -C -s /etc/init.d/network_script || udhcpc
-n -i $device -C -s /etc/init.d/network_script  ; then
and packages/base/etc/thinstation.init - line 281
        udhcpc -n -i $DEVICE -C -s /etc/init.d/network_script

The -H $hostname parameter will pass the hostname to the dhcp server
(but the old script actually had -H $client_mac).

Not sure what the final fix for TS will be. If you can feedback whether
it works for you AND still only allocates 1 IP (although I gather that
this didn't worry you).

Good Luck
Trevor B

> Many thanks
>
> Dan


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Thinstation-developer mailing list
[e-mail]
https://lists.sourceforge.net/lists/listinfo/thinstation-developer

[Trevor Batley]

On Tue, 2008-09-09 at 05:49 -0700, Dan Burns wrote:
> Hi Trevor
>
> Thanks for getting back so quickly !  I had noticed that the duplicate IPs
> had disappeared in DHCP.  I have found the section in the first file
> (network) and made the change by adding '-H $hostname', however I cannot
> find any such line in /packages/etc/thinstation.init (I've searched the
> whole file for udhcpc), in fact the file only has around 141 lines in it, is
> this correct ?  I checked the same file in version 2.2.1 and it is the same,
> this line isn't in it, am I missing something ?

It would probably help if I told you the correct file... :-)

It's actually thinstation.functions

Sorry
Trevor B

>
> Many thanks
>
> Dan
>
>
> Trevor Batley wrote:
> >
> > On Tue, 2008-09-09 at 03:35 -0700, Dan Burns wrote:
> >> Hi,
> >>
> >> I believe I have come across a bug in version 2.2.2 of Thinstation.  
> >
> > An introduced bug as part of the patch to fix the assigning of 2 IP
> > addresses to Workstations (did you notice they don't anymore....).
> >
> >> When I
> >> build clients in this version and use DHCP the client does not appear to
> >> be
> >> passing its name to the DHCP server, as a result the DHCP leases are
> >> being
> >> registred with a blank name.  We use Windows 2003 DHCP Servers, I have
> >> checked the DHCP log and can see that the name is missing in there when
> >> the
> >> lease is assigned.  If I rollback the client to version 2.2.1 and use the
> >> exact same build.conf and thinstation.conf.buildtime files then the same
> >> client registers in DHCP along with its name so it definitely appears to
> >> be
> >> a bug in 2.2.2.
> >>
> >> Does anyone know of an easy way to resolve this or is it better to stick
> >> with 2.2.1 for the time being (we rely on the hostname being passed to
> >> DHCP
> >> since the DHCP servers dynamically update DNS on behalf of the client).
> >>
> > The two line to look at are:
> > packages/base/etc/init.d/network - line 214
> >    if udhcpc -n -i $device -C -s /etc/init.d/network_script || udhcpc
> > -n -i $device -C -s /etc/init.d/network_script  ; then
> > and packages/base/etc/thinstation.init - line 281
> > udhcpc -n -i $DEVICE -C -s /etc/init.d/network_script
> >
> > The -H $hostname parameter will pass the hostname to the dhcp server
> > (but the old script actually had -H $client_mac).
> >
> > Not sure what the final fix for TS will be. If you can feedback whether
> > it works for you AND still only allocates 1 IP (although I gather that
> > this didn't worry you).
> >
> > Good Luck
> > Trevor B
> >
> >> Many thanks
> >>
> >> Dan
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's
> > challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Thinstation-developer mailing list
> > Thinstation-developer@...
> > https://lists.sourceforge.net/lists/listinfo/thinstation-developer
> >
> >

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Thinstation-developer mailing list
Thinstation-developer@...
https://lists.sourceforge.net/lists/listinfo/thinstation-developer

[Dan Burns]

Hi Trevor

That did the trick, I modified the two lines you suggested, the only difference is I used '-H $CLIENT_NAME' rather than using $hostname.  DHCP is now updating correctly, initial testing suggests that it is only registering a single lease as well so all looking good.

Yet again thanks for such a speedy and effective fix !

Regards

Dan

Trevor Batley wrote:

On Tue, 2008-09-09 at 05:49 -0700, Dan Burns wrote:
> Hi Trevor
>
> Thanks for getting back so quickly !  I had noticed that the duplicate IPs
> had disappeared in DHCP.  I have found the section in the first file
> (network) and made the change by adding '-H $hostname', however I cannot
> find any such line in /packages/etc/thinstation.init (I've searched the
> whole file for udhcpc), in fact the file only has around 141 lines in it, is
> this correct ?  I checked the same file in version 2.2.1 and it is the same,
> this line isn't in it, am I missing something ?

It would probably help if I told you the correct file... :-)

It's actually thinstation.functions

Sorry
Trevor B
>
> Many thanks
>
> Dan
>
>
> Trevor Batley wrote:
> >
> > On Tue, 2008-09-09 at 03:35 -0700, Dan Burns wrote:
> >> Hi,
> >>
> >> I believe I have come across a bug in version 2.2.2 of Thinstation.  
> >
> > An introduced bug as part of the patch to fix the assigning of 2 IP
> > addresses to Workstations (did you notice they don't anymore....).
> >
> >> When I
> >> build clients in this version and use DHCP the client does not appear to
> >> be
> >> passing its name to the DHCP server, as a result the DHCP leases are
> >> being
> >> registred with a blank name.  We use Windows 2003 DHCP Servers, I have
> >> checked the DHCP log and can see that the name is missing in there when
> >> the
> >> lease is assigned.  If I rollback the client to version 2.2.1 and use the
> >> exact same build.conf and thinstation.conf.buildtime files then the same
> >> client registers in DHCP along with its name so it definitely appears to
> >> be
> >> a bug in 2.2.2.
> >>
> >> Does anyone know of an easy way to resolve this or is it better to stick
> >> with 2.2.1 for the time being (we rely on the hostname being passed to
> >> DHCP
> >> since the DHCP servers dynamically update DNS on behalf of the client).
> >>
> > The two line to look at are:
> > packages/base/etc/init.d/network - line 214
> >    if udhcpc -n -i $device -C -s /etc/init.d/network_script || udhcpc
> > -n -i $device -C -s /etc/init.d/network_script  ; then
> > and packages/base/etc/thinstation.init - line 281
> > udhcpc -n -i $DEVICE -C -s /etc/init.d/network_script
> >
> > The -H $hostname parameter will pass the hostname to the dhcp server
> > (but the old script actually had -H $client_mac).
> >
> > Not sure what the final fix for TS will be. If you can feedback whether
> > it works for you AND still only allocates 1 IP (although I gather that
> > this didn't worry you).
> >
> > Good Luck
> > Trevor B
> >
> >> Many thanks
> >>
> >> Dan
> >
> >
> > -------------------------------------------------------------------------
> > This SF.Net email is sponsored by the Moblin Your Move Developer's
> > challenge
> > Build the coolest Linux based applications with Moblin SDK & win great
> > prizes
> > Grand prize is a trip for two to an Open Source event anywhere in the
> > world
> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
> > _______________________________________________
> > Thinstation-developer mailing list
> > [e-mail]
> > https://lists.sourceforge.net/lists/listinfo/thinstation-developer
> >
> >



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Thinstation-developer mailing list
[e-mail]
https://lists.sourceforge.net/lists/listinfo/thinstation-developer