TagLib doesn't handle xiphcomments spread over multiple ogg pages

[Sander Jansen]

I know Scott is a busy guy at the moment, but regarding bug 162931
(http://bugs.kde.org/show_bug.cgi?id=16293), is there any chance of
having a bugfix release of taglib soon that fixes this?

Thanks,
Sander
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

Sander Jansen wrote:
> I know Scott is a busy guy at the moment, but regarding bug 162931
> (http://bugs.kde.org/show_bug.cgi?id=16293), is there any chance of
> having a bugfix release of taglib soon that fixes this?

There's a reasonable chance that there will be a bugfix release in the
next couple of months, but I don't consider that bug especially
critical.  You pretty much only run over one Ogg Page when you do
exactly what the Vorbis Comment spec tells you not to -- put non-text
data in a comment.  (http://www.xiph.org/vorbis/doc/v-comment.html)

-Scott
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

[Sander Jansen]

On Wed, Jun 11, 2008 at 2:15 AM, Scott Wheeler <wheeler@...> wrote:

> Sander Jansen wrote:
>> I know Scott is a busy guy at the moment, but regarding bug 162931
>> (http://bugs.kde.org/show_bug.cgi?id=16293), is there any chance of
>> having a bugfix release of taglib soon that fixes this?
>
> There's a reasonable chance that there will be a bugfix release in the
> next couple of months, but I don't consider that bug especially
> critical.  You pretty much only run over one Ogg Page when you do
> exactly what the Vorbis Comment spec tells you not to -- put non-text
> data in a comment.  (http://www.xiph.org/vorbis/doc/v-comment.html)

I can quote specs as well: "Packets are not restricted to beginning
and ending within a page". But that is besides the point. Putting
album art in a comment block makes much more sense than putting it in
a separate logical stream (for which there is no spec).
Anyway, in the mean time, I'll start using my own ogg vorbis reader
for this then :)
Thanks anyway,

Sander

>
> -Scott
> _______________________________________________
> taglib-devel mailing list
> taglib-devel@...
> https://mail.kde.org/mailman/listinfo/taglib-devel
>
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel

Sander Jansen wrote:
> I can quote specs as well: "Packets are not restricted to beginning and ending within a page".

Sure -- I'm not saying that it's not a bug in TagLib, just that the case
where you're likely to go over the 64 kb limit of a page is if you're
abusing what the comments are for.

> But that is besides the point. Putting album art in a comment block makes much more sense than putting it in a separate logical stream (for which there is no spec).
>  

Perhaps for your application, but not for those that inter-op with it
and follow the spec by assuming all data there to be human readable.  
I'd really discourage this use of comments.

> Anyway, in the mean time, I'll start using my own ogg vorbis reader for this then :)

I'll probably fix this in TagLib at some point, but it's just not
something that I feel is especially urgent -- notably since this bug has
been there since the first release of TagLib 4.5 years ago and this is
the first time it's been reported.

-Scott
_______________________________________________
taglib-devel mailing list
taglib-devel@...
https://mail.kde.org/mailman/listinfo/taglib-devel