String error in vformat, patch attached

[Holger Berndt]

Hi,

while trying to find the cause of a crash that I was experiencing, I
came accross the a format string bug in the svn version of OpenSync. A
tiny patch to fix the issue is attached.

As it's so tiny and obvious, I am not writing a trac ticket for that.
It would be nice if it could be integrated into svn soonish.

The patch is relative to the top level directory of the vformat plugin.

Thanks,
Holger
[vformat_trace_string_fix.patch]

---

Index: src/xmlformat-vcalendar.c
===================================================================
--- src/xmlformat-vcalendar.c (Revision 3235)
+++ src/xmlformat-vcalendar.c (Arbeitskopie)
@@ -464,7 +464,7 @@
 
 void handle_tzid_parameter(OSyncXMLField *xmlfield, VFormatParam *param)
 {
- osync_trace(TRACE_INTERNAL, "Handling %s parameter %s\n", vformat_attribute_param_get_name(param));
+ osync_trace(TRACE_INTERNAL, "Handling %s parameter", vformat_attribute_param_get_name(param));
  osync_xmlfield_set_attr(xmlfield, "TimezoneID", vformat_attribute_param_get_nth_value(param, 0));
 }
 

---

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel

[Michael Bell]

Hi Holger,

usually only Christopher should touch vformat but the patch is so small
that I commited it immediately.

Holger Berndt schrieb:

> while trying to find the cause of a crash that I was experiencing, I
> came accross the a format string bug in the svn version of OpenSync. A
> tiny patch to fix the issue is attached.
>
> As it's so tiny and obvious, I am not writing a trac ticket for that.
> It would be nice if it could be integrated into svn soonish.
>
> The patch is relative to the top level directory of the vformat plugin.

Commited. SVN rev 3236.

Many thanks

Michael
--
_______________________________________________________________

Michael Bell                    Humboldt-Universitaet zu Berlin

Tel.: [phone]       ZE Computer- und Medienservice
Fax:  [phone]       Unter den Linden 6
michael.bell@...   D-10099 Berlin
_______________________________________________________________

X.509 CA Certificates / Wurzelzertifikate

http://ra.pki.hu-berlin.de


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel

[Holger Berndt]

Michael,

Michael Bell schrieb:
> Commited. SVN rev 3236.

thanks for integrating this so fast.

Holger

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Opensync-devel mailing list
Opensync-devel@...
https://lists.sourceforge.net/lists/listinfo/opensync-devel