Status of #6621

View: New views
3 Messages — Rating Filter:   Alert me  

Status of #6621

by Jeff Anderson-6 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello I've run into a bug[0] with that affects a new app that is 'out
there' and is experimental. I have to apply this patch to get the app to
work. There doesn't seem to be anything controversial about the patch.
I've updated the patch to apply cleanly against the current SVN. Is
there anything else that needs to be done before merging this?

Thanks!


Jeff

[0] http://code.djangoproject.com/ticket/6621



signature.asc (204 bytes) Download Attachment

Re: Status of #6621

by Malcolm Tredinnick :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



On Sat, 2008-07-05 at 15:58 -0600, Jeff Anderson wrote:
> Hello I've run into a bug[0] with that affects a new app that is 'out
> there' and is experimental. I have to apply this patch to get the app to
> work. There doesn't seem to be anything controversial about the patch.
> I've updated the patch to apply cleanly against the current SVN. Is
> there anything else that needs to be done before merging this?

It needs people to demonstrate some patience. Good thigns come to those
who wait.

This is hardly the highest priority ticket in Trac or the one with the
biggest impact. There seems to be some confusion in the comments on that
ticket as to what the correct behaviour should be (and from a quick read
I don't think I agree with them). There also might be some technical
problems with the patch (startswith() is often more efficient than a
reg-exp.

At some point the patch will be reviewed and fixed. There are a number
of sprints coming up with focus on things like that.

Regards,
Malcolm


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-developers@...
To unsubscribe from this group, send email to django-developers-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---


Re: Status of #6621

by Malcolm Tredinnick :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



On Sun, 2008-07-06 at 10:40 +1000, Malcolm Tredinnick wrote:

>
> On Sat, 2008-07-05 at 15:58 -0600, Jeff Anderson wrote:
> > Hello I've run into a bug[0] with that affects a new app that is 'out
> > there' and is experimental. I have to apply this patch to get the app to
> > work. There doesn't seem to be anything controversial about the patch.
> > I've updated the patch to apply cleanly against the current SVN. Is
> > there anything else that needs to be done before merging this?
>
> It needs people to demonstrate some patience. Good thigns come to those
> who wait.

I should also have said thank-you for updating the patch and searching
it out before just filing a new ticket. Your contribution isn't
unappreciated at all.

Regards,
Malcolm



--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Django developers" group.
To post to this group, send email to django-developers@...
To unsubscribe from this group, send email to django-developers-unsubscribe@...
For more options, visit this group at http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

LightInTheBox - Buy quality products at wholesale price