Code Coverage by Clover.NET

Small bug in RichTextBoxTarget

View: New views
1 Messages — Rating Filter:   Alert me  

Small bug in RichTextBoxTarget

by mattman206 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

First off, THANKS for such a great logging framework.  NLog is awesome :)

That being said, I just found a small bug in the RichTextBoxTarget.

In my project, I have a custom control (LogRichTextBox) that is a subclass of the RichTextBox control.  When I try to use the RichTextBoxTarget, no text is output to the LogRichTextBox.  However, if I change my code to use the standard RichTextBox instead of my custom control, then everything works great.

I've traced the problem down to FormHelper.FindControl(), which is used by the RichTextBoxTarget --
...
searchControl.GetType() == controlType

The method is searching for an _exact_ match between the control and RichTextBox, when it should be looking to see if searchControl can be cast to the controlType.  i.e. searchControl.GetType().IsAssignableFrom(controlType).

Hope that helps :)
-Matt



 

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Nlog-list mailing list
Nlog-list@...
https://lists.sourceforge.net/lists/listinfo/nlog-list