Small Possible Bug in 1.4.15..

[Michael Peddemors]

Looking at the laod_prefs.php include file..

There is a bunch of code to try to decide what theme to use, and it assigns it
to $chosen_theme, however ...

if (isset($chosen_theme) && $found_theme && (file_exists($chosen_theme))) {
    @include_once($chosen_theme);
} else {
    if (isset($theme) && isset($theme[$theme_default]) &&
file_exists($theme[$theme_default]['PATH'])) {
        @include_once($theme[$theme_default]['PATH']);
        $chosen_theme = $theme[$theme_default]['PATH'];
    }
}


if (!defined('download_php')) {
    sqsession_register($theme_css, 'theme_css');
}


Aren't we registering the wrong variable here?



--
--
"Catch the Magic of Linux..."
------------------------------------------------------------------------
Michael Peddemors - President/CEO - LinuxMagic
Products, Services, Support and Development
Visit us at http://www.linuxmagic.com
------------------------------------------------------------------------
A Wizard IT Company - For More Info http://www.wizard.ca
"LinuxMagic" is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
------------------------------------------------------------------------
604-589-0037 Beautiful British Columbia, Canada

This email and any electronic data contained are confidential and intended
solely for the use of the individual or entity to which they are addressed.
Please note that any views or opinions presented in this email are solely
those of the author and are not intended to  represent those of the company.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Alexandros Vellis]

On Wed, 4 Jun 2008 12:39:45 -0700
Michael Peddemors <michael@...> wrote:

> if (!defined('download_php')) {
>     sqsession_register($theme_css, 'theme_css');
> }
>
>
> Aren't we registering the wrong variable here?

Hm, FWIW these lines seem redundant

  8096   jervfors if (!defined('download_php')) {
  8096   jervfors     sqsession_register($theme_css, 'theme_css');

as grepping for 'download_php' produces no results, and no script seems
to get theme_css from $_SESSION, both in stable & devel.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Michael Peddemors]

It looks like the intention was that you could define an external css from a
remote location with this variable.. but as you pointed out..

Interesting idea, however not implemented properly..

On Tuesday 10 June 2008 05:55, Alexandros Vellis wrote:

> On Wed, 4 Jun 2008 12:39:45 -0700
>
> Michael Peddemors <michael@...> wrote:
> > if (!defined('download_php')) {
> >     sqsession_register($theme_css, 'theme_css');
> > }
> >
> >
> > Aren't we registering the wrong variable here?
>
> Hm, FWIW these lines seem redundant
>
>   8096   jervfors if (!defined('download_php')) {
>   8096   jervfors     sqsession_register($theme_css, 'theme_css');
>
> as grepping for 'download_php' produces no results, and no script seems
> to get theme_css from $_SESSION, both in stable & devel.

--
--
"Catch the Magic of Linux..."
------------------------------------------------------------------------
Michael Peddemors - President/CEO - LinuxMagic
Products, Services, Support and Development
Visit us at http://www.linuxmagic.com
------------------------------------------------------------------------
A Wizard IT Company - For More Info http://www.wizard.ca
"LinuxMagic" is a Registered TradeMark of Wizard Tower TechnoServices Ltd.
------------------------------------------------------------------------
604-589-0037 Beautiful British Columbia, Canada

This email and any electronic data contained are confidential and intended
solely for the use of the individual or entity to which they are addressed.
Please note that any views or opinions presented in this email are solely
those of the author and are not intended to  represent those of the company.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

[Tomas Kuliavas]

Michael Peddemors wrote:

It looks like the intention was that you could define an external css from a
remote location with this variable.. but as you pointed out..

Interesting idea, however not implemented properly..

It is not idea, but leftover from SquirrelMail 1.0 code. Defines were removed in January 2002, SquirrelMail 1.2.5. You can find other obscure things from 2000-2002, if you review SquirrelMail code.