Save as draft broken in recent SQM 1.5.2 SVN versions (patch attached)

View: New views
2 Messages — Rating Filter:   Alert me  

Save as draft broken in recent SQM 1.5.2 SVN versions (patch attached)

by Thierry Godefroy-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Greetings,

The parameters list for the mail() method in the Deliver_IMAP() class was recently changed (one $imap_stream parameter added) and compose.php was patched in one place (for actual mail demlicery code) but misses a patch for the "save as draft" call to this function, breaking "Save as draft" altogether.

The attached patch fixes this bug.

Regards,

Thierry.


      ____________________________________________________________________________________
Be a better friend, newshound, and
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ
[squirrelmail-20080513-SVN_devel-BrokenSaveAsDraft.patch]

diff -urN squirrelmail/src/compose.php squirrelmail-patched/src/compose.php
--- squirrelmail/src/compose.php 2008-04-28 04:19:12.000000000 +0200
+++ squirrelmail-patched/src/compose.php 2008-05-13 11:04:12.000000000 +0200
@@ -1606,7 +1606,7 @@
         if (sqimap_mailbox_exists ($imap_stream, $draft_folder)) {
             require_once(SM_PATH . 'class/deliver/Deliver_IMAP.class.php');
             $imap_deliver = new Deliver_IMAP();
-            $success = $imap_deliver->mail($composeMessage, $imap_stream, $reply_id, $reply_ent_id, $draft_folder);
+            $success = $imap_deliver->mail($composeMessage, $imap_stream, $reply_id, $reply_ent_id, $imap_stream, $draft_folder);
             sqimap_logout($imap_stream);
             unset ($imap_deliver);
             $composeMessage->purgeAttachments();


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel

Re: Save as draft broken in recent SQM 1.5.2 SVN versions (patch attached)

by Thijs Kinkhorst :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Tuesday 13 May 2008 11:14, Thierry Godefroy wrote:
> The parameters list for the mail() method in the Deliver_IMAP() class was
> recently changed (one $imap_stream parameter added) and compose.php was
> patched in one place (for actual mail demlicery code) but misses a patch
> for the "save as draft" call to this function, breaking "Save as draft"
> altogether.

Thanks - I thought I verified devel when I fixed this in stable but
appearently not. It's fixed now.


Thijs

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
-----
squirrelmail-devel mailing list
Posting guidelines: http://squirrelmail.org/postingguidelines
List address: squirrelmail-devel@...
List archives: http://news.gmane.org/gmane.mail.squirrelmail.devel
List info (subscribe/unsubscribe/change options): https://lists.sourceforge.net/lists/listinfo/squirrelmail-devel
LightInTheBox - Buy quality products at wholesale price