SOPE tweak (patch)

View: New views
5 Messages — Rating Filter:   Alert me  

SOPE tweak (patch)

by Adam Tauno Williams :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

In order to fix-up CalDAV support for evolution I had to patch SOPE.
Is it possible to get this patch committed to SOPE?

http://bugzilla.opengroupware.org/bugzilla/attachment.cgi?id=653&action=view

Mozilla makes CalDAV REPORT requests as text/xml,  GNOME uses
application/xml.  This patch just permits the request to be either
Content-Type.


--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

Re: SOPE tweak (patch)

by Helge Hess :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 30.06.2008, at 14:38, Adam Tauno Williams wrote:
> In order to fix-up CalDAV support for evolution I had to patch SOPE.
> Is it possible to get this patch committed to SOPE?
>
> http://bugzilla.opengroupware.org/bugzilla/attachment.cgi?id=653&action=view
>
> Mozilla makes CalDAV REPORT requests as text/xml,  GNOME uses
> application/xml.  This patch just permits the request to be either
> Content-Type.


This is just a link to some attachment?

Thanks,
   Helge
--
Helge Hess
http://www.helgehess.eu/


--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

Re: SOPE tweak (patch)

by Adam Tauno Williams :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, 2008-06-30 at 14:46 +0200, Helge Hess wrote:

> On 30.06.2008, at 14:38, Adam Tauno Williams wrote:
> > In order to fix-up CalDAV support for evolution I had to patch SOPE.
> > Is it possible to get this patch committed to SOPE?
> >
> > http://bugzilla.opengroupware.org/bugzilla/attachment.cgi?id=653&action=view
> >
> > Mozilla makes CalDAV REPORT requests as text/xml,  GNOME uses
> > application/xml.  This patch just permits the request to be either
> > Content-Type.
>
>
> This is just a link to some attachment?

Yes.

<http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1986>

Index: sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
===================================================================
--- sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m (revision 1621)
+++ sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m (working copy)
@@ -1530,7 +1530,8 @@
   
   /* ensure XML */
 
-  if (![[rq headerForKey:@"content-type"] hasPrefix:@"text/xml"]) {
+  if (!([[rq headerForKey:@"content-type"] hasPrefix:@"text/xml"] ||
+        [[rq headerForKey:@"content-type"] hasPrefix:@"application/xml"])) {
     return [self httpException:400 /* invalid request */
  reason:@"XML entity expected for WebDAV REPORT."];
   }

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

Re: SOPE tweak (patch)

by Helge Hess :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 30.06.2008, at 14:49, Adam Tauno Williams wrote:
> Index: sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> ===================================================================
> --- sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> (revision 1621)
> +++ sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> (working copy)
> @@ -1530,7 +1530,8 @@

Ok, applied a variant. Please check.

Thanks,
   Helge
--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer

Re: SOPE tweak (patch)

by Adam Tauno Williams :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Mon, 2008-06-30 at 15:13 +0200, Helge Hess wrote:
> On 30.06.2008, at 14:49, Adam Tauno Williams wrote:
> > Index: sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> > ===================================================================
> > --- sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> > (revision 1621)
> > +++ sope-appserver/NGObjWeb/WebDAV/SoObjectWebDAVDispatcher.m
> > (working copy)
> > @@ -1530,7 +1530,8 @@
> Ok, applied a variant. Please check.

Seems to work.

<http://bugzilla.opengroupware.org/bugzilla/show_bug.cgi?id=1986>

 curl -d '<C:calendar-query xmlns:C="urn:ietf:params:xml:ns:caldav"
xmlns:D="DAV:"><D:prop><D:getetag/></D:prop><C:fiter
name="VCALENDAR"><C:comp-filter
name="VEVENT"/></C:comp-filter></C:filter></C:calendar-query>' -H
"Content-Type: application/xml" -u adam:fred123 -X REPORT
http://localhost:21000/zidestore/dav/adam/Overview/

and

curl -d '<C:calendar-query xmlns:C="urn:ietf:params:xml:ns:caldav"
xmlns:D="DAV:"><D:prop><D:getetag/></D:prop><C:fiter
name="VCALENDAR"><C:comp-filter
name="VEVENT"/></C:comp-filter></C:filter></C:calendar-query>' -H
"Content-Type: text/xml" -u adam:fred123 -X REPORT
http://localhost:21000/zidestore/dav/adam/Overview/

both work.

--
OpenGroupware.org Developer
developer@...
http://mail.opengroupware.org/mailman/listinfo/developer