Nabble - Rome

NumberFormatException while parsing a feed

2008-10-13T04:48:50Z

hi ,

iam encountering numberformatexception while parsing several feeds.

Can anyone please guide on how to resolve this?

Regards
rama

From forum: Rome - Users

Training & jobs

2008-10-03T09:01:55Z

“Join us to make future”
FOR OPT/F-1 STUDENTS
FREE TRAINING
FOOD ACCOMODATION
H1B PROCESSING FOR L1/ L2/ H1/ H4/ EAD/ GC
EXCELLENT OPPRTUNITIES
TRAINING
PLACEMENT
Highly Competitive offers for New H1b Transfers
About Us:
V2 technology inc is serving NJ since 2005, for us our employees are of utmost importance. Our highly skilled and dedicated instructors train you explicitly in market-related technologies for today and tomorrow. We will work with you in developing marketing strategies and finding the assignments of your choice.
We not only help you get a job but we build your long lasting careers!!!
What are we Looking for:
Excellent communication skills.
Valid F1/ OPT/ CPT/ H1/ H4/ L1 or valid work status (EAD, GC).
Bachelors’ degree in CS/ IT or previous IT experience.
Preferably (not mandatory) Master's Degree in Computers/ Electronics or previous IT experience.
Willing to relocate anywhere in USA.
What’s The Deal:
H1-B sponsorship to F1/ OPT/ H4/ L1/ L2/ E3/ EAD
Transfer of H1 & L1 visas.
Green Card sponsorship through PERM
Job focused professional training in
Java/ J2EE
.NET
Documentum
Share point
Oracle
Data Modeling
Relocation assistance- airfare, hotel accommodation, car rental etc
Guarantee lowest bench period.
Employee referral program.
Effective Resume writing help, Marketing and Placement.
Technical mock interviews. Preparation of In Person Interviews
100% Guaranteed placement
Get in Touch:
Contact immediately to know more about the opportunities with us at:609-843-0312
or
write mail at jobs@v2techinc.com
Contact person : John

From forum: Rome - Users

RE: Rome-fetcher in Maven?

2008-10-02T02:51:48Z

Do you need someone to create a pom.xml based on https://rome.dev.java.net/issues/show_bug.cgi?id=83 for rome-fetcher?

Any progress on this?

Nick Lothian wrote:

I've now been granted the maven publisher role for the java.net maven2 repository, so I hope I'll be able to make this happen soon.

Nick

From: mark.a.woodman@gmail.com [mailto:mark.a.woodman@gmail.com] On Behalf Of Mark Woodman
Sent: Saturday, 14 June 2008 12:52 AM
To: Rome-Dev; joeo@enigmastation.com
Subject: Re: Rome-fetcher in Maven?

CCing Rome-Dev

On Fri, Jun 13, 2008 at 5:46 AM, Joseph Ottinger <joeo@enigmastation.com<mailto:joeo@enigmastation.com>> wrote:
Can we update the maven repositories with a more recent version of rome-fetcher? It has a declared dependency on rome 0.3, and ... well... that's archaic.

--
Joseph B. Ottinger
http://enigmastation.com
Engineer, http://gigaspaces.com

________________________________
IMPORTANT: This e-mail, including any attachments, may contain private or confidential information. If you think you may not be the intended recipient, or if you have received this e-mail in error, please contact the sender immediately and delete all copies of this e-mail. If you are not the intended recipient, you must not reproduce any part of this e-mail or disclose its contents to any other party. This email represents the views of the individual sender, which do not necessarily reflect those of education.au limited except where the sender expressly states otherwise. It is your responsibility to scan this email and any files transmitted with it for viruses or any other defects. education.au limited will not be liable for any loss, damage or consequence caused directly or indirectly by this email.

___________________________
http://stubbisms.wordpress.com

From forum: Rome - Development

RE: Rome-fetcher in Maven?

2008-10-02T02:47:40Z

Any progress on this?

Nick Lothian wrote:

I've now been granted the maven publisher role for the java.net maven2 repository, so I hope I'll be able to make this happen soon.

Nick

From: mark.a.woodman@gmail.com [mailto:mark.a.woodman@gmail.com] On Behalf Of Mark Woodman
Sent: Saturday, 14 June 2008 12:52 AM
To: Rome-Dev; joeo@enigmastation.com
Subject: Re: Rome-fetcher in Maven?

CCing Rome-Dev

On Fri, Jun 13, 2008 at 5:46 AM, Joseph Ottinger <joeo@enigmastation.com<mailto:joeo@enigmastation.com>> wrote:
Can we update the maven repositories with a more recent version of rome-fetcher? It has a declared dependency on rome 0.3, and ... well... that's archaic.

--
Joseph B. Ottinger
http://enigmastation.com
Engineer, http://gigaspaces.com

________________________________
IMPORTANT: This e-mail, including any attachments, may contain private or confidential information. If you think you may not be the intended recipient, or if you have received this e-mail in error, please contact the sender immediately and delete all copies of this e-mail. If you are not the intended recipient, you must not reproduce any part of this e-mail or disclose its contents to any other party. This email represents the views of the individual sender, which do not necessarily reflect those of education.au limited except where the sender expressly states otherwise. It is your responsibility to scan this email and any files transmitted with it for viruses or any other defects. education.au limited will not be liable for any loss, damage or consequence caused directly or indirectly by this email.

___________________________
http://stubbisms.wordpress.com

From forum: Rome - Development

Training & jobs

2008-09-22T22:31:12Z

From forum: Rome - Users

Re: rss 0.91 pubdate problem

2008-09-15T06:50:12Z

In RSS0.91 (both Netscape and Userland) <pubDate> is a valid
sub-element of <channel>, not of <item>.

The beurs's feed has the <pubDate> elements at <item> level.

A

On Mon, Sep 15, 2008 at 5:26 PM, Edwin Eversdijk <edwineve@...> wrote:

> I am trying to read an 0.91 rss feed (http://www.beurs.nl/rss/nieuws.rss).
> While the pubdates seem fine they are not parsed by Rome.
>
> http://feedvalidator.org/ also claims its a valid feed... what's going
> wrong?
>
> Regards,
>
> Edwin Eversdijk
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...

From forum: Rome - Users

rss 0.91 pubdate problem

2008-09-15T04:56:48Z

I am trying to read an 0.91 rss feed (http://www.beurs.nl/rss/nieuws.rss). While the pubdates seem fine they are not parsed by Rome.

http://feedvalidator.org/ also claims its a valid feed... what's going wrong?

Regards,

Edwin Eversdijk

From forum: Rome - Users

Re: Problems with v1.0-RC1 source distribution

2008-09-08T21:40:33Z

Tom,

This has been discussed a few times in the list.

The aggreement was that parsers would ignore unknown elements for its
version without failing. If now you would have to have all parsers
parsing everything.

Still, if you want to capture all elements regardless the feed version
ROME allows you to plugin your custom parser (as you are doing now).

Alejandro

On Tue, Sep 9, 2008 at 12:43 AM, tom <tomcpierce@...> wrote:

> Hi,
>
> I did not look up which versions of RSS contain the tag as part of the
> spec. I had a feed where dates were present in the raw feed and not in
> the ROME data structures, and I patched this at a base class.
>
> I did this in keeping with my need for a parser (not a validator) and
> the 'net principle of being "conservative in what you send out, and
> liberal in what you accept".
>
> I hope you will reconsider, and at least make a liberal mode or a maybe
> a "hasQuirks" flag that gets set on non-standard feeds - it's a pain to
> keep private patchsets, and I bet I'm not the only user who strongly
> prefers a parser that does its best to capture complete information over
> one that strictly follows a spec.
>
> -tom
>
>
> Alejandro Abdelnur <tucu00@...> wrote:
>
> Tom,
>
> RSS0.90 does not have 'pubDate' elements.
>
> A
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Problems with v1.0-RC1 source distribution

2008-09-08T12:13:36Z

Hi,

I did not look up which versions of RSS contain the tag as part of the
spec. I had a feed where dates were present in the raw feed and not in
the ROME data structures, and I patched this at a base class.

I did this in keeping with my need for a parser (not a validator) and
the 'net principle of being "conservative in what you send out, and
liberal in what you accept".

I hope you will reconsider, and at least make a liberal mode or a maybe
a "hasQuirks" flag that gets set on non-standard feeds - it's a pain to
keep private patchsets, and I bet I'm not the only user who strongly
prefers a parser that does its best to capture complete information over
one that strictly follows a spec.

-tom

Alejandro Abdelnur <tucu00@...> wrote:

Tom,

RSS0.90 does not have 'pubDate' elements.

A

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: HttpClientFeedFetcher hang

2008-09-05T10:34:22Z

Added the following before calling retrieveFeed method:

System.setProperty("sun.net.client.defaultConnectTimeout",
CONNECTION_TIMEOUT);
System.setProperty("sun.net.client.defaultReadTimeout",
READ_TIMEOUT);

This works with HttpURLFeedFetcher.

From forum: Rome - Users

Re: Problems with v1.0-RC1 source distribution

2008-09-05T02:04:08Z

Tom,

RSS0.90 does not have 'pubDate' elements.

A

On Fri, Sep 5, 2008 at 2:13 AM, tom <tomcpierce@...> wrote:

> Hi,
>
> I'm just starting to use to ROME to parse some feeds, and I found that
> in certain cases I was not getting a "publish date" - even if the feed
> contained per-item "pubDate" tags.
>
> I've put together an example feed (attached) that displays this problem.
> I came across a feed with this formatting "in the wild", and I just
> trimmed out all but 2 entries and replaced the content with dummy values.
>
> I'm attaching a diff of the changes I made locally to capture these
> dates. I hope you will include them (or an equivalent patch) in future
> releases.
>
> Thanks,
> -tom
>
> diff -r -C4 rome-1.0RC1-clean/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java rome-1.0RC1/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java
> *** rome-1.0RC1-clean/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java Wed Jul 16 20:45:16 2008
> --- rome-1.0RC1/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java Thu Sep 4 15:34:22 2008
> ***************
> *** 93,100 ****
> --- 93,101 ----
> syndEntry.setUri(item.getUri());
> syndEntry.setLink(item.getLink());
> syndEntry.setTitle(item.getTitle());
> syndEntry.setLink(item.getLink());
> + syndEntry.setPublishedDate(item.getPubDate());
> return syndEntry;
> }
>
> public WireFeed createRealFeed(SyndFeed syndFeed) {
> diff -r -C4 rome-1.0RC1-clean/src/java/com/sun/syndication/io/impl/RSS090Parser.java rome-1.0RC1/src/java/com/sun/syndication/io/impl/RSS090Parser.java
> *** rome-1.0RC1-clean/src/java/com/sun/syndication/io/impl/RSS090Parser.java Wed Jul 16 20:45:16 2008
> --- rome-1.0RC1/src/java/com/sun/syndication/io/impl/RSS090Parser.java Thu Sep 4 15:33:59 2008
> ***************
> *** 285,293 ****
> if (e!=null) {
> item.setLink(e.getText());
> item.setUri(e.getText());
> }
> !
> item.setModules(parseItemModules(eItem));
>
> List foreignMarkup =
> extractForeignMarkup(eItem, item, getRSSNamespace());
> --- 285,299 ----
> if (e!=null) {
> item.setLink(e.getText());
> item.setUri(e.getText());
> }
> !
> ! e = eItem.getChild("pubDate",getRSSNamespace());
> ! if (e!=null) {
> ! item.setPubDate(DateParser.parseDate(e.getText()));
> ! }
> !
> !
> item.setModules(parseItemModules(eItem));
>
> List foreignMarkup =
> extractForeignMarkup(eItem, item, getRSSNamespace());
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: IDEA license

2008-09-05T01:51:48Z

It's an issue of concern to the Rome developers... who use the IDEA
license dedicated to Rome.

Firat Kart wrote:

> Is this ad or so? Why you discuss this on here?
>
> ------------------------------------------------------------------------
> Date: Thu, 4 Sep 2008 09:32:46 -0600
> From: mark@...
> To: dev@...
> Subject: Re: IDEA license
>
> Type: IntelliJ IDEA Open Source License
> Reference No*: (redacted)
> Date of Issue: 16 August 2007
> Expiration Date: 16 August 2008
> Number of Authorized Users: not limited
>
>
> On Thu, Sep 4, 2008 at 9:31 AM, Mark Woodman <mark@...
> <mailto:mark@...>> wrote:
>
> Yes, it expired sometime in the last couple of weeks.
>
> - Mark
>
>
>
>
> On Thu, Sep 4, 2008 at 9:16 AM, Alejandro Abdelnur
> <tucu00@... <mailto:tucu00@...>> wrote:
>
> Yes, got it early this week, it seems to be the same license, have
> yours stopped working?
>
> A
>
> On Thu, Sep 4, 2008 at 8:33 PM, Mark Woodman
> <mark@... <mailto:mark@...>> wrote:
> > Hey, did our OS license get renewed for IntelliJ?
> >
> > - Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> <mailto:dev-unsubscribe@...>
> For additional commands, e-mail: dev-help@...
> <mailto:dev-help@...>
>
>
>
>
> ------------------------------------------------------------------------
> Get more out of the Web. Learn 10 hidden secrets of Windows Live.
> Learn Now
> <http://windowslive.com/connect/post/jamiethomson.spaces.live.com-Blog-cns%21550F681DAD532637%215295.entry?ocid=TXT_TAGLM_WL_getmore_092008>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: HttpClientFeedFetcher hang

2008-09-04T15:29:34Z

Is there a new version which implemented one of the following:
1. add setter methods to HttpClientFeedFetcher
2. set default timeouts on connection and socket-read for the HttpClient in the HttpClientFeedFetcher

If not, what would be the recommended work around?

We also use HttpClient in our app for other purpose, where we explicitly configure the connection
and read timeouts. What would be the impact to it if we take the setting system property approach?

From forum: Rome - Users

RE: IDEA license

2008-09-04T15:13:50Z

Is this ad or so? Why you discuss this on here?

Date: Thu, 4 Sep 2008 09:32:46 -0600
From: mark@...
To: dev@...
Subject: Re: IDEA license

Type: IntelliJ IDEA Open Source License
Reference No*: (redacted)
Date of Issue: 16 August 2007
Expiration Date: 16 August 2008
Number of Authorized Users: not limited

On Thu, Sep 4, 2008 at 9:31 AM, Mark Woodman <mark@...> wrote:

Yes, it expired sometime in the last couple of weeks.

- Mark

On Thu, Sep 4, 2008 at 9:16 AM, Alejandro Abdelnur <tucu00@...> wrote:
Yes, got it early this week, it seems to be the same license, have
yours stopped working?

A

On Thu, Sep 4, 2008 at 8:33 PM, Mark Woodman <mark@...> wrote:
> Hey, did our OS license get renewed for IntelliJ?
>
> - Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

Get more out of the Web. Learn 10 hidden secrets of Windows Live. Learn Now

From forum: Rome - Development

HttpClientFeedFetcher hang

2008-09-04T14:57:06Z

We have been using the RomeFetcher in our servlet based web portal application
for just a few months. Here is the issue we have run into -
the HttpClientFeedFetcher just kept waiting when a target service is hanging.
What is the default timeout on a socket read for the HttpClient?
Is there a way to configure it?
Thanks!

From forum: Rome - Users

Problems with v1.0-RC1 source distribution

2008-09-04T13:43:58Z

Hi,

I'm just starting to use to ROME to parse some feeds, and I found that
in certain cases I was not getting a "publish date" - even if the feed
contained per-item "pubDate" tags.

I've put together an example feed (attached) that displays this problem.
I came across a feed with this formatting "in the wild", and I just
trimmed out all but 2 entries and replaced the content with dummy values.

I'm attaching a diff of the changes I made locally to capture these
dates. I hope you will include them (or an equivalent patch) in future
releases.

Thanks,
-tom

<?xml version="1.0" encoding="UTF-8" ?>
<rss version="0.91">
<channel>
<title>this is a title</title>
<link>http://www.example.com</link>
<description>this is a description</description>
<language>en-us</language>
<ttl>15</ttl>
<docs>http://www.example.com/content/page.html</docs>
<image>
<title>Example.com</title>
<url>http://www.example.com/logo.gif</url>
<link>http://www.example.com</link>
<description>RSS Feed from Example.com</description>
</image>
<pubDate>Wed, 03 Sep 2008 13:23:13 -0700</pubDate>
<copyright>Copyright 2008 ExampleCo, Inc.</copyright>
<item>
<title>entry 1 title</title>
<link>http://www.example.com/entry/53425</link>
<description><![CDATA[<p>This description is an HTML blob</p>]]></description>
<author>someone@...</author>
<pubDate>Wed, 03 Sep 2008 13:23:13 -0700</pubDate>
<guid>http://www.example.com/entry/53425</guid>
</item>
<item>
<title>entry 2 title</title>
<link>http://www.example.com/entry/76364</link>
<description><![CDATA[<p>This description is also an HTML blob</p>]]></description>
<author>someone@...</author>
<pubDate>Wed, 03 Sep 2008 15:32:23 -0700</pubDate>
<guid>http://www.example.com/entry/76364</guid>
</item>
</channel>
</rss>

diff -r -C4 rome-1.0RC1-clean/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java rome-1.0RC1/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java
*** rome-1.0RC1-clean/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java Wed Jul 16 20:45:16 2008
--- rome-1.0RC1/src/java/com/sun/syndication/feed/synd/impl/ConverterForRSS090.java Thu Sep 4 15:34:22 2008
***************
*** 93,100 ****
--- 93,101 ----
syndEntry.setUri(item.getUri());
syndEntry.setLink(item.getLink());
syndEntry.setTitle(item.getTitle());
syndEntry.setLink(item.getLink());
+ syndEntry.setPublishedDate(item.getPubDate());
return syndEntry;
}

public WireFeed createRealFeed(SyndFeed syndFeed) {
diff -r -C4 rome-1.0RC1-clean/src/java/com/sun/syndication/io/impl/RSS090Parser.java rome-1.0RC1/src/java/com/sun/syndication/io/impl/RSS090Parser.java
*** rome-1.0RC1-clean/src/java/com/sun/syndication/io/impl/RSS090Parser.java Wed Jul 16 20:45:16 2008
--- rome-1.0RC1/src/java/com/sun/syndication/io/impl/RSS090Parser.java Thu Sep 4 15:33:59 2008
***************
*** 285,293 ****
if (e!=null) {
item.setLink(e.getText());
item.setUri(e.getText());
}
!
item.setModules(parseItemModules(eItem));

List foreignMarkup =
extractForeignMarkup(eItem, item, getRSSNamespace());
--- 285,299 ----
if (e!=null) {
item.setLink(e.getText());
item.setUri(e.getText());
}
!
! e = eItem.getChild("pubDate",getRSSNamespace());
! if (e!=null) {
! item.setPubDate(DateParser.parseDate(e.getText()));
! }
!
!
item.setModules(parseItemModules(eItem));

List foreignMarkup =
extractForeignMarkup(eItem, item, getRSSNamespace());

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: IDEA license

2008-09-04T08:32:46Z

Type: IntelliJ IDEA Open Source License
Reference No*: (redacted)
Date of Issue: 16 August 2007
Expiration Date: 16 August 2008
Number of Authorized Users: not limited

On Thu, Sep 4, 2008 at 9:31 AM, Mark Woodman <mark@...> wrote:

Yes, it expired sometime in the last couple of weeks.

- Mark

On Thu, Sep 4, 2008 at 9:16 AM, Alejandro Abdelnur <tucu00@...> wrote:
Yes, got it early this week, it seems to be the same license, have
yours stopped working?

A

On Thu, Sep 4, 2008 at 8:33 PM, Mark Woodman <mark@...> wrote:
> Hey, did our OS license get renewed for IntelliJ?
>
> - Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: IDEA license

2008-09-04T08:31:36Z

Yes, it expired sometime in the last couple of weeks.

- Mark

On Thu, Sep 4, 2008 at 9:16 AM, Alejandro Abdelnur <tucu00@...> wrote:

Yes, got it early this week, it seems to be the same license, have
yours stopped working?

A

On Thu, Sep 4, 2008 at 8:33 PM, Mark Woodman <mark@...> wrote:
> Hey, did our OS license get renewed for IntelliJ?
>
> - Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

Re: IDEA license

2008-09-04T08:16:08Z

Yes, got it early this week, it seems to be the same license, have
yours stopped working?

A

On Thu, Sep 4, 2008 at 8:33 PM, Mark Woodman <mark@...> wrote:
> Hey, did our OS license get renewed for IntelliJ?
>
> - Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

From forum: Rome - Development

IDEA license

2008-09-04T08:03:39Z

Hey, did our OS license get renewed for IntelliJ?

- Mark

From forum: Rome - Development

Re: XMLReader mods

2008-09-03T21:07:57Z

Excellent! Everything looks great :-)

Thanks much!

Jake

Alejandro Abdelnur wrote:

> Jacob,
>
> Finally I've made myself some time for this.
>
> I've just added a new constructor to XmlReader
>
> public XmlReader(InputStream is, boolean lenient, String defaultEncoding)
>
> I've also made the typo corrections you've indicated.
>
> Thanks.
>
> Alejandro
>
>
> On Sun, Apr 13, 2008 at 4:45 AM, Jacob Kjome <hoju@...> wrote:
>> I see you are looking for comments prior to a new release. So, will this
>> issue (see your - Alejandro - comment below) be addressed before a new
>> release?
>>
>> You can see the changes I've made to my own version, which is synced to the
>> 1.18 (latest) version of XMLReader in Rome...
>>
>> http://cvs.forge.objectweb.org/cgi-bin/viewcvs.cgi/xmlc/xmlc/xmlc/modules/xmlc/src/org/enhydra/xml/io/XmlReader.java
>>
>>
>> Jake
>>
>> Jacob Kjome wrote:
>>> At 02:43 AM 6/27/2007, you wrote:
>>> >MMhhh, let me see if I can refactor the constructors so you can reuse
>>> >the current one with content-type=NULL.
>>> >
>>>
>>> Any chance you will get around to this soon?
>>>
>>> Jake
>>>
>>> >On 6/24/07, Jacob Kjome <hoju@...> wrote:
>>> >>
>>> >> Hi Alejandro,
>>> >>
>>> >> I just took a look at the latest changes in XMLReader and noticed
>>> >> that you only added a new constructor for creating "a Reader using an
>>> >> InputStream and the associated content-type header", but not for
>>> >> creating "a Reader for a raw InputStream". For my purposes, I'd use
>>> >> the latter, except it doesn't exist. I added it to my own version,
>>> >> but figure that if it's useful to me it's probably useful to others
>>> >> and may as well be in the official version of XMLReader. Thoughts?
>>> >>
>>> >> BTW, you didn't add a javadoc "@param" entry for defaultEncoding and
>>> >> the javadoc for constructors taking a boolean "lenient" parameter
>>> >> probably shouldn't state that "this constructor is lenient regarding
>>> >> the encoding detection", since it depends on what the user passes to
>>> >> the constructor. There's also a few javadoc spelling errors, such as
>>> >> "an" instead of "and". No big deal, but I thought I'd mention it.
>>> >>
>>> >> All in all, great stuff!
>>> >>
>>> >> Jake
>>> >>
>>> >> At 12:27 AM 6/2/2007, you wrote:
>>> >> >
>>> >> >Thanks for addressing the issues and for the explanations!
>>> >> >
>>> >> >Jake
>>> >> >
>>> >> >At 09:47 AM 6/1/2007, you wrote:
>>> >> > >Jacob,
>>> >> > >
>>> >> > >This got lost in my inbox, while working on the XmlReader I ran
>>> across
>>> >> > >it. Sorry for the delay.
>>> >> > >
>>> >> > >On your comment on line #390, you are right it should be bomEnc.
>>> >> > >
>>> >> > >On your comment on line #425, is US_ASCII (HTTP content type
>>> declares
>>> >> > >a MIME of text type and XML sub-type. There is not HTTP
>>> Content-type
>>> >> > >charset encoding information. The charset encoding is US-ASCII.
>>> Refer
>>> >> > >to RFC 3023 Section 3.1. Text/xml Registration.)
>>> >> > >
>>> >> > >On having default encoding per instance, keeping backwards
>>> >> > >compatibility we can add a constructor that takes an instance
>>> default
>>> >> > >encoding. All other constructors would use the static default
>>> >> > >encoding.
>>> >> > >
>>> >> > >A
>>> >> > >
>>> >> > >
>>> >> > >On 5/16/07, Jacob Kjome <hoju@...> wrote:
>>> >> > >>
>>> >> > >> Maybe the 3rd time's the charm? I saw there was an update to
>>> >> > >> XMLReader so I thought I'd remind Rome developers of my 1.14
>>> >> > >> findings. They are still entirely relevant. Please pay special
>>> >> > >> attention to the possible bugs I pointed out. I would hope
>>> you'd be
>>> >> > >> interested in them. If you think I'm out to lunch, please say
>>> >> > >> so. Otherwise, I think these are things that ought to be
>>> addressed
>>> >> > >> rather than ignored. You can read below or view the whole
>>> thread in
>>> >> > >> the archives....
>>> >> > >>
>>> >> > >>
>>> https://rome.dev.java.net/servlets/ReadMsg?listName=users&msgNo=1251
>>> >> > >>
>>> >> > >>
>>> >> > >> Jake
>>> >> > >>
>>> >> > >> At 01:20 AM 3/9/2007, you wrote:
>>> >> > >> >
>>> >> > >> >Now that there's a bit more activity on the Rome list, any
>>> comments
>>> >> > >> >on my email from a few weeks ago? See below...
>>> >> > >> >
>>> >> > >> >Jake
>>> >> > >> >
>>> >> > >> >At 07:16 PM 2/17/2007, you wrote:
>>> >> > >> > >
>>> >> > >> > >I tried sending this directly to the Rome developers a
>>> couple weeks
>>> >> > >> > >ago, but received no response. So, I finally signed up for
>>> a
>>> >> > >> > >dev.java.net account to see if I would get a response on
>>> >the official
>>> >> > >> > >list. Here's what I wrote.....
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >My name is Jacob Kjome and I'm the maintainer of the XMLC
>>> >project [1]
>>> >> > >> > >where we use a modified version of your XMLReader [2]. I
>>> >modified it
>>> >> > >> > >to use gnu-regexp, since that's what XMLC uses for Regex
>>> >and it also
>>> >> > >> > >allows the class to be used in JDK's previous to 1.4.
>>> >Anyway, that's
>>> >> > >> > >the background.
>>> >> > >> > >
>>> >> > >> > >I've been trying to keep things in sync with your version,
>>> >so I look
>>> >> > >> > >at Rome's version every once in a while to see what's
>>> changed. The
>>> >> > >> > >last few changes have been fine. But this 1.14 change seems
>>> odd to
>>> >> > >> > >me (with at least one reasonably clear bug, explained
>>> below). It
>>> >> > >> > >provides for setting a static default encoding.
>>> >Interestingly, I had
>>> >> > >> > >noticed this lack of a user-defined-default deficiency
>>> >early on. In
>>> >> > >> > >XMLC's version, I added the ability to pass a custom
>>> >default encoding
>>> >> > >> > >into a couple of the constructors, with an internal pre-set
>>> default
>>> >> > >> > >of "UTF-8" if the default passed to the constructor is
>>> >> > >> > >null. Effectively, this provides the same functionality as
>>> you've
>>> >> > >> > >added. However, the fact that XMLC's version provides
>>> per-instance
>>> >> > >> > >encoding defaulting makes it more flexible, as the
>>> >preferred default
>>> >> > >> > >value may change from use-to-use. Granted, this means more
>>> >> > >> > >constructor arguments (for 2 constructors) and passing
>>> around the
>>> >> > >> > >values to the internal static methods, but the flexibility
>>> is worth
>>> >> > >> > >it and necessary in my use-case.
>>> >> > >> > >
>>> >> > >> > >I'm not telling you that you have to change because of my
>>> needs. I
>>> >> > >> > >will always use a separate copy because of my need to use
>>> >gnu-regexp
>>> >> > >> > >instead of JDK1.4 regex. But it makes life easier if the
>>> >differences
>>> >> > >> > >between XMLC's version and Rome's version are kept to a
>>> >minimum so I
>>> >> > >> > >can keep up with additions and bug fixes easily. I figure
>>> if I can
>>> >> > >> > >convince you to do it the way I've done it, it will make my
>>> life
>>> >> > >> > >easier and maybe, if you agree with the way I've implemented
>>> it,
>>> >> > >> > >benefit the Rome project at the same time. So, if you could
>>> take a
>>> >> > >> > >moment to review the latest version of XMLC's XMLReader [2]
>>> and
>>> >> > >> > >compare it against Rome's latest version, that would be
>>> >great. I've
>>> >> > >> > >made every attempt to keep white-space formatting in-line
>>> >with Rome's
>>> >> > >> > >version, so a simple diff should provide you with a clean
>>> and clear
>>> >> > >> > >look at the important differences between our versions.
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >Additionally, it appears that you've introduced at least one
>>> bug in
>>> >> > >> > >the latest 1.14 version. Take a look at line #390.
>>> >> > >> > >
>>> >> > >> > >It currently is...
>>> >> > >> > > encoding = (_defaultEncoding == null) ? UTF_8 :
>>> >> > >> >_defaultEncoding;
>>> >> > >> > >
>>> >> > >> > >I think it should be....
>>> >> > >> > > encoding = bomEnc;
>>> >> > >> > >
>>> >> > >> > >You've already checked that "bomEnc" is equal to "UTF-8".
>>> >Why would
>>> >> > >> > >you then apply a default encoding rather than "bomEnc"?
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >I have more of a question on line #425. Wouldn't defaulting
>>> to
>>> >> > >> > >"US-ASCII" be better than a static default, which would more
>>> than
>>> >> > >> > >likely be "UTF-8"? While XMLC's XMLReader uses the
>>> >default encoding
>>> >> > >> > >in most other applicable places, it leaves this one alone.
>>> I'm not
>>> >> > >> > >100% sure what the most appropriate choice is here, but I
>>> >lean toward
>>> >> > >> > >"XMLReader knows better than the user providing the
>>> >default" in this
>>> >> > >> > >case where I defer to the user in all other cases where I
>>> need a
>>> >> > >> > >default. I appreciate any advice you provide.
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >There's also a possible pre-existing bug. Right after line
>>> #502,
>>> >> > >> > >shouldn't the bytes be unread just as they are on lines
>>> #493, #498,
>>> >> > >> > >and #506? I'm not sure about this one? I defer to your
>>> expertise,
>>> >> > >> > >but I thought I'd point it out just in case you just hadn't
>>> >> noticed it.
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >[1] http://forge.objectweb.org/projects/xmlc/
>>> >> > >> > >OR http://www.enhydra.org/tech/xmlc/
>>> >> > >> > >[2]
>>> >> > >>
>>> >> >
>>> >http://cvs.xmlc.forge.objectweb.org/cgi-bin/viewcvs.cgi/xmlc/xmlc/xmlc
>>> >> > >> > >/modules/xmlc/src/org/enhydra/xml/io/XmlReader.java
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >Jake
>>> >> > >> > >
>>> >> > >> >
>>> >>---------------------------------------------------------------------
>>> >> > >> > >To unsubscribe, e-mail: users-unsubscribe@...
>>> >> > >> > >For additional commands, e-mail:
>>> users-help@...
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> > >
>>> >> > >> >
>>> >> > >>
>>> >---------------------------------------------------------------------
>>> >> > >> >To unsubscribe, e-mail: users-unsubscribe@...
>>> >> > >> >For additional commands, e-mail: users-help@...
>>> >> > >> >
>>> >> > >> >
>>> >> > >> >
>>> >> > >> >
>>> >> > >>
>>> >> > >>
>>> ---------------------------------------------------------------------
>>> >> > >> To unsubscribe, e-mail: users-unsubscribe@...
>>> >> > >> For additional commands, e-mail: users-help@...
>>> >> > >>
>>> >> > >>
>>> >> > >
>>> >> >
>>> >---------------------------------------------------------------------
>>> >> > >To unsubscribe, e-mail: users-unsubscribe@...
>>> >> > >For additional commands, e-mail: users-help@...
>>> >> > >
>>> >> > >
>>> >> > >
>>> >> > >
>>> >> >
>>> >>
>>> >---------------------------------------------------------------------
>>> >> >To unsubscribe, e-mail: users-unsubscribe@...
>>> >> >For additional commands, e-mail: users-help@...
>>> >> >
>>> >> >
>>> >> >
>>> >> >
>>> >> >
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: users-unsubscribe@...
>>> >> For additional commands, e-mail: users-help@...
>>> >>
>>> >>
>>> >
>>> >---------------------------------------------------------------------
>>> >To unsubscribe, e-mail: users-unsubscribe@...
>>> >For additional commands, e-mail: users-help@...
>>> >
>>> >
>>> >
>>> >
>>> >
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@...
>>> For additional commands, e-mail: users-help@...
>>>
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@...
>> For additional commands, e-mail: users-help@...
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@...
> For additional commands, e-mail: users-help@...
>
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@...
For additional commands, e-mail: users-help@...

From forum: Rome - Users