Repast S: Bug in 2D-Layouts

[Sascha Holzhauer]

Hello,

a little surprisingly to me, I guess I found a meaningful bug in the
2D-Layout classes

KKLayout2D
FRLayout2D
ISOMLayout2D.

These layouts require some iterations to compute the vertices' location.
However, the step() method which is implemented in the JUNG layouts the
above mentioned classes are wrappers for is never invoked by Repast
Simphony. Consequently, the layouts initialize the location by help of a
RandomLocationTransformer as it says randomly and never update the
positions.

I suggest adding this code into the setLayout() methods, adapted to the
layouts:

        while (!((KKLayout<T, RepastEdge<T>>)layout).done()) {
            ((KKLayout<T, RepastEdge<T>>)layout).step();
        }

Kind regards,
Sascha Holzhauer

--
:::: Sascha Holzhauer ::::
     Grüne Straße 25
     34323 Malsfeld-Beiseförth, Germany
         [phone]
         [phone] (D2)


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Repast-interest mailing list
Repast-interest@...
https://lists.sourceforge.net/lists/listinfo/repast-interest

[Tatara, Eric R.]

Thanks Sascha.  I implemented the change you suggested and verified that it works correctly.  We changed the Jung libraries between the alpha and 1.0 release, and probably this just got overlooked.

eric


Eric Tatara, Ph.D.
Assistant Software Engineer
Center for Complex Adaptive Agent Systems Simulation
Decision and Information Sciences Division
Argonne National Laboratory

-----Original Message-----
From: repast-interest-bounces@... [mailto:repast-interest-bounces@...] On Behalf Of Sascha Holzhauer
Sent: Sunday, June 22, 2008 10:31 AM
To: repast-interest@...
Subject: [Repast-interest] Repast S: Bug in 2D-Layouts

Hello,

a little surprisingly to me, I guess I found a meaningful bug in the 2D-Layout classes

KKLayout2D
FRLayout2D
ISOMLayout2D.

These layouts require some iterations to compute the vertices' location.
However, the step() method which is implemented in the JUNG layouts the above mentioned classes are wrappers for is never invoked by Repast Simphony. Consequently, the layouts initialize the location by help of a RandomLocationTransformer as it says randomly and never update the positions.

I suggest adding this code into the setLayout() methods, adapted to the
layouts:

        while (!((KKLayout<T, RepastEdge<T>>)layout).done()) {
            ((KKLayout<T, RepastEdge<T>>)layout).step();
        }

Kind regards,
Sascha Holzhauer

--
:::: Sascha Holzhauer ::::
     Grüne Straße 25
     34323 Malsfeld-Beiseförth, Germany
         [phone]
         [phone] (D2)


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Repast-interest mailing list
Repast-interest@...
https://lists.sourceforge.net/lists/listinfo/repast-interest

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Repast-interest mailing list
Repast-interest@...
https://lists.sourceforge.net/lists/listinfo/repast-interest