Remark boxes {initially: Tikiwiki-cvs/svn] SF.net SVN: tikiwiki: [13415] branches/1.10}

View: New views
1 Messages — Rating Filter:   Alert me  

Parent Message unknown Remark boxes {initially: Tikiwiki-cvs/svn] SF.net SVN: tikiwiki: [13415] branches/1.10}

by Jonny Bradley :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


[sorry this mail goes on a bit, but what seemed a simple question... well,
you'll see]

I was just about to have a go at these rboxes - "name" is not a valid
attribute for a DIV in XHTML 1.0 Transitional so breaks a lot of pages (all
admin ones though).

The CSS files refer to these using "[name="tip"]" etc - doesn't that cause
issues with old IE? Was this feature done like this for a good reason - like
some sort of browser hack? It seems to have appeared in version 1.8.6 which
was a while ago - i guess pre XHTML?

It seems to be in 72 templates and 15 css files so it's not a trivial
change, but as it makes a lot of pages invalid it should be addressed (i
think).

Any ideas/suggestions/warnings? ;)

Options as i see it would be...

    Just add the "remark type" to the class:
        e.g. <div class="rbox-data highlight warning">
and split up the CSS definitions which would make it difficult/impossible to
control the title and data separately for each type, but would be quite easy
to implement.

or (better)
    Make the container DIV class=warning etc
        e.g. <div class="rbox warning">
so then a definition that was '.rbox-title[name="warning"]' would become
'.warning .rbox-title'

At the same time i would add a dummy <span> tag around the (title) text so
the CSS file can replace it with an image (see http://csszengarden.com/ for
more)

Also making this into a Smarty entity would seem to make a lot of sense...
i'll look into how to do it.

...or, is no one that bothered (for 1.10)?

Hoping for some input...

jonny B



on 2/7/08 17:27, Jyhem@... at Jyhem@...
wrote:

> <div class="rbox-data highlight" name="warning">{icon _id=information
> style="vertical-align:middle;align=left"} {tr}Your message has been queued for
> approval, the message will be posted after a moderator approves it.{/tr}

> </div>




-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
Tikiwiki-devel mailing list
Tikiwiki-devel@...
https://lists.sourceforge.net/lists/listinfo/tikiwiki-devel
LightInTheBox - Buy quality products at wholesale price