Re: svn commit: r674186 - in /httpcomponents/httpclient/tru
|
View:
New views
3 Messages
—
Rating Filter:
Alert me
|
 |
|
|
|
Re: svn commit: r674186
by olegk
::
Rate this Message:
On Sat, 2008-07-05 at 13:29 +0100, sebb wrote:
> On 05/07/2008, olegk@... <olegk@...> wrote: > > Author: olegk > > Date: Sat Jul 5 05:18:54 2008 > > New Revision: 674186 > > ... > > > > Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java > > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java?rev=674186&r1=674185&r2=674186&view=diff > > ============================================================================== > > --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java (original) > > +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java Sat Jul 5 05:18:54 2008 > > @@ -76,18 +76,5 @@ > > return this.route; > > } > > > > - > > - /* * > > - * Indicates whether this reference is still valid. > > - * > > - * @return <code>true</code> if the pool entry is still referenced, > > - * <code>false</code> otherwise > > - * / > > - public final boolean isValid() { > > - //@@@ better sematics: allow explicit invalidation > > - return (super.get() != null); > > - } > > - */ > > - > > Was the removal of that method intentional? > > It's not mentioned in the log message... > Sebastian, This method was commented out. I thought it was pointless to keep it. Oleg > > } // class BasicPoolEntryRef > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@... > For additional commands, e-mail: dev-help@... > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
|
|
Re: svn commit: r674186
by sebb-2-2
::
Rate this Message:
On 05/07/2008, Oleg Kalnichevski <olegk@...> wrote:
> On Sat, 2008-07-05 at 13:29 +0100, sebb wrote: > > On 05/07/2008, olegk@... <olegk@...> wrote: > > > Author: olegk > > > Date: Sat Jul 5 05:18:54 2008 > > > New Revision: 674186 > > > > > ... > > > > > > > Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java > > > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java?rev=674186&r1=674185&r2=674186&view=diff > > > ============================================================================== > > > --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java (original) > > > +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/BasicPoolEntryRef.java Sat Jul 5 05:18:54 2008 > > > @@ -76,18 +76,5 @@ > > > return this.route; > > > } > > > > > > - > > > - /* * > > > - * Indicates whether this reference is still valid. > > > - * > > > - * @return <code>true</code> if the pool entry is still referenced, > > > - * <code>false</code> otherwise > > > - * / > > > - public final boolean isValid() { > > > - //@@@ better sematics: allow explicit invalidation > > > - return (super.get() != null); > > > - } > > > - */ > > > - > > > > Was the removal of that method intentional? > > > > It's not mentioned in the log message... > > > > Sebastian, > > This method was commented out. I thought it was pointless to keep it. Sorry, my mistake. I'd not noticed the subtle commenting out. > Oleg > > > > > > } // class BasicPoolEntryRef > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscribe@... > > For additional commands, e-mail: dev-help@... > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@... > For additional commands, e-mail: dev-help@... > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@... For additional commands, e-mail: dev-help@... |
| Free Forum Powered by Nabble | Forum Help |