Re: svn commit: r669927 - in /apr/apr/trunk: build/buildcheck.sh configure.in

[Roy T. Fielding]

-1.  That breaks the build for all maintainers using OS X 10.4.x and
I don't see any reason to require it.

% which autoconf
/usr/bin/autoconf
% autoconf --version
autoconf (GNU Autoconf) 2.59

....Roy


On Jun 20, 2008, at 5:01 PM, wrowe@... wrote:

> Author: wrowe
> Date: Fri Jun 20 08:01:12 2008
> New Revision: 669927
>
> URL: http://svn.apache.org/viewvc?rev=669927&view=rev
> Log:
> Autoconf 2.60's 2nd birthday this coming thursday.  As this
> is for maintainers, it's time to bump.
>
> Modified:
>     apr/apr/trunk/build/buildcheck.sh
>     apr/apr/trunk/configure.in
>
> Modified: apr/apr/trunk/build/buildcheck.sh
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/buildcheck.sh?
> rev=669927&r1=669926&r2=669927&view=diff
> ======================================================================
> ========
> --- apr/apr/trunk/build/buildcheck.sh (original)
> +++ apr/apr/trunk/build/buildcheck.sh Fri Jun 20 08:01:12 2008
> @@ -14,18 +14,18 @@
>  echo "buildconf: python version $py_version (ok)"
>  fi
>
> -# autoconf 2.50 or newer
> +# autoconf 2.60 or newer
>  ac_version=`${AUTOCONF:-autoconf} --version 2>/dev/null|sed -e 's/^
> [^0-9]*//;s/[a-z]* *$//;q'`
>  if test -z "$ac_version"; then
>  echo "buildconf: autoconf not found."
> -echo "           You need autoconf version 2.50 or newer installed"
> +echo "           You need autoconf version 2.60 or newer installed"
>  echo "           to build APR from SVN."
>  exit 1
>  fi
>  IFS=.; set $ac_version; IFS=' '
> -if test "$1" = "2" -a "$2" -lt "50" || test "$1" -lt "2"; then
> +if test "$1" = "2" -a "$2" -lt "60" || test "$1" -lt "2"; then
>  echo "buildconf: autoconf version $ac_version found."
> -echo "           You need autoconf version 2.50 or newer installed"
> +echo "           You need autoconf version 2.60 or newer installed"
>  echo "           to build APR from SVN."
>  exit 1
>  else
>
> Modified: apr/apr/trunk/configure.in
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/configure.in?
> rev=669927&r1=669926&r2=669927&view=diff
> ======================================================================
> ========
> --- apr/apr/trunk/configure.in (original)
> +++ apr/apr/trunk/configure.in Fri Jun 20 08:01:12 2008
> @@ -139,9 +139,8 @@
>  AC_CHECK_TOOL(AR, ar, ar)
>
>  dnl Various OS checks that apparently set required flags
> -AC_AIX
> +AC_USE_SYSTEM_EXTENSIONS
>  AC_ISC_POSIX
> -AC_MINIX
>
>  APR_EBCDIC
>
>
>

[William A. Rowe, Jr.]

Roy T. Fielding wrote:
> -1.  That breaks the build for all maintainers using OS X 10.4.x and
> I don't see any reason to require it.
>
> % which autoconf
> /usr/bin/autoconf
> % autoconf --version
> autoconf (GNU Autoconf) 2.59

We have 2 choices.

/usr/bin/autoconf --version
autoconf (GNU Autoconf) 2.61
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software.  You may redistribute copies of it under the terms of
the GNU General Public License <http://www.gnu.org/licenses/gpl.html>.
There is NO WARRANTY, to the extent permitted by law.

this is the flavor I've used for a very long time to package apr, httpd
for the projects.  It worked fine.

Unfortunately in 2.62 autoconf maintainers reorganized

  dnl Various OS checks that apparently set required flags
-AC_AIX
+AC_USE_SYSTEM_EXTENSIONS
  AC_ISC_POSIX
-AC_MINIX

_AIX and _MINIX are deprecated, and part of AC_USE_SYSTEM_EXTENSIONS
since 2.60.  AC_USE_SYSTEM_EXTENSIONS does not exist in 2.59 and prior.

see both
http://www.gnu.org/software/automake/manual/autoconf/Obsolete-Macros.html
http://www.gnu.org/software/automake/manual/autoconf/Posix-Variants.html#AC%5fUSE%5fSYSTEM%5fEXTENSIONS

Now, these two of a some five potentially interesting toggles were respected
in autoconf 2.62.  Now, without the patch above, ./autoconf emits the error;

$ svn diff -r prev configure.in | patch -p0 -R
patching file configure.in
[wrowe@s170 apr-1.x]$ ./buildconf
buildconf: checking installation...
buildconf: python version 2.5.1 (ok)
buildconf: autoconf version 2.62 (ok)
buildconf: libtool version 1.5.26 (ok)
Copying libtool helper files ...
buildconf: Using libtool.m4 at /usr/local/share/aclocal/libtool.m4.
Creating include/arch/unix/apr_private.h.in ...
configure.in:144: warning: AC_COMPILE_IFELSE was called before
AC_USE_SYSTEM_EXTENSIONS
../../lib/autoconf/specific.m4:385: AC_USE_SYSTEM_EXTENSIONS is expanded from...
../../lib/autoconf/specific.m4:456: AC_MINIX is expanded from...
configure.in:144: the top level
configure.in:144: warning: AC_RUN_IFELSE was called before
AC_USE_SYSTEM_EXTENSIONS
Creating configure ...
configure.in:144: warning: AC_COMPILE_IFELSE was called before
AC_USE_SYSTEM_EXTENSIONS
../../lib/autoconf/specific.m4:385: AC_USE_SYSTEM_EXTENSIONS is expanded from...
../../lib/autoconf/specific.m4:456: AC_MINIX is expanded from...
configure.in:144: the top level
configure.in:144: warning: AC_RUN_IFELSE was called before
AC_USE_SYSTEM_EXTENSIONS
Generating 'make' outputs ...
rebuilding rpm spec file

I'm unsure if we want to tolerate this warning to maintainers, but unlike
all of the other patches I just committed, this patch does not affect the
run time ./configure user.  So I'll listen to a day or two of feedback and
either let you be convinced, or agree we should back this out.

Bill

[Justin Erenkrantz]

On Fri, Jun 20, 2008 at 8:58 AM, William A. Rowe, Jr.
<wrowe@...> wrote:
>  dnl Various OS checks that apparently set required flags
> -AC_AIX
> +AC_USE_SYSTEM_EXTENSIONS
>  AC_ISC_POSIX
> -AC_MINIX

Isn't it possible to do some m4 conditionals based on the autoconf
version instead?  Not as clean, but it won't force our developers to
upgrade to 2.6x.  I think it'd be something close to:

ifelse(regexp(AC_ACVERSION, 2\.6), -1, [
AC_AIX
AC_MINIX],[
AC_USE_SYSTEM_EXTENSIONS
])

HTH.  -- justin

[Arfrever Frehtes Taifersar Arahesis-2]

2008-06-20 18:59:26 Justin Erenkrantz napisał(a):

> On Fri, Jun 20, 2008 at 8:58 AM, William A. Rowe, Jr.
> <wrowe@...> wrote:
> >  dnl Various OS checks that apparently set required flags
> > -AC_AIX
> > +AC_USE_SYSTEM_EXTENSIONS
> >  AC_ISC_POSIX
> > -AC_MINIX
>
> Isn't it possible to do some m4 conditionals based on the autoconf
> version instead?  Not as clean, but it won't force our developers to
> upgrade to 2.6x.  I think it'd be something close to:
>
> ifelse(regexp(AC_ACVERSION, 2\.6), -1, [
> AC_AIX
> AC_MINIX],[
> AC_USE_SYSTEM_EXTENSIONS
> ])

'ifdef' would be better:

ifdef([AC_USE_SYSTEM_EXTENSIONS], [AC_USE_SYSTEM_EXTENSIONS], [
AC_AIX
AC_MINIX
])

--
Arfrever Frehtes Taifersar Arahesis

[William A. Rowe, Jr.]

Arfrever Frehtes Taifersar Arahesis wrote:
>
> 'ifdef' would be better:
>
> ifdef([AC_USE_SYSTEM_EXTENSIONS], [AC_USE_SYSTEM_EXTENSIONS], [
> AC_AIX
> AC_MINIX
> ])

+1, committed, please review.