Re: svn commit: r655573 - in /jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi: WorkspaceManager.java name/NamespaceCache.java name/NamespaceRegistryImpl.java

[Marcel Reutegger]

Hi Jukka,

please note that NamespaceCache is not about caching namespace mappings in a
session, but caching the mapping on a repository service level.

see: https://issues.apache.org/jira/browse/JCR-1020

it was an attempt to reduce the cost of creating a session and to reduce the
amount of redundant information that is transfered to a client.

regards
  marcel

jukka@... wrote:

> Author: jukka
> Date: Mon May 12 10:32:25 2008
> New Revision: 655573
>
> URL: http://svn.apache.org/viewvc?rev=655573&view=rev
> Log:
> JCR-1564: JSR 283 namespace handling
>     - Removed caching and listening of namespace registry in jcr2spi
>       as AbstractSession already caches namespaces and JSR 283 removes
>       the need to notify sessions about global namespace remappings
>
> Removed:
>     jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/name/NamespaceCache.java
> Modified:
>     jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/WorkspaceManager.java
>     jackrabbit/trunk/jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/name/NamespaceRegistryImpl.java

[Jukka Zitting]

Hi,

On Tue, May 13, 2008 at 1:07 PM, Marcel Reutegger
<marcel.reutegger@...> wrote:
> please note that NamespaceCache is not about caching namespace mappings in
> a session, but caching the mapping on a repository service level.
>
>  see: https://issues.apache.org/jira/browse/JCR-1020
>
> it was an attempt to reduce the cost of creating a session and to reduce
> the amount of redundant information that is transfered to a client.

Shouldn't that be a concern of a remoting layer instead of jcr2spi?

BR,

Jukka Zitting

[Angela Schreiber]

just for the record:

jukka, marcel and myself discussed the 2 threads yesterday
in basel and reached consensus as follows:

- keep a namespace caching in jcr2spi but replace the
   NamespaceCache by a simple map, that gets cleared
   if necessary.
- make jcr2spi and core use the same NamespaceRegistry
   with different storage impls.
- reintroduce the NamespaceStorage
- we didn't decide in which project the latter is going
   to live. spi-commons was one possibility discussed.
- jukka volunteered to provide a patch to have something
   concrete to look at.

regards
angela