Re: svn commit: r652849 - /labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java

[Gerolf Seitz]

Hi Bernd,

what java version do you use?
I'm on JDK 1.6_10, which seems to have no problems with the
@Override for methods specified in an interface.

  Gerolf

On Fri, May 2, 2008 at 7:56 PM, <berndf@...> wrote:

> Author: berndf
> Date: Fri May  2 10:56:05 2008
> New Revision: 652849
>
> URL: http://svn.apache.org/viewvc?rev=652849&view=rev
> Log:
> [vysper] fix compile-time error
>
> Modified:
>
>  labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
>
> Modified:
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> URL:
> http://svn.apache.org/viewvc/labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java?rev=652849&r1=652848&r2=652849&view=diff
>
> ==============================================================================
> ---
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> (original)
> +++
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> Fri May  2 10:56:05 2008
> @@ -109,7 +109,6 @@
>         return
> getServerRuntimeContext().getResourceRegistry().bindSession(this);
>     }
>
> -    @Override
>     public String nextSequenceValue() {
>        return sequence.create();
>     }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commits-unsubscribe@...
> For additional commands, e-mail: commits-help@...
>
>

[Bernd Fondermann]

Gerolf Seitz wrote:
> Hi Bernd,
>
> what java version do you use?
> I'm on JDK 1.6_10, which seems to have no problems with the
> @Override for methods specified in an interface.

I am on 1.5_something. I wondered indeed if you didn't face the same
problem.
When I read the javadoc on @Override, which is the same for 1.5 & 1.6, I
just committed this patch. The docs say:

"If a method is annotated with this annotation type but does not
override a superclass method, compilers are required to generate an
error message."

Interface are not superclasses, so getting a compiler error sounded
reasonable.

Do you have a problem with leaving it like it is now in this case?
Still, it would be interesting to know why we encounter different behavior.

   Bernd

>
>   Gerolf
>
> On Fri, May 2, 2008 at 7:56 PM, <berndf@...> wrote:
>
>> Author: berndf
>> Date: Fri May  2 10:56:05 2008
>> New Revision: 652849
>>
>> URL: http://svn.apache.org/viewvc?rev=652849&view=rev
>> Log:
>> [vysper] fix compile-time error
>>
>> Modified:
>>
>>  labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
>>
>> Modified:
>> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
>> URL:
>> http://svn.apache.org/viewvc/labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java?rev=652849&r1=652848&r2=652849&view=diff
>>
>> ==============================================================================
>> ---
>> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
>> (original)
>> +++
>> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
>> Fri May  2 10:56:05 2008
>> @@ -109,7 +109,6 @@
>>         return
>> getServerRuntimeContext().getResourceRegistry().bindSession(this);
>>     }
>>
>> -    @Override
>>     public String nextSequenceValue() {
>>        return sequence.create();
>>     }
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: commits-unsubscribe@...
>> For additional commands, e-mail: commits-help@...
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: labs-unsubscribe@...
For additional commands, e-mail: labs-help@...

[Gerolf Seitz]

On Fri, May 2, 2008 at 8:41 PM, Bernd Fondermann <bf_jak@...>
wrote:

> Do you have a problem with leaving it like it is now in this case?
> Still, it would be interesting to know why we encounter different
> behavior.
>

well, maybe it's just the eclipse compiler or a wrong default compiler
error/warning setting for the eclipse compiler.

  Gerolf

>
>  Bernd
>
>
>
> >  Gerolf
> >
> > On Fri, May 2, 2008 at 7:56 PM, <berndf@...> wrote:
> >
> >  Author: berndf
> > > Date: Fri May  2 10:56:05 2008
> > > New Revision: 652849
> > >
> > > URL: http://svn.apache.org/viewvc?rev=652849&view=rev
> > > Log:
> > > [vysper] fix compile-time error
> > >
> > > Modified:
> > >
> > >
> > >  labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > >
> > > Modified:
> > >
> > > labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > URL:
> > >
> > > http://svn.apache.org/viewvc/labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java?rev=652849&r1=652848&r2=652849&view=diff
> > >
> > >
> > > ==============================================================================
> > > ---
> > >
> > > labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > (original)
> > > +++
> > >
> > > labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > Fri May  2 10:56:05 2008
> > > @@ -109,7 +109,6 @@
> > >        return
> > > getServerRuntimeContext().getResourceRegistry().bindSession(this);
> > >    }
> > >
> > > -    @Override
> > >    public String nextSequenceValue() {
> > >       return sequence.create();
> > >    }
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: commits-unsubscribe@...
> > > For additional commands, e-mail: commits-help@...
> > >
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: labs-unsubscribe@...
> For additional commands, e-mail: labs-help@...
>
>

[Nathan Beyer-3]

This is something that was added in Java 6 -- using @Override for methods
that implement interfaces. If you use a Java 6-capable compiler, but set it
to a source level of 1.5, it should fail to compile.

-Nathan

On Fri, May 2, 2008 at 1:45 PM, Gerolf Seitz <gerolf.seitz@...> wrote:

> On Fri, May 2, 2008 at 8:41 PM, Bernd Fondermann <bf_jak@...>
> wrote:
>
> > Do you have a problem with leaving it like it is now in this case?
> > Still, it would be interesting to know why we encounter different
> > behavior.
> >
>
> well, maybe it's just the eclipse compiler or a wrong default compiler
> error/warning setting for the eclipse compiler.
>
>  Gerolf
>
>
>
> >
> >  Bernd
> >
> >
> >
> > >  Gerolf
> > >
> > > On Fri, May 2, 2008 at 7:56 PM, <berndf@...> wrote:
> > >
> > >  Author: berndf
> > > > Date: Fri May  2 10:56:05 2008
> > > > New Revision: 652849
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=652849&view=rev
> > > > Log:
> > > > [vysper] fix compile-time error
> > > >
> > > > Modified:
> > > >
> > > >
> > > >
>  labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > >
> > > > Modified:
> > > >
> > > >
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > > URL:
> > > >
> > > >
> http://svn.apache.org/viewvc/labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java?rev=652849&r1=652848&r2=652849&view=diff
> > > >
> > > >
> > > >
> ==============================================================================
> > > > ---
> > > >
> > > >
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > > (original)
> > > > +++
> > > >
> > > >
> labs/vysper/src/main/java/org/apache/vysper/xmpp/server/AbstractSessionContext.java
> > > > Fri May  2 10:56:05 2008
> > > > @@ -109,7 +109,6 @@
> > > >        return
> > > > getServerRuntimeContext().getResourceRegistry().bindSession(this);
> > > >    }
> > > >
> > > > -    @Override
> > > >    public String nextSequenceValue() {
> > > >       return sequence.create();
> > > >    }
> > > >
> > > >
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: commits-unsubscribe@...
> > > > For additional commands, e-mail: commits-help@...
> > > >
> > > >
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: labs-unsubscribe@...
> > For additional commands, e-mail: labs-help@...
> >
> >
>

[Bernd Fondermann]

Nathan Beyer wrote:
> This is something that was added in Java 6 -- using @Override for methods
> that implement interfaces. If you use a Java 6-capable compiler, but set it
> to a source level of 1.5, it should fail to compile.

Thanks Nathan, interesting!
I'd like to be Java 5 compatible because people working on MacOS
(including me) don't have Java 6 currently.

   Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: labs-unsubscribe@...
For additional commands, e-mail: labs-help@...

[William A. Rowe, Jr.]

Bernd Fondermann wrote:
> I'd like to be Java 5 compatible because people working on MacOS
> (including me) don't have Java 6 currently.

??

Look again ;-)

---------------------------------------------------------------------
To unsubscribe, e-mail: labs-unsubscribe@...
For additional commands, e-mail: labs-help@...

[Bernd Fondermann]

William A. Rowe, Jr. wrote:
> Bernd Fondermann wrote:
>> I'd like to be Java 5 compatible because people working on MacOS
>> (including me) don't have Java 6 currently.
>
> ??
>
> Look again ;-)

ok, this does not include those with Mac OS 10.5.2+ on a 64bit
Intel-based Macs who did already install it and actually put it to use
(as after the install Java Home still defaults to Java 5).
Unfortunately, I am not a part of these lucky few. ;-)

I think its reasonable and won't hurt to go with Java 5.

   Bernd

---------------------------------------------------------------------
To unsubscribe, e-mail: labs-unsubscribe@...
For additional commands, e-mail: labs-help@...

[Paul Smith-2]

On 03/05/2008, at 4:18 PM, William A. Rowe, Jr. wrote:

> Bernd Fondermann wrote:
>> I'd like to be Java 5 compatible because people working on MacOS  
>> (including me) don't have Java 6 currently.
>
> ??
>
> Look again ;-)

java 6 for Mac is only 64-bit compatible, so does not work on _all_  
macs.  (that is, PowerPC and some earlier intel chipsets).

Sucks, but there you go.  No work on whether Apple will release a  
further update for older Macs (you'd think they will, but they've done  
stranger things).

cheers,

Paul

[William A. Rowe, Jr.]

Paul Smith wrote:

>
> On 03/05/2008, at 4:18 PM, William A. Rowe, Jr. wrote:
>
>> Bernd Fondermann wrote:
>>> I'd like to be Java 5 compatible because people working on MacOS
>>> (including me) don't have Java 6 currently.
>>
>> ??
>>
>> Look again ;-)
>
> java 6 for Mac is only 64-bit compatible, so does not work on _all_
> macs.  (that is, PowerPC and some earlier intel chipsets).
>
> Sucks, but there you go.  No work on whether Apple will release a
> further update for older Macs (you'd think they will, but they've done
> stranger things).

Odd... reading http://developer.apple.com/java/javaleopard.html it seems to
imply that -d32 is/will be supported.

---------------------------------------------------------------------
To unsubscribe, e-mail: labs-unsubscribe@...
For additional commands, e-mail: labs-help@...

[Paul Smith-2]

On 03/05/2008, at 6:19 PM, William A. Rowe, Jr. wrote:

> Paul Smith wrote:
>> On 03/05/2008, at 4:18 PM, William A. Rowe, Jr. wrote:
>>> Bernd Fondermann wrote:
>>>> I'd like to be Java 5 compatible because people working on MacOS  
>>>> (including me) don't have Java 6 currently.
>>>
>>> ??
>>>
>>> Look again ;-)
>> java 6 for Mac is only 64-bit compatible, so does not work on _all_  
>> macs.  (that is, PowerPC and some earlier intel chipsets).
>> Sucks, but there you go.  No work on whether Apple will release a  
>> further update for older Macs (you'd think they will, but they've  
>> done stranger things).
>
> Odd... reading http://developer.apple.com/java/javaleopard.html it  
> seems to
> imply that -d32 is/will be supported.

-d32 is supported, but that doesn't mean that JVM runs under a  
specific hardware chipset.  You cannot install the Java 6 binary on a  
PowerPC-based platform, and I have a mate who has an older Intel Mac  
Book Pro that has an older Core Duo (not Core Duo 2) that will not run  
this JDK.

cheers,

Paul