Re: small glxgears.c patch

[Michel Dänzer-4]

On Sat, 2007-08-04 at 13:43 +0200, Ingo Molnar wrote:
> Is this the right place to send a small, trivial glxgears.c enhancement?

Yes, or http://bugs.freedesktop.org .

> The patch below adds an x/y window size parameter.

Pushed to the main repo, thanks.


--
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[vehemens]

The recent mesa commit that added "SHELL = /bin/bash" to the toplevel Makefile
broke building on my FreeBSD 7.0 current system.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Brian Paul]

On 8/7/07, Michel Dänzer <michel@...> wrote:
> On Sat, 2007-08-04 at 13:43 +0200, Ingo Molnar wrote:
> > Is this the right place to send a small, trivial glxgears.c enhancement?
>
> Yes, or http://bugs.freedesktop.org .
>
> > The patch below adds an x/y window size parameter.
>
> Pushed to the main repo, thanks.

I think I'd prefer a standard -geometry option, parsed with XParseGeometry()...

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Brian Paul]

On 8/7/07, vehemens <vehemens@...> wrote:
> The recent mesa commit that added "SHELL = /bin/bash" to the toplevel Makefile
> broke building on my FreeBSD 7.0 current system.

Any ideas on how to fix it?  Someone else complained that things
didn't work without the SHELL line.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Daniel Stone]

On Tue, Aug 07, 2007 at 09:26:49AM +0100, Brian Paul wrote:
> On 8/7/07, vehemens <vehemens@...> wrote:
> > The recent mesa commit that added "SHELL = /bin/bash" to the toplevel Makefile
> > broke building on my FreeBSD 7.0 current system.
>
> Any ideas on how to fix it?  Someone else complained that things
> didn't work without the SHELL line.

if ! test -f configs/default && ! test -l configs/default; then
    echo "no default configuration yar boo sux" >&2
    exit 1
fi


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Dan Nicholson-2]

On 8/7/07, Brian Paul <brian.paul@...> wrote:
> On 8/7/07, vehemens <vehemens@...> wrote:
> > The recent mesa commit that added "SHELL = /bin/bash" to the toplevel Makefile
> > broke building on my FreeBSD 7.0 current system.
>
> Any ideas on how to fix it?  Someone else complained that things
> didn't work without the SHELL line.

Just use SHELL = /bin/sh unless the build needs bash. Does it need
bash? Perhaps it would be best to add the SHELL setting to
configs/default and override it in the configs that don't have the
expected shell.

I believe it's the right thing to do to set SHELL and use it in the
Makefile. That at least allows it to be controlled in some manner.
Automake does the same (except that it also get's tested for in
configure).

--
Dan

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Brian Paul]

On 8/7/07, Dan Nicholson <dbn.lists@...> wrote:

> On 8/7/07, Brian Paul <brian.paul@...> wrote:
> > On 8/7/07, vehemens <vehemens@...> wrote:
> > > The recent mesa commit that added "SHELL = /bin/bash" to the toplevel Makefile
> > > broke building on my FreeBSD 7.0 current system.
> >
> > Any ideas on how to fix it?  Someone else complained that things
> > didn't work without the SHELL line.
>
> Just use SHELL = /bin/sh unless the build needs bash. Does it need
> bash? Perhaps it would be best to add the SHELL setting to
> configs/default and override it in the configs that don't have the
> expected shell.
>
> I believe it's the right thing to do to set SHELL and use it in the
> Makefile. That at least allows it to be controlled in some manner.
> Automake does the same (except that it also get's tested for in
> configure).

Bash was needed for the line:
       @ if [ -e configs/current ] ; then

is
       @ if `test -e configs/current ` ; then

a suitable replacement for sh?

Daniel, you shell code doesn't work.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Daniel Stone]

On Tue, Aug 07, 2007 at 09:36:27PM +0100, Brian Paul wrote:
> Bash was needed for the line:
>        @ if [ -e configs/current ] ; then
>
> is
>        @ if `test -e configs/current ` ; then
>
> a suitable replacement for sh?
>
> Daniel, you shell code doesn't work.

Sorry, the sense was inverted.  And I screwed up capitalisation.

if test -f configs/default || test -L configs/default; then
    echo "look at me, i have a configuration"
fi

Cheers,
Daniel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Brian Paul]

On 8/7/07, Daniel Stone <daniel@...> wrote:

> On Tue, Aug 07, 2007 at 09:36:27PM +0100, Brian Paul wrote:
> > Bash was needed for the line:
> >        @ if [ -e configs/current ] ; then
> >
> > is
> >        @ if `test -e configs/current ` ; then
> >
> > a suitable replacement for sh?
> >
> > Daniel, you shell code doesn't work.
>
> Sorry, the sense was inverted.  And I screwed up capitalisation.
>
> if test -f configs/default || test -L configs/default; then
>     echo "look at me, i have a configuration"
> fi

I figured it was something like that.  Though the file in question is
configs/current, not configs/default.  I've checked in the change.
Thanks.

-Brian

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Dan Nicholson-2]

On 8/7/07, Brian Paul <brian.paul@...> wrote:
>
> Bash was needed for the line:
>        @ if [ -e configs/current ] ; then
>
> is
>        @ if `test -e configs/current ` ; then
>
> a suitable replacement for sh?

Man, solaris sh sucks. Do you know specifically what the error was? In
the second one, you don't need to do the command substitution (``)
since you can just use the return from test in the conditional:

if test -e configs/current; then

Actually, I think the problem here is that `test' on Solaris sh can't
handle -e. Just use -f instead. It respects real files or symlinks.

$ ./sh
$ touch foo
$ ln -sv foo bar
`bar' -> `foo'
$ [ -e bar ]
test: argument expected
$ [ -f bar ]
$ echo $?
0

It might be best if you just add SHELL = /bin/bash to the sunos*
configs since that's really where the issues are. Any linux host will
have a POSIX compliant /bin/sh that will handle most of the stuff you
want. Solaris /bin/sh is the old Bourne shell, I think. If you want to
mess around with the Solaris sh, you can use this (that's what I used
for the test above):

http://heirloom.sourceforge.net/sh.html

--
Dan

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Daniel Stone]

On Tue, Aug 07, 2007 at 02:03:19PM -0700, Dan Nicholson wrote:
> Actually, I think the problem here is that `test' on Solaris sh can't
> handle -e. Just use -f instead. It respects real files or symlinks.

-f on zsh/bash, at least, is regular files only, and not symlinks, hence
the use of -L also.

Cheers,
Daniel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Dan Nicholson-2]

On 8/7/07, Daniel Stone <daniel@...> wrote:
> On Tue, Aug 07, 2007 at 02:03:19PM -0700, Dan Nicholson wrote:
> > Actually, I think the problem here is that `test' on Solaris sh can't
> > handle -e. Just use -f instead. It respects real files or symlinks.
>
> -f on zsh/bash, at least, is regular files only, and not symlinks, hence
> the use of -L also.

Hmm, on bash it seems to work for me. Can't hurt, though.

$ bash
$ touch foo
$ ln -svf foo bar
`bar' -> `foo'
$ [ -f bar ]
$ echo $?
0

--
Dan

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Daniel Stone]

On Tue, Aug 07, 2007 at 02:21:05PM -0700, Dan Nicholson wrote:

> On 8/7/07, Daniel Stone <daniel@...> wrote:
> > On Tue, Aug 07, 2007 at 02:03:19PM -0700, Dan Nicholson wrote:
> > > Actually, I think the problem here is that `test' on Solaris sh can't
> > > handle -e. Just use -f instead. It respects real files or symlinks.
> >
> > -f on zsh/bash, at least, is regular files only, and not symlinks, hence
> > the use of -L also.
>
> Hmm, on bash it seems to work for me. Can't hurt, though.
>
> $ bash
> $ touch foo
> $ ln -svf foo bar
> `bar' -> `foo'
> $ [ -f bar ]
> $ echo $?
> 0

Ah.  I don't have any files in ~ (only directories), so that explains
it.  It looks through the symlink, so:
daniels@psyence:~% ln -s x/xorg/xserver foo
daniels@psyence:~% test -f foo
zsh: exit 1
daniels@psyence:~% rm foo
daniels@psyence:~% ln -s x/xorg/xserver/configure.ac foo
daniels@psyence:~% test -f foo
daniels@psyence:~%

Meaning you could just make the entire thing 'if test -f
configs/current'.  Heh.

Cheers,
Daniel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Alan Coopersmith]

Dan Nicholson wrote:
> Man, solaris sh sucks.[...] Solaris /bin/sh is the old Bourne shell, I think.

Yep - it's ancient original Bourne shell, in all it's non-POSIX-compliant
glory and script-writing pain.  /bin/ksh (ksh88) and /bin/bash are
available as alternatives on most Solaris hosts, and there's talk of
changing /bin/sh to be ksh93.

--
        -Alan Coopersmith-           alan.coopersmith@...
         Sun Microsystems, Inc. - X Window System Engineering


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev

[Roland Mainz]

Alan Coopersmith wrote:
> Dan Nicholson wrote:
> > Man, solaris sh sucks.[...] Solaris /bin/sh is the old Bourne shell, I think.
>
> Yep - it's ancient original Bourne shell, in all it's non-POSIX-compliant
> glory and script-writing pain.  /bin/ksh (ksh88) and /bin/bash are
> available as alternatives on most Solaris hosts, and there's talk of
> changing /bin/sh to be ksh93.

Just for the log: In OpenSolaris/2008.05 /usr/bin/sh, /bin/sh,
/usr/bin/ksh and /usr/xpg4/bin/sh now all point to ksh93.

----

Bye,
Roland

--
  __ .  . __
 (o.\ \/ /.o) roland.mainz@...
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL <currently fluctuating>
 (;O/ \/ \O;)

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Mesa3d-dev mailing list
Mesa3d-dev@...
https://lists.sourceforge.net/lists/listinfo/mesa3d-dev