Re: another eclipse correction

[Joe Walker-3]

On 5/31/07, Mike Wilson <mikewse@...> wrote:

BTW: would it be possible to adjust the checked-in Eclipse project settings to ignore suitable warnings as not to fill up the Problems View?

I think all the warnings are mostly in the Guice code. There are a couple in the rest of the code, but they're prompting me to fix something...

So the options are:
- reduce the warning levels, which means I'll be prompted less to comment my code, etc.

- fix the warnings in the Guice code, which means editing Tim's code.
- mentally ignore them, which is what I do - I generally don't use the problems view - I go on the markers in the package view.
- configure the problems view to ignore them - I'm sure it's possible.

I was working on 3, but happy to change strategy. I'm not too keen on 1 though.

Joe.

[mikewse]

Oh, you're quite right about the guice code, I hadn't spotted that (the Path column usually clips, have to get that 24" screen ;-).

Here's the full statistics on warnings:

java warnings in guice code: 161

java warnings in non-guice code: 1 

validation (html etc) warnings: 91

(I use WTP for the DWR project so that is the producer of validation warnings.)

Maybe we could ask Tim to fix his warnings?

I could clean up the "easy" validation warnings, but we will not be able to get rid of all.

 

Best regards

Mike

---

From: joseph.walker@... [mailto:joseph.walker@...] On Behalf Of Joe Walker
Sent: den 8 juni 2007 12:57
To: issues@...
Subject: Re: another eclipse correction

On 5/31/07, Mike Wilson <mikewse@...> wrote:

BTW: would it be possible to adjust the checked-in Eclipse project settings to ignore suitable warnings as not to fill up the Problems View?

I think all the warnings are mostly in the Guice code. There are a couple in the rest of the code, but they're prompting me to fix something...

So the options are:
- reduce the warning levels, which means I'll be prompted less to comment my code, etc.

- fix the warnings in the Guice code, which means editing Tim's code.
- mentally ignore them, which is what I do - I generally don't use the problems view - I go on the markers in the package view.
- configure the problems view to ignore them - I'm sure it's possible.

I was working on 3, but happy to change strategy. I'm not too keen on 1 though.

Joe.

[Joe Walker-3]

Tim,
I'm not sure if you use Eclipse or not - the error/warning settings we use in Eclipse are showing up quite a few issues in the Guice code. Most are non-genericized code, but some are unused imports, missing javadoc etc. Nothing serious except that the warnings may obscure more serious issues.
Do you have a problem with me running a genericizer on the code?

Mike,
I gave up with WTP a while ago, and I'm trying ATF now, but can't get it to integrate with Mozilla properly yet.
Could you copy the HTML warnings into a file, zip and send it over?

Thanks,

Joe.

On 6/13/07, Mike Wilson <mikewse@...> wrote:

Oh, you're quite right about the guice code, I hadn't spotted that (the Path column usually clips, have to get that 24" screen ;-).

Here's the full statistics on warnings:

java warnings in guice code: 161

java warnings in non-guice code: 1 

validation (html etc) warnings: 91

(I use WTP for the DWR project so that is the producer of validation warnings.)

Maybe we could ask Tim to fix his warnings?

I could clean up the "easy" validation warnings, but we will not be able to get rid of all.

 

Best regards

Mike

---

From: joseph.walker@... [mailto:joseph.walker@...] On Behalf Of Joe Walker
Sent: den 8 juni 2007 12:57
To: issues@...
Subject: Re: another eclipse correction

On 5/31/07, Mike Wilson <mikewse@...> wrote:

BTW: would it be possible to adjust the checked-in Eclipse project settings to ignore suitable warnings as not to fill up the Problems View?

I think all the warnings are mostly in the Guice code. There are a couple in the rest of the code, but they're prompting me to fix something...

So the options are:
- reduce the warning levels, which means I'll be prompted less to comment my code, etc.

- fix the warnings in the Guice code, which means editing Tim's code.
- mentally ignore them, which is what I do - I generally don't use the problems view - I go on the markers in the package view.
- configure the problems view to ignore them - I'm sure it's possible.

I was working on 3, but happy to change strategy. I'm not too keen on 1 though.

Joe.

[tpeierls]

Joe,

I'm very sorry for the late reply; I've only been getting digests from DWR - Dev and totally missed all this. I'll try to stay up-to-date now.

I have no problems with you doing whatever you want with that code.

Joe Walker-3 wrote:

Tim,
I'm not sure if you use Eclipse or not - the error/warning settings we use
in Eclipse are showing up quite a few issues in the Guice code. Most are
non-genericized code, but some are unused imports, missing javadoc etc.
Nothing serious except that the warnings may obscure more serious issues.
Do you have a problem with me running a genericizer on the code?

[Joe Walker-3]

Thanks Tim. I'll take a look through it some time.
Joe.

On 7/12/07, tpeierls <tim@...> wrote:

Joe,

I'm very sorry for the late reply; I've only been getting digests from DWR -
Dev and totally missed all this. I'll try to stay up-to-date now.

I have no problems with you doing whatever you want with that code.


Joe Walker-3 wrote:
>
> Tim,
> I'm not sure if you use Eclipse or not - the error/warning settings we use
> in Eclipse are showing up quite a few issues in the Guice code. Most are
> non-genericized code, but some are unused imports, missing javadoc etc.
> Nothing serious except that the warnings may obscure more serious issues.
> Do you have a problem with me running a genericizer on the code?
>
--
View this message in context: http://www.nabble.com/Re%3A-another-eclipse-correction-tf3889077.html#a11568955
Sent from the DWR - Issues mailing list archive at Nabble.com.