« Return to Thread: Would Like to request change to DefaultScriptSession.invalidate method

Re: Would Like to request change to DefaultScriptSession.invalidate method

by Joe Walker-3 :: Rate this Message:

Reply to Author | View in Thread


Tim - you scare me! How the *%@£$ did you spot that?
Thanks.

Joe.

On Wed, Apr 9, 2008 at 3:08 PM, tpeierls <tim@...> wrote:

It wasn't a waste. I found a concurrency bug while looking at it. :-/

The invalidated field is @GuardedBy("invalidLock"), so all access to the
field must be done with the lock held. The invalidateIfNeeded() method,
however, tests the field outside of any synchronization.

Quickest fix would be to make the field volatile.

--tim


Roger Desroches wrote:
>
> Oh blast it, never mind.  It's still invalidating itself base on the time
> when getAttribute is called.  I guess I'm just going to create another
> level of indirection and store all my attributes in another store hashed
> by session id.
>
> sorry for the wasted bandwidth.
> Roger
>

--
View this message in context: http://www.nabble.com/Would-Like-to-request-change-to-DefaultScriptSession.invalidate-method-tp16585714p16585986.html
Sent from the DWR - Dev mailing list archive at Nabble.com.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


 « Return to Thread: Would Like to request change to DefaultScriptSession.invalidate method