On 6/26/07, Greg Wilkins <gregw@...> wrote:
Joe Walker wrote:
> >
> > Just integrating this - presumably dwr-bayeux needs to be served by DWR?
> > I'm thinking it's going to be good if DWR detects that it's in bayeux
> > mode and automatically gives you dwr-bayeux along with
engine.js?
Joe,
you have added cometd 6.1.4 jar, but not removed the 6.1.3 one from cvs.
Yes - thanks.
Will check in soon.
Also, as I have been getting some email bounces.... here is my earlier
response again... just in case.
Joe Walker wrote:
> >
> > Just integrating this - presumably dwr-bayeux needs to be served by DWR?
Well it depends on how close an integration that you want at this point.
The cost is small, a small js file and a listener class (bat that depends on
dojox.cometd interfaces that are not yet individually bundled).
> > I'm thinking it's going to be good if DWR detects that it's in bayeux
> > mode and automatically gives you dwr-bayeux along with engine.js?
It would great if it could be done purely additive. ie zero changes
to core dwr that know about bayeux.
The problem is that the listener can't serve the js itself. So perhaps
this is a DwrBayeuxFilter instead of a listener. This can be configured
in front of the standard DWR servlet and intercept
engine.js requests and
server back the modified engine.js file (which is the standard engine.js
plus the bayeux bits).
This would mean that rather than:
0) install dwr
1) install bayeux
2) configure bayeux-dwr listener
3) configure dwr for bayeux
it would simple be
0) install dwr
1) install bayeux
2) configure bayeux-dwr filter
if you like this approach, I'll refactor the patch.
Makes total sense to me
Joe.
