Re: RFS: nautilus-clamscan

View: New views
6 Messages — Rating Filter:   Alert me  

Parent Message unknown Re: RFS: nautilus-clamscan

by Vincent Bernat-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

OoO En  ce début  de soirée du  mardi 13  mai 2008, vers  21:55, Clement
Lorteau <northern_lights@...> disait:

> I am looking for a sponsor for my package "nautilus-clamscan".

> * Package name    : nautilus-clamscan
>   Version         : 0.2.1-1
>   Upstream Author : Clement Lorteau <northern_lights@...>
> * URL             : http://launchpad.net/nautilus-clamscan
> * License         : GPLv3
>   Section : utils

Hi Clement!

Since this is a python application, you should Cc: debian-python mailing
list. They can give you some accurate advices.

In debian/changelog, say "Initial release", not "First Debian package". ;-)

In debian/control, you should move dpatch to Build-Depends: it is needed
for clean target. Why do you depend on dpatch if there is no patch?

I think that you should move test files into /usr/share/doc/XXX/examples
(with nautilus-clamscan.examples).

Remove  the fact  that debian/rules  is a  sample file.  Why do  you set
.NOTPARALLEL?
--
I WILL NOT FAKE RABIES
I WILL NOT FAKE RABIES
I WILL NOT FAKE RABIES
-+- Bart Simpson on chalkboard in episode 8F07


attachment0 (194 bytes) Download Attachment

Re: RFS: nautilus-clamscan

by Clement Lorteau :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi !

Thank you for the review. I followed your recommendations and uploaded
the new package to debian.mentors.net. See my comments below.

Thanks,
Clement.

--
Clement Lorteau
www.lorteau.fr | launchpad.net/~northern-lights


Le mercredi 14 mai 2008 à 20:18 +0200, Vincent Bernat a écrit :
> In debian/control, you should move dpatch to Build-Depends: it is needed
> for clean target. Why do you depend on dpatch if there is no patch?
Because the generic Python application Debian packaging script i make as
my understanding of packaging evolves puts it even if there's no patch
to apply :p. Fixed.
> I think that you should move test files into /usr/share/doc/XXX/examples
> (with nautilus-clamscan.examples).
Done
> Remove  the fact  that debian/rules  is a  sample file.  Why do  you set
> .NOTPARALLEL?
Done; .NOTPARALLEL was for dpatch so i removed it


signature.asc (196 bytes) Download Attachment

Re: RFS: nautilus-clamscan

by Vincent Bernat-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

OoO En ce  début de soirée du mercredi 14 mai  2008, vers 21:27, Clement
Lorteau <northern_lights@...> disait:

> Thank you for the review. I followed your recommendations and uploaded
> the new package to debian.mentors.net. See my comments below.

You  can use  "test_files/*" for  debian/nautilus-clamscan.examples. You
may also add a debian/watch file this is very useful.

Your GPG  key is not  signed by anyone.  You should try to  meet someone
that can sign  it, preferably a DD  or someone whose key is  signed by a
DD. Look at this page:
 https://nm.debian.org/gpg.php

If you live in Paris or near Paris, I can sign your key.
--
panic("bad_user_access_length executed (not cool, dude)");
        2.0.38 /usr/src/linux/kernel/panic.c


attachment0 (194 bytes) Download Attachment

Re: RFS: nautilus-clamscan

by Clement Lorteau :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hello,

I uploaded a new version that has a debian/watch file, per standards version 3.8.0: http://mentors.debian.net/debian/pool/main/n/nautilus-clamscan. Could you have a look?

You  can use  "test_files/*" for  debian/nautilus-clamscan.examples.
Is that really needed or is it just for the convenience of the packager? The packaging script I develop as my understanding of Debian packaging evolves can't do that.

Your GPG  key is not  signed by anyone.  You should try to  meet someone
that can sign  it, preferably a DD  or someone whose key is  signed by a
DD. Look at this page:
 https://nm.debian.org/gpg.php

If you live in Paris or near Paris, I can sign your key.
I do live near Paris. I'll contact you in private. However, is the key signing needed for uploading the package? I had 2 versions of another package uploaded without having to have my key signed.

Thanks for the help,
Clément.

--
Clement Lorteau
www.lorteau.fr | launchpad.net/~northern-lights


signature.asc (196 bytes) Download Attachment

Re: RFS: nautilus-clamscan

by Richard Hecker :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Clement Lorteau wrote:

...<snip>...

>> Your GPG  key is not  signed by anyone.  You should try to  meet someone
>> that can sign  it, preferably a DD  or someone whose key is  signed by a
>> DD. Look at this page:
>>  https://nm.debian.org/gpg.php
>>
>> If you live in Paris or near Paris, I can sign your key.
>>    
> I do live near Paris. I'll contact you in private. However, is the key
> signing needed for uploading the package? I had 2 versions of another
> package uploaded without having to have my key signed.
>
If I were intimately familiar with a package and had looked at
EVERYTHING, I would be comfortable
uploading a package signed with an unverified key.  But that is a lot of
work (and I am basically
asking everyone to hold me accountable for any problems ;-).

It is much more likely that I would not duplicate someone else's
effort.  When I decide to accept what
someone else has done, then it become much more important to be able to
identify that person.  At
the point where I might want to say I got code from someone else, the
signed key becomes critical.
I could upload a package that was sent with an unverified key, but that
would speak volumes about
my judgement.  When I sign a package (or another key for that matter), a
person can rely on my
judgement as input.  I do not promote worthless input.  It should be
easy to understand why a person
would hesitate to accept an unverified key since it could make their
judgement worthless.

Richard


--
To UNSUBSCRIBE, email to debian-python-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...


Re: RFS: nautilus-clamscan

by Vincent Bernat-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

OoO En ce début d'après-midi nuageux du samedi 14 juin 2008, vers 14:33,
Clement Lorteau <northern_lights@...> disait :

> I uploaded a new version that has a debian/watch file, per standards version
> 3.8.0: http://mentors.debian.net/debian/pool/main/n/nautilus-clamscan. Could
> you have a look?

Seems fine. I have uploaded it.

>     You  can use  "test_files/*" for  debian/nautilus-clamscan.examples.

> Is that really needed or is it just for the convenience of the packager? The
> packaging script I develop as my understanding of Debian packaging evolves
> can't do that.

This is not a requirement.
--
BOFH excuse #351:
PEBKAC (Problem Exists Between Keyboard And Chair)


attachment0 (202 bytes) Download Attachment