|
»
»
»
»
»
« Return to Thread: Issue 742 (GML SAX parsing)
Re: Issue 742 (GML SAX parsing)
by Justin Deoliveira-4
::
Rate this Message:
Oh sorry, I did not see that you submitted the patch. I looked it over
and it looks ok. The only danger i see with this patch is that more
exceptions are thrown then before, so existing client code may be in for
a surprise. However the new exceptions are good because they provide
better error reporting as opposed to just logging a warning.
I am +1 one on the patch. But I think we should also get jesse to review
it. He is more or less the module maintainer of the wfs client module,
which from what i can tell is the biggest user of the gml sax parser.
-Justin
Pierrick Brihaye wrote:
> Hi,
>
> Justin Deoliveira a écrit :
>
>> So as I stated before there are some problems with the gml file which i
>> dont expect any parser to handle.
>
> That's how I get them : if they aren't strictly compliant, be sure that
> I regret to have to face that every day reality. However, I would also
> expect a SAXParser to throw SAXExceptions instead of NPEs.
>
>> Unfortunately I cannot offer much in the way of fixing this bug with the
>> old parser since I know very little about it and would not really be
>> able to fix the bug confidently ( even though Jody assigned this bug to
>> me ).
>
> So... to whom should I ask ? Isn't there any possibility to integrate my
> patch ? Of course, should it be integrated, I'd volunteer to maintain
> that part of the code ;-)
>
>> Fixing the problems I mentioned a
>> while ago in the email I was able to get the file to parse properly with
>> the "new" gml parser.
>
>> So if you are willing to try the new parser out then I would be happy to
>> help, otherwise i am not sure... I know this is not ideal for you but we
>> lost our module maintainer for the old parser some time ago.
>
> I would be very interested in setting up this new parser in my SAX/STAX
> parser and I'd welcome a HOWTO. Be aware however that I "just" want the
> geometries : all other info/constraints will be left to another process.
> That's what I'm somehow afraid of : be required to embed a heavy library
> where I just want a fast GML SAX parser.
>
> Cheers,
>
> p.b.
>
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Geotools-devel mailing list
> Geotools-devel@...
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@...
https://lists.sourceforge.net/lists/listinfo/geotools-devel
and it looks ok. The only danger i see with this patch is that more
exceptions are thrown then before, so existing client code may be in for
a surprise. However the new exceptions are good because they provide
better error reporting as opposed to just logging a warning.
I am +1 one on the patch. But I think we should also get jesse to review
it. He is more or less the module maintainer of the wfs client module,
which from what i can tell is the biggest user of the gml sax parser.
-Justin
Pierrick Brihaye wrote:
> Hi,
>
> Justin Deoliveira a écrit :
>
>> So as I stated before there are some problems with the gml file which i
>> dont expect any parser to handle.
>
> That's how I get them : if they aren't strictly compliant, be sure that
> I regret to have to face that every day reality. However, I would also
> expect a SAXParser to throw SAXExceptions instead of NPEs.
>
>> Unfortunately I cannot offer much in the way of fixing this bug with the
>> old parser since I know very little about it and would not really be
>> able to fix the bug confidently ( even though Jody assigned this bug to
>> me ).
>
> So... to whom should I ask ? Isn't there any possibility to integrate my
> patch ? Of course, should it be integrated, I'd volunteer to maintain
> that part of the code ;-)
>
>> Fixing the problems I mentioned a
>> while ago in the email I was able to get the file to parse properly with
>> the "new" gml parser.
>
>> So if you are willing to try the new parser out then I would be happy to
>> help, otherwise i am not sure... I know this is not ideal for you but we
>> lost our module maintainer for the old parser some time ago.
>
> I would be very interested in setting up this new parser in my SAX/STAX
> parser and I'd welcome a HOWTO. Be aware however that I "just" want the
> geometries : all other info/constraints will be left to another process.
> That's what I'm somehow afraid of : be required to embed a heavy library
> where I just want a fast GML SAX parser.
>
> Cheers,
>
> p.b.
>
>
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Geotools-devel mailing list
> Geotools-devel@...
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@...
https://lists.sourceforge.net/lists/listinfo/geotools-devel
« Return to Thread: Issue 742 (GML SAX parsing)
| Free Forum Powered by Nabble | Forum Help |