« Return to Thread: Code audit

Re: Code audit

by pip88nl :: Rate this Message:

Reply to Author | View in Thread

On Mon, Jun 30, 2008 at 10:47:51AM -0700, David Casperson wrote:
> buffer points at, just the buffer itself.  This matches
> bufCapture, which does not copy the ``String s'', just makes a
> buffer that points at it.
>
> Does this seem right?

It seems right, but in some cases (dgCycleError, dgOrderError), the
buffer is created with bufNew, not bufCapture. Your explanation of
"memory leak is okay on error paths" is not really what I'm looking for.
As I explained on my website, the Aldor GC performs best if memory is
manually returned to the allocator. Am I missing anything here? Is
bufLiberate really the right thing even in these functions?

--
Pippijn van Steenhoven


_______________________________________________
Aldor-l mailing list
Aldor-l@...
http://aldor.org/mailman/listinfo/aldor-l_aldor.org

signature.asc (196 bytes) Download Attachment

 « Return to Thread: Code audit

LightInTheBox - Buy quality products at wholesale price!