Re: Bug#462087: clisp-dev: Includes unnecessary library references

[Luca Capello]

tags 462087 + pending
thanks

Hi Sam!

Cc:ing the CLISP-devel upstream mailing list since this "bug" was also
discussed there [1].  Please reply at least to the Debian BTS!

On Tue, 15 Jul 2008 15:54:13 +0200, Sam Steingold wrote:
> $ grep X_PRE_ config.log
> X_PRE_LIBS=' -lSM -lICE'
>
> X_PRE_LIBS is set by the standard autoconf macro AC_PATH_XTRA,
> invoked by modules/clx/new-clx/configure
>
> if you want, you can try to replace AC_PATH_XTRA with AC_PATH_X,
> regenerate configures &c and see if it still works.

At least on i386 with version 2.44.1 [2]:

- with libxt-dev installed (thus libice-dev and libsm-dev), changing
  AC_PATH_XTRA to AC_PATH_X changes nothing in general

- without libxt-dev, changing AC_PATH_XTRA with AC_PATH_X still doesn't
  change anything WRT to clx (first log).  ./configure generates the
  same output and the same build dir as if I leave AC_PATH_XTRA (second
  log, again without libxt-dev)

IMO the "problem" is not in modules/clx/new-clx/configure, but in
src/configure instead: the check was introduced with r1.159 [4] (r1.14
for modules/clx/new-clx/configure [5]) and at least from the comment it
seems to be specific to SunOS 4.x.

If I'm correct (which I doubt), shouldn't this check be wrapped around
"#ifdef SunOS ... #endif"?

I've everyday used a CLISP built without the libxt-dev dependency for
now 5 days, together with StumpWM [6], and I haven't experienced any
difference or bug.  For this reason, together with the fact that Debian
don't build on SunOS 4.x, I removed the libxt-dev dependency from clisp
Build-Depends: and clisp-dev Depends: [7].

Let's see if I break something ;-)

Thx, bye,
Gismo / Luca

Footnotes:
[1] http://thread.gmane.org/gmane.lisp.clisp.devel/18516/focus=18574
[2] we're freezing this week [3], so I don't have time to update CLISP
    to the latest released version, sorry
[3] http://lists.debian.org/debian-devel-announce/2008/07/msg00005.html
[4] http://clisp.cvs.sourceforge.net/clisp/clisp/src/configure?r1=1.158&r2=1.159
[5] http://clisp.cvs.sourceforge.net/clisp/clisp/modules/clx/new-clx/configure?view=diff&r1=1.13&r2=1.14
[6] http://bugs.debian.org/cgi-bin/bugreport.cgi?archive=yes&bug=462087#10
[7] http://git.debian.org/?p=pkg-common-lisp/clisp.git;a=commitdiff;h=f2695ead62189c7cc569c4382e0199385f3be299





-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

[Sam Steingold]

> * Luca Capello <yhpn@...> [2008-07-20 21:48:29 +0200]:
>
> On Tue, 15 Jul 2008 15:54:13 +0200, Sam Steingold wrote:
>> $ grep X_PRE_ config.log
>> X_PRE_LIBS=' -lSM -lICE'
>>
>> X_PRE_LIBS is set by the standard autoconf macro AC_PATH_XTRA,
>> invoked by modules/clx/new-clx/configure
>>
>> if you want, you can try to replace AC_PATH_XTRA with AC_PATH_X,
>> regenerate configures &c and see if it still works.
>
> At least on i386 with version 2.44.1 [2]:
>
> - with libxt-dev installed (thus libice-dev and libsm-dev), changing
>   AC_PATH_XTRA to AC_PATH_X changes nothing in general
>
> - without libxt-dev, changing AC_PATH_XTRA with AC_PATH_X still doesn't
>   change anything WRT to clx (first log).  ./configure generates the
>   same output and the same build dir as if I leave AC_PATH_XTRA (second
>   log, again without libxt-dev)
>
> IMO the "problem" is not in modules/clx/new-clx/configure, but in
> src/configure instead: the check was introduced with r1.159 [4] (r1.14
> for modules/clx/new-clx/configure [5]) and at least from the comment it
> seems to be specific to SunOS 4.x.
>
> If I'm correct (which I doubt), shouldn't this check be wrapped around
> "#ifdef SunOS ... #endif"?

examining the generated configure files gives me nothing.
the changes you are pointing at come from the switch from a home-brewed
X detection script to a standard autoconf facility.

> I've everyday used a CLISP built without the libxt-dev dependency for
> now 5 days, together with StumpWM [6], and I haven't experienced any
> difference or bug.  For this reason, together with the fact that Debian
> don't build on SunOS 4.x, I removed the libxt-dev dependency from clisp
> Build-Depends: and clisp-dev Depends: [7].

good for you.

let me reiterate: IMO, this has nothing to do with CLISP: we use a
standard facility.  I suggest that you take this issue to the autoconf
people who maintain AC_PATH_XTRA.

--
Sam Steingold (http://sds.podval.org/) on Fedora release 9 (Sulphur)
http://camera.org http://pmw.org.il http://ffii.org
http://honestreporting.com http://palestinefacts.org http://mideasttruth.com
To a Lisp hacker, XML is S-expressions with extra cruft.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel