Re: Artifact Version Comparison

by Jason van Zyl-2 :: Rate this Message:

On 1-May-08, at 1:07 PM, Hervé BOUTEMY wrote:

> Kenney started a proposal http://docs.codehaus.org/display/MAVEN/Versioning
> with a implementation of a comparator.
>
> I took his implementation, updated it to support comparison between
> more
> version schemes and integrated it to DefaultArtifactVersion class.
> The code
> is here http://svn.apache.org/viewvc/maven/artifact/branches/
> MNG-3010/, with
> unit test showing version schemes in action:
> http://svn.apache.org/viewvc/maven/artifact/branches/MNG-3010/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
>
> I think the new ordering will give better results than the current
> one and
> would like to merge it to artifact trunk and 2.0.x branch. Before
> doing so, I
> submit the code for review: any comments?
>

All the integration tests pass? I'm just totally leery of changes to
the artifact mechanism in the 2.0.x branch.

Every time we do this we have adversely impacted users even though we
mean to improve it. If you have any doubt about it preserving the
existing behavior 100% then you can't do it on the branch. Maybe we
increase the coverage pull in some sample builds from branches of
existing projects to build up a test bed, but we have historically not
faired well in changing Maven Artifact.

> regards,
>
> Hervé
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@...
> For additional commands, e-mail: dev-help@...
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
jason at sonatype dot com
----------------------------------------------------------

Our achievements speak for themselves. What we have to keep track
of are our failures, discouragements and doubts. We tend to forget
the past difficulties, the many false starts, and the painful
groping. We see our past achievements as the end result of a
clean forward thrust, and our present difficulties as
signs of decline and decay.

-- Eric Hoffer, Reflections on the Human Condition

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...

« Return to Thread: Artifact Version Comparison

LightInTheBox - Buy quality products at wholesale price