« Return to Thread: [Trinidad] added browser version support in skinning TRINIDAD-799

Re: [Trinidad] added browser version support in skinning TRINIDAD-799

by Blake Sullivan :: Rate this Message:

Reply to Author | View in Thread

Cristi Toth said the following On 4/17/2008 2:00 PM PT:

On Thu, Apr 17, 2008 at 9:58 PM, Blake Sullivan <blake.sullivan@...> wrote:
Andrew Robinson said the following On 4/17/2008 12:35 PM PT:

So do I read this correctly that for #3, 8 means 8.x so a max-version
of 8 means any browser agent with a major version of 8 or less an not
even look at the minor version?
 
I'm proposing that the version feature reflect the best floating point version number we can calculate for the browser, which will usually be a combination of the major and minor version, so the version for IE 5.5 will be the floating point number 5.5

Does anybody KNOW how the browsers express their  version exactly?
Because TrinidadAgent currently only has majorVersion and agentVersion (the latter being an unparsed string).
I will have to parse that agentVersion to also get out the minor version.
Does anybody know why this wasn't done initially? (any reason like too different between the browsers?)
I can't remember why I wrote the code the way I did 12 years ago, but assuming that I was lazy and didn't think that it probably mattered that much at the time is probably a good bet.

-- Blake Sullivan


 


8 is promoted to 8.0 and since max- means less-than-or-equal-to:max-version:8 means

version <= 8.0 == true

-- Blake Sullivan





--
Cristi Toth

-------------
Codebeat
www.codebeat.ro

 « Return to Thread: [Trinidad] added browser version support in skinning TRINIDAD-799