« Return to Thread: [Trinidad] added browser version support in skinning TRINIDAD-799

Re: [Trinidad] added browser version support in skinning TRINIDAD-799

by Blake Sullivan :: Rate this Message:

Reply to Author | View in Thread

Cristi,

I think that we should follow a subset of the syntax of CSS Media Queries for consistency as this is a CSS file.  If there are other standard syntaxes for CSS, we can use one of those instead.

Your rule below could be expressed in such a syntax as:

@agent ie and (min-version:5) and (max-version:7), gecko, safari

Assuming that we chose a convenient definition for ma-version (that it includes all version up to but not including an increment of the smallest specified digit.  so that max-version:7 really means version < 8,  while max-version 7.5 really means version < 7.6)

-- Blake Sullivan



Cristi Toth said the following On 4/16/2008 3:24 PM PT:
Hi guys,

I finally added browser version support in skinning, but using a different format than first suggested.
As we needed to support multiple browsers, each with multiple versions, I have chosen to use this format:

@ agent ie 5 6 7, gecko,safari {....}


So each agent definition separated by comma and the versions a space separated list following the browser type.

Also in the code I replaced :
int[] browsers
int[] versions
with :
Map <Integer, Set<Integer>> browsers

this represents browser types mapped to their versions set.


If you have any objections on this, please reopen the issue and add some comments

Regards,
--
Cristi Toth

-------------
Codebeat
www.codebeat.ro

 « Return to Thread: [Trinidad] added browser version support in skinning TRINIDAD-799