On Tue, May 13, 2008 at 09:54:06AM -0500, Volker Lendecke wrote:
> The branch, v3-0-test has been updated
> via 660be616b85a32725841877041190a6ec0f122f1 (commit)
> via 968ff01d5163b232e10276efbcfd6750f97d81a5 (commit)
> from deefb1a4bcfdbbf7d045948598140c477591ea44 (commit)
>
>
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-0-test>
>
> - Log -----------------------------------------------------------------
> commit 660be616b85a32725841877041190a6ec0f122f1
> Author: Volker Lendecke <
vl@...>
> Date: Tue May 13 16:23:19 2008 +0200
>
> Fix signing problem in the client with transs requests
>
> This is a different fix than Jeremy put into 3-0-test with 040db1ce85 and other
> branches with different hashes. Jeremy, I think your fix led to bug 5436, so I
> reverted your fix. This fixes the original problem I found with the transs
> requests for large rpc queries in a different way. Please check!
Ok, examining this it looks like the key to this patch is that
you call :
client_set_trans_sign_state_off(cli, mid);
client_set_trans_sign_state_on(cli, mid);
to delete the mid record for the previous sequence, and then re-add
it for the new outgoing packet - incrementing the sequence number
now rather than the old version of this fix which kept the sequence
number constant. Correct ? If so then I understand it and well done
and thanks :-).
Call me if you need to discuss, I'm on my cell @ Connectathon at
the moment.
Jeremy.
