Re: [PATCH} Adding Grizzly Comet 'native' support to DWR

>
> Jeanfrancois,
>
> Fantastic - it looks good and applies cleanly. Thanks.
> So here's the bad news - I'm trying to be a good citizen and ensure that
> DWR is covered by a CLA for all the code. That gives us a couple of
> options:
> - You get Sun to sign a CCLA saying that I'm allowed to use the IPR in
> the patch.
> - You tell me there isn't any IPR in the patch.
>
> I have to say, since the patch is so similar to the Jetty code, I think
> it's likely that the second option is a) honest and b) the fastest.
> What do you think?

>
> Joe.
>
>
> On Nov 22, 2007 3:37 AM, Jeanfrancois Arcand
> <Jeanfrancois.Arcand@... <mailto:Jeanfrancois.Arcand@...>> wrote:
>
>     Hi,
>
>     over the last couple of months I got a lot of requests from users of
>     Grizzly Comet[1] to support dwr (or have dwr have support :-)). I took a
>     look at the code and came with the attached simple patch. Mainly, I've
>     just added a new class called GrizzlyContinuationSleeper, "hacked" the
>     Continuation classes to enable Grizzly when DWR is deployed in GlassFish
>     or Grizzly Standalone Web Server.
>
>     The classes I've touched are:
>
>     + PollHandler
>     + Continuation
>     + Added GrizzlyContinuationSleeper
>     + OutputAlarm (guard against null)
>
>     PollHandler + Conyinuation looks a little bit hacky (might need to
>     replace the isJetty/isGrizzly with a better design) but the idea is
>     there. Let me know what you think and if you are interested to add
>     support to the current dwr release.
>
>     What needs to be done is if accepted is:
>
>     + apply the patch.
>     + add the following jar file
>
>     http://download.java.net/maven/2/com/sun/grizzly/continuation/1.6-SNAPSHOT/continuation-1.6-SNAPSHOT.jar
>     <http://download.java.net/maven/2/com/sun/grizzly/continuation/1.6-SNAPSHOT/continuation-1.6-SNAPSHOT.jar>
>
>     under the dwr/jar folder, and when packaging the war file, add it under
>     WEB-INF/lib
>
>     (and for the dwr/pom.xml file add)
>
>      >     <dependency>
>      >        <groupId>com.sun.grizzly </groupId>
>      >        <artifactId>continuation</artifactId>
>      >        <version>1.6-SNAPSHOT</version>
>      >        <scope>compile</scope>
>      >     </dependency>
>
>     The later jar file contains the Grizzly's classes that detect with
>     Grizzly version is installed and will make DWR works with all GlassFish
>     version (9.1, 9.1 ur1, Sailfin, OpenESB). I will add those classes to
>     GlassFish v3, but previous version are 'closed' for commit so I can't
>     add them. If you think this is a bad idea, we can always document it so
>     people knows how to enable dwr in GlassFish.
>
>     Thanks!
>
>     --Jeanfrancois
>
>     [1]
>     http://weblogs.java.net/blog/jfarcand/archive/2006/07/the_grizzly_com.html
>
>     ---------------------------------------------------------------------
>     To unsubscribe, e-mail: dev-unsubscribe@...
>     <mailto:dev-unsubscribe@...>
>     For additional commands, e-mail: dev-help@...
>     <mailto:dev-help@...>
>
>