« Return to Thread: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ...

Re: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ...

by Andreas Raab :: Rate this Message:

Reply to Author | View in Thread

Can you email me the patch?

Thanks,
   - Andreas

Jens Lincke wrote:

> Hi,
>
> I found a bug in the BalloonCanvas when drawing a String with an offset
> transformation
>
> the method
> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
> fontOrNil color: c
> was marked TODO and did only draw when it can fall back to FormCanvas
>
> But the offset in the Transformation was ignored, so I changed it into:
>
> drawString: s from: firstIndex to: lastIndex in: boundsRect font:
> fontOrNil color: c
>   (self ifNoTransformWithIn: boundsRect)
>       ifTrue:[ | offset |
>       offset := transform a13 @ transform a23.
>
>       ^super drawString: s from: firstIndex to: lastIndex in: boundsRect
> + offset font: fontOrNil color: c]
>
>
> and uploaded a iSqueak3.8 package Balloon-jl.4 to the
> source.impara.de/Stuff
>
> - Jens Lincke -
>
> _______________________________________________
> Balloon mailing list
> Balloon@...
> http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon
>
_______________________________________________
Balloon mailing list
Balloon@...
http://lists.squeakfoundation.org/cgi-bin/mailman/listinfo/balloon

 « Return to Thread: [Balloon] [Bug+Fix] in BalloonCanvas>>drawString: ...