RFS: winff

[Paul Gevers]

Dear mentors,

I am looking for a sponsor for my package "winff". This is my first
contribution to Debian.

* Package name    : winff
  Version         : 0.42-1
  Upstream Author : Matthew Weatherford <matt@...>
* URL             : http://www.winff.org
* License         : GLP-3
  Section         : graphics

It builds this binary package:
winff      - video and audio batch converter using ffmpeg

The package appears to be lintian clean.

The upload would fix these bugs: 485481

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/w/winff
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

I would be glad if someone would check uploaded this package for me.

Kind regards
Paul Gevers

[George Danchev]

On Monday 30 June 2008, Paul Gevers wrote:

> Dear mentors,
>
> I am looking for a sponsor for my package "winff". This is my first
> contribution to Debian.
>
> * Package name    : winff
>   Version         : 0.42-1
>   Upstream Author : Matthew Weatherford <matt@...>
> * URL             : http://www.winff.org
> * License         : GLP-3
>   Section         : graphics
>
> It builds this binary package:
> winff      - video and audio batch converter using ffmpeg
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 485481
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/w/winff
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>
> I would be glad if someone would check uploaded this package for me.

Hi,

Some minor comments:

- No need to build-depend on fpc-source or you have a strong reason doing so ?
- Need to depend on ffmpeg since AFAICS it is being called by winff runtime.
- Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS repo of
your packaging, if any.

--
pub key ID 0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Paul Gevers]

[Paul Gevers]

Disregard my previous message, something went wrong with the signing.
Here is the original text:

Thanks for the quick review.

> - No need to build-depend on fpc-source or you have a strong reason
> doing so ?

Removed: done.

> - Need to depend on ffmpeg since AFAICS it is being called by winff
> runtime.

Huh, I am pretty sure I see it. I moved it to the first dependent
instead of the last.

> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS
> repo of your packaging, if any.

Ack. Removed.

I would be glad if it could be uploaded after the changes. The package
is again available on mentors:
- dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

Paul

George Danchev wrote:

> On Monday 30 June 2008, Paul Gevers wrote:
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "winff". This is my first
>> contribution to Debian.
>>
>> * Package name    : winff
>>   Version         : 0.42-1
>>   Upstream Author : Matthew Weatherford <matt@...>
>> * URL             : http://www.winff.org
>> * License         : GLP-3
>>   Section         : graphics
>>
>> It builds this binary package:
>> winff      - video and audio batch converter using ffmpeg
>>
>> The package appears to be lintian clean.
>>
>> The upload would fix these bugs: 485481
>>
>> The package can be found on mentors.debian.net:
>> - URL: http://mentors.debian.net/debian/pool/main/w/winff
>> - Source repository: deb-src http://mentors.debian.net/debian unstable
>> main contrib non-free
>> - dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>>
>> I would be glad if someone would check uploaded this package for me.
>
> Hi,
>
> Some minor comments:
>
> - No need to build-depend on fpc-source or you have a strong reason doing so ?
> - Need to depend on ffmpeg since AFAICS it is being called by winff runtime.
> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS repo of
> your packaging, if any.
>

[Paul Gevers]

Dear mentors,

I found several issues myself (copyright of language files and winff
icon) and a wrong link to the icon in the desktop file, so those are fixed.

I would appreciate comments on/upload of the package. Again available at
mentors:
http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

With kind regards,
Paul

Paul Gevers wrote:

> Thanks for the quick review.
>
>> - No need to build-depend on fpc-source or you have a strong reason
>> doing so ?
>
> Removed: done.
>
>> - Need to depend on ffmpeg since AFAICS it is being called by winff
>> runtime.
>
> Huh, I am pretty sure I see it. I moved it to the first dependent
> instead of the last.
>
>> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS
>> repo of your packaging, if any.
>
> Ack. Removed.
>
> I would be glad if it could be uploaded after the changes. The package
> is again available on mentors:
> - dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>
> Paul
>
> George Danchev wrote:
>> On Monday 30 June 2008, Paul Gevers wrote:
>>> Dear mentors,
>>>
>>> I am looking for a sponsor for my package "winff". This is my first
>>> contribution to Debian.
>>>
>>> * Package name    : winff
>>>   Version         : 0.42-1
>>>   Upstream Author : Matthew Weatherford <matt@...>
>>> * URL             : http://www.winff.org
>>> * License         : GLP-3
>>>   Section         : graphics
>>>
>>> It builds this binary package:
>>> winff      - video and audio batch converter using ffmpeg
>>>
>>> The package appears to be lintian clean.
>>>
>>> The upload would fix these bugs: 485481
>>>
>>> The package can be found on mentors.debian.net:
>>> - URL: http://mentors.debian.net/debian/pool/main/w/winff
>>> - Source repository: deb-src http://mentors.debian.net/debian unstable
>>> main contrib non-free
>>> - dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>>>
>>> I would be glad if someone would check uploaded this package for me.
>> Hi,
>>
>> Some minor comments:
>>
>> - No need to build-depend on fpc-source or you have a strong reason doing so ?
>> - Need to depend on ffmpeg since AFAICS it is being called by winff runtime.
>> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS repo of
>> your packaging, if any.
>>
>
>
>
>

--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Paul Gevers]

Dear mentors,

I know I should be patient and that Lenny recently has been frozen, but
this is my first package for Debian and I would appreciate some feedback
on how I have done after a month waiting. I therefore take the liberty
to send this mail with my request for comments (or of course sponsorship).

For completeness I have added the full description of the winff package
this time.

winff      - video and audio batch converter using ffmpeg
 WinFF is a graphical user interface for FFmpeg. It will convert
 almost any video file that FFmpeg will convert. WinFF does multiple
 files in multiple formats at one time. You can, for example, convert
 mpeg's, flv's, and mov's into avi's (or DVD/VCD format or MPEG or 3gp
 etc.) all at once.

 This package provides a variety of preset conversion settings for
 common formats and devices. These presets are intended to hit the
 "sweet spot" for each individual codec. They have been written with a
 tip of the balance to quality.

> * Package name    : winff
>   Version         : 0.42-1
>   Upstream Author : Matthew Weatherford <matt@...>
> * URL             : http://www.winff.org
> * License         : GLP-3
>   Section         : graphics
>
> It builds this binary package:
> winff      - video and audio batch converter using ffmpeg
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 485481
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/w/winff
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

With kind regards
Paul

Paul Gevers wrote:

> Dear mentors,
>
> I found several issues myself (copyright of language files and winff
> icon) and a wrong link to the icon in the desktop file, so those are fixed.
>
> I would appreciate comments on/upload of the package. Again available at
> mentors:
> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>
> With kind regards,
> Paul
>
> Paul Gevers wrote:
>> Thanks for the quick review.
>>
>>> - No need to build-depend on fpc-source or you have a strong reason
>>> doing so ?
>>
>> Removed: done.
>>
>>> - Need to depend on ffmpeg since AFAICS it is being called by winff
>>> runtime.
>>
>> Huh, I am pretty sure I see it. I moved it to the first dependent
>> instead of the last.
>>
>>> - Vcs-Browser: is not for upstream repo, but for yours, i.e. the VCS
>>> repo of your packaging, if any.
>>
>> Ack. Removed.
>>
>> I would be glad if it could be uploaded after the changes. The package
>> is again available on mentors:
>> - dget
>> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc
>>
>> Paul

--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Paul Gevers]

Dear mentors,

The last couple of weeks my new package winff was not able to build on
sid, because one of the build-depends had a bug. This was resolved
yesterday, so therefore I kindly ask anew for review and comments on my
first package winff, which is a GUI for ffmpeg. It converts video/audio
files into any other format that ffmpeg supports. It comes with a set of
optimized conversion settings for different formats.

A teaser: this program has been downloaded more than one million times.

The homepage: http://www.winff.org
The package: http://mentors.debian.net/debian/pool/main/w/winff (This
has not been changed.)

With kind regards,
Paul

Paul Gevers wrote:

> winff      - video and audio batch converter using ffmpeg
>  WinFF is a graphical user interface for FFmpeg. It will convert
>  almost any video file that FFmpeg will convert. WinFF does multiple
>  files in multiple formats at one time. You can, for example, convert
>  mpeg's, flv's, and mov's into avi's (or DVD/VCD format or MPEG or 3gp
>  etc.) all at once.
>
>  This package provides a variety of preset conversion settings for
>  common formats and devices. These presets are intended to hit the
>  "sweet spot" for each individual codec. They have been written with a
>  tip of the balance to quality.
>
>> * Package name    : winff
>>   Version         : 0.42-1
>>   Upstream Author : Matthew Weatherford <matt@...>
>> * URL             : http://www.winff.org
>> * License         : GLP-3
>>   Section         : graphics
>>
>> It builds this binary package:
>> winff      - video and audio batch converter using ffmpeg
>>
>> The package appears to be lintian clean.
>>
>> The upload would fix these bugs: 485481
>>
>> The package can be found on mentors.debian.net:
>> - URL: http://mentors.debian.net/debian/pool/main/w/winff
>> - Source repository: deb-src http://mentors.debian.net/debian unstable
>> main contrib non-free
>> - dget
>> http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-1.dsc

[Vincent Bernat-3]

OoO En ce  début d'après-midi ensoleillé du dimanche  10 août 2008, vers
15:15, Paul Gevers <paul@...> disait :

> I know I should be patient and that Lenny recently has been frozen, but
> this is my first package for Debian and I would appreciate some feedback
> on how I have done after a month waiting. I therefore take the liberty
> to send this mail with my request for comments (or of course sponsorship).

> For completeness I have added the full description of the winff package
> this time.

Hi Paul!

There are only very minor problems with your package:
 - You don't  need to  include  README.Debian in  debian/docs. This  is
   included automatically.
 - You don't need debian/postinst, debian/postrm, they are automatically
   generated by dh_installmenu and dh_installdocs.

You can also correct this lintian warning:

I: winff: desktop-entry-contains-encoding-key /usr/share/applications/winff.desktop:3 Encoding
N:
N:   The Encoding key is now deprecated by the FreeDesktop standard and all
N:   strings are required to be encoded in UTF-8. This desktop entry
N:   explicitly specifies an Encoding of UTF-8, which is harmless but no
N:   longer necessary.
N:  
N:   Refer to
N:   http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for
N:   details.

The package seems fine otherwise. This is really good for a first package.
--
les seuls qui lisent les FAQs sont ceux qui savent déjà ce qu'il
 y a dedans.
 -+- AT in: Guide du Cabaliste Usenet - chapitre 4 -+-

[Paul Gevers]

Thanks for the review. Comments below.

Vincent Bernat wrote:
> Hi Paul!
>
> There are only very minor problems with your package:
>  - You don't  need to  include  README.Debian in  debian/docs. This  is
>    included automatically.

Removed from debian/docs. Done.

>  - You don't need debian/postinst, debian/postrm, they are automatically
>    generated by dh_installmenu and dh_installdocs.

Removed. I assume the same goes for the debian/prerm. Done.

> You can also correct this lintian warning:
>
> I: winff: desktop-entry-contains-encoding-key /usr/share/applications/winff.desktop:3 Encoding
> N:
> N:   The Encoding key is now deprecated by the FreeDesktop standard and all
> N:   strings are required to be encoded in UTF-8. This desktop entry
> N:   explicitly specifies an Encoding of UTF-8, which is harmless but no
> N:   longer necessary.
> N:  
> N:   Refer to
> N:   http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for
> N:   details.

Removed the appropriate line. I did not get the lintian warning thou, so
what did I do wrong during my checking of this package?

Because I did not need to create a linked file I also removed dh_link
from the rules file.

By the way, should I mention the changes for mentors also in the
changelog? It looks to me that you don't want them in "real" Debian, so
I left them out, but I am not sure.

Uploaded again to mentors (bumped version to -2 for comparison):
- URL: http://mentors.debian.net/debian/pool/main/w/winff
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-2.dsc

With kind regards,
Paul

[Vincent Bernat-3]

OoO En ce  début d'après-midi ensoleillé du vendredi  05 septembre 2008,
vers 15:07, Paul Gevers <paul@...> disait :

>> I: winff: desktop-entry-contains-encoding-key /usr/share/applications/winff.desktop:3 Encoding
>> N:
>> N:   The Encoding key is now deprecated by the FreeDesktop standard and all
>> N:   strings are required to be encoded in UTF-8. This desktop entry
>> N:   explicitly specifies an Encoding of UTF-8, which is harmless but no
>> N:   longer necessary.
>> N:  
>> N:   Refer to
>> N:   http://standards.freedesktop.org/desktop-entry-spec/1.0/apc.html for
>> N:   details.

> Removed the appropriate line. I did not get the lintian warning thou, so
> what did I do wrong during my checking of this package?

Hi Paul!

This is  an "informational" warning. You need  to use "-I" to  get it. I
usually uses "lintian -viI".

> By the way, should I mention the changes for mentors also in the
> changelog? It looks to me that you don't want them in "real" Debian, so
> I left them out, but I am not sure.

It depends  of the sponsor.  Personally, I don't  care: it is  easier to
compare what have  been done when you put a different  version but it is
harder to  build the proper package  (you need to not  forget to include
original tarball and all changelog entries).

> Uploaded again to mentors (bumped version to -2 for comparison):
> - URL: http://mentors.debian.net/debian/pool/main/w/winff
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/w/winff/winff_0.42-2.dsc

Seems fine. Uploaded.
--
printk("autofs: Out of inode numbers -- what the heck did you do??\n");
        2.0.38 /usr/src/linux/fs/autofs/root.c