RFS: joystick (updated package)

[Stephen Kitt-2]

Dear mentors,

I am looking for a sponsor for the new version 20051019-3
of the package "joystick", which I'd like to adopt (it's been orphaned since
February, and last had a maintainer upload in October 2005).

It builds these binary packages:
joystick   - Testing and calibration tools

The package appears to be lintian clean.

The upload would fix these bugs: 144768, 338139, 419342, 444142, 465928; in
particular 338139 is annoying for Lenny since it can lead to warnings when
switching to a dependency-based boot.

The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/j/joystick
- Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/j/joystick/joystick_20051019-3.dsc

I would be glad if someone uploaded this package for me.

Kind regards
 Stephen Kitt


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Ben Finney-5]

Stephen Kitt <lists@...> writes:

> joystick   - Testing and calibration tools

That synopsis should follow the Best Packaging Practices
<URL:http://www.debian.org/doc/manuals/developers-reference/ch-best-pkging-practices.en.html#s-bpp-pkg-synopsis>.

The above synopsis is too vague, not telling the reader what it is
for. It also should be an appositive clause, not capitalised like the
start of a sentence.

A better synopsis might be:

    set of testing and calibration tools for joysticks

--
 \       “Liberty, n. One of imagination's most precious possessions.” |
  `\                   —Ambrose Bierce, _The Devil's Dictionary_, 1906 |
_o__)                                                                  |
Ben Finney


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

Hi Stephen,

On Wed, Jul 23, 2008 at 01:25:47AM +0200, Stephen Kitt wrote:
> Dear mentors,
>
> I am looking for a sponsor for the new version 20051019-3
> of the package "joystick", which I'd like to adopt (it's been orphaned since
> February, and last had a maintainer upload in October 2005).
[snip]
> The upload would fix these bugs: 144768, 338139, 419342, 444142, 465928; in
> particular 338139 is annoying for Lenny since it can lead to warnings when
> switching to a dependency-based boot.

Thanks for picking this up and for your work on it.  Just a few comments:

  0 - There's a priority mismatch, you should change it to extra to
  match the override file.
  1 - You should move to a newer debhelper version, v4 is really old at
  this point.
  2 - It doesn't look like it'd take too much to accomodate #475049 --
  just a quick change and the writing of a short manpage.  See if you
  can do this.
  3 - It seems to me that some of the patches currently in
  debian/patches went upstream a while ago.  It might be worthwhile
  packaging a newer CVS snapshot and using that.
  4 - Also, it would be better to forward these patches to upstream (if
  they're still alive).

Otherwise, it looks good and if you fix 0,1,2 I'd be happy to sponsor it.

--Joe


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Stephen Kitt-2]

On Wed, 23 Jul 2008 11:38:50 +1000, Ben Finney <ben+debian@...>
wrote:
> Stephen Kitt <lists@...> writes:
> > joystick   - Testing and calibration tools
>
> That synopsis should follow the Best Packaging Practices
> <URL:http://www.debian.org/doc/manuals/developers-reference/ch-best-pkging-practices.en.html#s-bpp-pkg-synopsis>.
>
[...]
> A better synopsis might be:
>
>     set of testing and calibration tools for joysticks

Thanks, I didn't think to check the short description when going over the
package!

I'll fix it in the next upload.

Regards,

Stephen


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Stephen Kitt-2]

On Wed, 23 Jul 2008 02:04:41 +0000, Joe Nahmias <jello@...> wrote:
> Thanks for picking this up and for your work on it.  Just a few comments:
>
>   0 - There's a priority mismatch, you should change it to extra to
>   match the override file.
>   1 - You should move to a newer debhelper version, v4 is really old at
>   this point.

Thanks for the suggestions! These are easy enough...

>   2 - It doesn't look like it'd take too much to accomodate #475049 --
>   just a quick change and the writing of a short manpage.  See if you
>   can do this.

I thought about handling this one as well, but evtest is also shipped in
lineakd (with a manpage), so adding it would require some coordination. I
suppose I could just add a "Conflicts:" and see if anyone complains, but it
seems a bit late in the game to get this particular change done correctly and
still have an updated package in Lenny, doesn't it?

>   3 - It seems to me that some of the patches currently in
>   debian/patches went upstream a while ago.  It might be worthwhile
>   packaging a newer CVS snapshot and using that.

The last CVS update was to inputattach.c, on February 8 2006; apart from that
there had been no changes since April 22 2005. The version of inputattach.c
used in my updated package is taken from
http://kernel.org/pub/linux/kernel/people/dtor/inputattach.c rather than
upstream CVS (the version used includes all the changes in the last CVS
update).

>   4 - Also, it would be better to forward these patches to upstream (if
>   they're still alive).

As far as I can determine there is no upstream now... I'll try contacting
Vojtech Pavlik anyway, he's still active on LKML.

> Otherwise, it looks good and if you fix 0,1,2 I'd be happy to sponsor it.

Thanks! I'll upload a new version with 0 and 1 fixed as well as Ben's updated
short description.

Regards,

Stephen


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Stephen Kitt-2]

On Wed, 23 Jul 2008 07:45:56 +0200, Stephen Kitt <lists@...> wrote:

> On Wed, 23 Jul 2008 02:04:41 +0000, Joe Nahmias <jello@...> wrote:
> > Thanks for picking this up and for your work on it.  Just a few comments:
> >
> >   0 - There's a priority mismatch, you should change it to extra to
> >   match the override file.
> >   1 - You should move to a newer debhelper version, v4 is really old at
> >   this point.
>
> Thanks for the suggestions! These are easy enough...
>
> >   2 - It doesn't look like it'd take too much to accomodate #475049 --
> >   just a quick change and the writing of a short manpage.  See if you
> >   can do this.
>
> I thought about handling this one as well, but evtest is also shipped in
> lineakd (with a manpage), so adding it would require some coordination. I
> suppose I could just add a "Conflicts:" and see if anyone complains, but it
> seems a bit late in the game to get this particular change done correctly
> and still have an updated package in Lenny, doesn't it?

Actually lineakd diverts evtest and its manpage, so I can ship them in
joystick without conflicting.

> Thanks! I'll upload a new version with 0 and 1 fixed as well as Ben's
> updated short description.

In the end I've uploaded version -4 with 0, 1 and 2 fixed as well as Ben's
updated short description.

The changelog is:
  * Update short description as suggested by Ben Finney.
  * Set priority to extra to match the override file, as suggested by Joe
    Nahmias.
  * Use debhelper 7, as hinted by Joe Nahmias and the debhelper
    documentation.
  * Remove versioned dependency on cdbs since even oldstable has a new
    enough version.
  * Ship evtest and associated manpage; lineakd diverts them so this package
    need not conflict with lineakd, but it does need to conflict with
    dvb-utils (which will not ship with Lenny). Closes: #475049

Regards,

Stephen


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Joe Nahmias]

On Thu, Jul 24, 2008 at 12:11:48AM +0200, Stephen Kitt wrote:
> On Wed, 23 Jul 2008 07:45:56 +0200, Stephen Kitt <lists@...> wrote:
> > On Wed, 23 Jul 2008 02:04:41 +0000, Joe Nahmias <jello@...> wrote:
[snip]

> > >   2 - It doesn't look like it'd take too much to accomodate #475049 --
> > >   just a quick change and the writing of a short manpage.  See if you
> > >   can do this.
> >
> > I thought about handling this one as well, but evtest is also shipped in
> > lineakd (with a manpage), so adding it would require some coordination. I
> > suppose I could just add a "Conflicts:" and see if anyone complains, but it
> > seems a bit late in the game to get this particular change done correctly
> > and still have an updated package in Lenny, doesn't it?
>
> Actually lineakd diverts evtest and its manpage, so I can ship them in
> joystick without conflicting.
>
> > Thanks! I'll upload a new version with 0 and 1 fixed as well as Ben's
> > updated short description.
>
> In the end I've uploaded version -4 with 0, 1 and 2 fixed as well as Ben's
> updated short description.

However, you don't mention evtest in the long description...

Also, the manpage for inputattach seems very out of date, or just plain
deficient.

Finally, there are a bunch of lintian warnings that you should address.

I fixed the first and uploaded.  I'll leave the rest to you ;-)

--Joe


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...

[Stephen Kitt-2]

On Thu, 24 Jul 2008 02:31:35 +0000, joe@... (Joseph Nahmias) wrote:
> However, you don't mention evtest in the long description...
>
> Also, the manpage for inputattach seems very out of date, or just plain
> deficient.
>
> Finally, there are a bunch of lintian warnings that you should address.
>
> I fixed the first and uploaded.  I'll leave the rest to you ;-)

Thank you very much! I'll tackle the rest, as well as the remaining bugs and
getting the patches upstream...

Regards,

Stephen


--
To UNSUBSCRIBE, email to debian-mentors-REQUEST@...
with a subject of "unsubscribe". Trouble? Contact listmaster@...